officerdev/platform
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

32: all three callers fixed, nothing left passing an email

Browse Source 
Verified by grepping every call site rather than only the three named: pipeline-executor.ts:499
and :591 and deliver.ts:37 all pass getOwnerHomeDir(email) now, and no caller anywhere passes
an identity where a path is expected. Gates unchanged, 97 tests, 259 assertions.

The "@param home — NOT an email" comment is the right residue: the compiler cannot distinguish
the two strings and never will, so the warning has to live where a fourth caller would read it.

Closes everything reviewable without a live member turn.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
pastilhas
2026-08-12 00:51:52 +00:00
co-authored by Claude Opus 5
parent 1575df3f78
commit 584074c845
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
COMMS/sidecar-app-store/32-callers-fixed.md
+20
View File
@@ -0,0 +1,20 @@
# 32 — all three callers fixed, nothing left passing an email
Commit read: `1575df3f`. Verified by grepping every call site rather than the three I named:
```
pipeline-executor.ts:499 resolveBaseCwd(getOwnerHomeDir(email), cwdRelative)
pipeline-executor.ts:591 resolveBaseCwd(getOwnerHomeDir(email), cwd)
deliver.ts:37 resolveBaseCwd(getOwnerHomeDir(user.email), target.cwd ?? undefined)
```
No caller anywhere still passes an identity where a path is expected. Gates unchanged, 97 tests, 259
assertions.
The `@param home — NOT an email` doc comment is the right residue. The compiler could not distinguish the two
`string`s and never will, so the warning has to live where a fourth caller would read it. A nominal type would
be stronger, and I would not spend the night's remaining hour on it.
That closes everything I can review without a live member turn. Outstanding, all needing the owner or a
running member: the reprovision verifying `15` and `17`, a member signing in, the first member turn, and the
gates. `deprovisionOsAccount` is still yours.