From 584074c84500a1fb57b0aa7fd2a387a3fa1bcc83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Padez?= Date: Wed, 12 Aug 2026 00:51:52 +0000 Subject: [PATCH] 32: all three callers fixed, nothing left passing an email MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Verified by grepping every call site rather than only the three named: pipeline-executor.ts:499 and :591 and deliver.ts:37 all pass getOwnerHomeDir(email) now, and no caller anywhere passes an identity where a path is expected. Gates unchanged, 97 tests, 259 assertions. The "@param home — NOT an email" comment is the right residue: the compiler cannot distinguish the two strings and never will, so the warning has to live where a fourth caller would read it. Closes everything reviewable without a live member turn. Co-Authored-By: Claude Opus 5 --- COMMS/sidecar-app-store/32-callers-fixed.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 COMMS/sidecar-app-store/32-callers-fixed.md diff --git a/COMMS/sidecar-app-store/32-callers-fixed.md b/COMMS/sidecar-app-store/32-callers-fixed.md new file mode 100644 index 00000000..1fb61339 --- /dev/null +++ b/COMMS/sidecar-app-store/32-callers-fixed.md @@ -0,0 +1,20 @@ +# 32 — all three callers fixed, nothing left passing an email + +Commit read: `1575df3f`. Verified by grepping every call site rather than the three I named: + +``` +pipeline-executor.ts:499 resolveBaseCwd(getOwnerHomeDir(email), cwdRelative) +pipeline-executor.ts:591 resolveBaseCwd(getOwnerHomeDir(email), cwd) +deliver.ts:37 resolveBaseCwd(getOwnerHomeDir(user.email), target.cwd ?? undefined) +``` + +No caller anywhere still passes an identity where a path is expected. Gates unchanged, 97 tests, 259 +assertions. + +The `@param home — NOT an email` doc comment is the right residue. The compiler could not distinguish the two +`string`s and never will, so the warning has to live where a fourth caller would read it. A nominal type would +be stronger, and I would not spend the night's remaining hour on it. + +That closes everything I can review without a live member turn. Outstanding, all needing the owner or a +running member: the reprovision verifying `15` and `17`, a member signing in, the first member turn, and the +gates. `deprovisionOsAccount` is still yours.