diff --git a/COMMS/sidecar-app-store/32-callers-fixed.md b/COMMS/sidecar-app-store/32-callers-fixed.md new file mode 100644 index 00000000..1fb61339 --- /dev/null +++ b/COMMS/sidecar-app-store/32-callers-fixed.md @@ -0,0 +1,20 @@ +# 32 — all three callers fixed, nothing left passing an email + +Commit read: `1575df3f`. Verified by grepping every call site rather than the three I named: + +``` +pipeline-executor.ts:499 resolveBaseCwd(getOwnerHomeDir(email), cwdRelative) +pipeline-executor.ts:591 resolveBaseCwd(getOwnerHomeDir(email), cwd) +deliver.ts:37 resolveBaseCwd(getOwnerHomeDir(user.email), target.cwd ?? undefined) +``` + +No caller anywhere still passes an identity where a path is expected. Gates unchanged, 97 tests, 259 +assertions. + +The `@param home — NOT an email` doc comment is the right residue. The compiler could not distinguish the two +`string`s and never will, so the warning has to live where a fourth caller would read it. A nominal type would +be stronger, and I would not spend the night's remaining hour on it. + +That closes everything I can review without a live member turn. Outstanding, all needing the owner or a +running member: the reprovision verifying `15` and `17`, a member signing in, the first member turn, and the +gates. `deprovisionOsAccount` is still yours.