pastilhasandClaude Opus 5
25c8502c4b
three small things, one of which turned out to be a bug in what shipped an hour ago. CREATE. a POST to /_officer/event, and the SIDECAR builds the file — the browser sends title, when and where. a UID, a DTSTAMP and a UTC timestamp each have exactly one correct form, and that belongs next to the parser that reads them back, not in a react component. it writes the minimum a VEVENT can legally be: no recurrence, no alarms, no attendees. this app cannot show those, and a field the list cannot display is a field that silently disappears on the next edit. times go in as UTC. the alternative is DTSTART;TZID plus a VTIMEZONE block defining that zone's rules, and a subtly wrong VTIMEZONE moves an event by an hour twice a year. UTC needs no definition and every client renders it local. all-day is the other trap: RFC 5545 makes DTEND EXCLUSIVE, so a one-day event on the 29th ends on the 30th — write the 29th and some clients draw nothing at all. the form takes the last day a person means and the builder adds the day. NEWEST DAY ON TOP. a calendar accumulates years, so ascending opened on whatever was imported first and this week was a scroll away. within a day the order stays chronological, because that is what a day is. ?collection=ra-guide, NOT ?collection=%2Fdav%2F1%2Fra-guide%2F. the path is /dav/<userId>/<name>/, so the escaped form spent six characters on slashes to say `ra-guide` and put the owner's user id in a URL people paste at each other. the name is unique within a user, which is all a selector needs, and the full path is recovered from the collections list the screen already loaded. a full path in the param still resolves, because somebody's bookmark has one. AND THE BUG. setProperty replaced a property's first line and left its continuation lines behind. a value over 75 octets is FOLDED onto lines starting with a space — so editing a long summary left the old tail folded onto the new value, and each edit inherited the last one's ending. it only bites on long values, which is why the first round of testing missed it. the fix consumes the whole folded run and folds what it writes; both are now under test, including the accent-near-the-boundary case that a naive slice(0,75) cuts in half. verified live: both event shapes written and read back, escaping round-tripped, and a long summary edited twice with no accumulation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
60 lines
2.4 KiB
TypeScript
60 lines
2.4 KiB
TypeScript
// Shared wire shapes for the /calendar and /contacts workspaces.
|
|
//
|
|
// These mirror what the officer-caldav sidecar returns from its JSON door under /api/caldav/_officer/* —
|
|
// see src/servers/sidecar/caldav/{collections,ical}.ts, which is where they are produced. The sidecar
|
|
// parses the iCalendar/vCard itself so nothing here ever sees DAV XML.
|
|
|
|
/** One calendar or address book. `path` addresses it over DAV; `name` is what the URL selects it by. */
|
|
export type DavCollection = {
|
|
/** The DAV path, `/dav/<userId>/<name>/`. What every API call takes. */
|
|
path: string;
|
|
/** The last segment of that path. Unique within a user, and the only part worth putting in a URL. */
|
|
name: string;
|
|
displayName: string;
|
|
kind: 'calendar' | 'addressbook';
|
|
color?: string;
|
|
};
|
|
|
|
export type CalendarEvent = {
|
|
uid: string;
|
|
/** The DAV href — where this event lives. What edit and delete address; never derived from the uid. */
|
|
href?: string;
|
|
summary: string;
|
|
description?: string;
|
|
location?: string;
|
|
start?: string;
|
|
end?: string;
|
|
allDay: boolean;
|
|
/** Raw RRULE, unexpanded — the sidecar does not expand a series, so this is a badge, not occurrences. */
|
|
rrule?: string;
|
|
status?: string;
|
|
};
|
|
|
|
export type DavContact = {
|
|
uid: string;
|
|
/** The DAV href — where this contact lives. What edit and delete address; never derived from the uid. */
|
|
href?: string;
|
|
fullName: string;
|
|
emails: string[];
|
|
phones: string[];
|
|
org?: string;
|
|
title?: string;
|
|
hasPhoto: boolean;
|
|
};
|
|
|
|
/**
|
|
* The query param both screens select with. Per the navigation rules the selection lives in the URL, and
|
|
* a query param rather than a path segment because the detail IS the screen — there is nothing to route to.
|
|
*
|
|
* IT CARRIES THE NAME, NOT THE PATH. `?collection=personal`, not
|
|
* `?collection=%2Fdav%2F1%2Fpersonal%2F`. The path is `/dav/<userId>/<name>/`, so the escaped version
|
|
* spent six characters on slashes to say `personal` and put the owner's user id in a URL people paste at
|
|
* each other. The name is unique within a user, which is all a selector needs; the full path is
|
|
* recovered from the collections list, which the screen has already loaded.
|
|
*/
|
|
export const COLLECTION_PARAM = 'collection';
|
|
|
|
/** The one place the two screens' URLs are spelled, so nav links and guards cannot drift. */
|
|
export const davCollectionPath = (base: '/calendar' | '/contacts', name: string) =>
|
|
`${base}?${COLLECTION_PARAM}=${encodeURIComponent(name)}`;
|