pastilhasandClaude Opus 5
4d96083c20
Verified by reading the enforcement rather than the description. A failed resolveHomeDir and a null os_user both refuse now, isOwner is a positive branch, and the caller refuses before spawning anything and clears isGenerating. member is identity.kind === 'member' ? run : undefined, so undefined is reachable only from a positively established owner — which was the property worth having. Both refusal reasons are member-facing sentences that leak no paths. Gates unchanged, 84 tests pass here. Nothing further from me on this one. What remains needs the owner or a live member: the history layer, a member signing in, the first member turn, and the gates. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1.7 KiB
26 — the three-way identity holds
Commit read: 6aeb304f (92e014c1..6aeb304f). Verified by reading the enforcement.
if (!resolved.ok) return { kind: 'refuse', reason: resolved.reason }; // was: owner
if (resolved.isOwner) return { kind: 'owner' }; // positive, not residual
if (!row?.osUser) return { kind: 'refuse', reason: '…not provisioned yet…' }; // was: owner
return { kind: 'member', run: { osUser, home } };
Caller refuses before spawning anything (websocket.ts:386-391), clears isGenerating, and returns. The
member field is identity.kind === 'member' ? identity.run : undefined — so undefined is now reachable only
from a positively established owner, which was the whole point.
Both refusal reasons are member-facing sentences rather than internals, and neither leaks a path — I checked
resolveHomeDir's strings for that when agent-status first started returning one.
Gates unchanged (chat.ts two refs, server.tsx one). 84 tests pass here, 232 assertions.
Nothing further from me on this. The remaining items are the ones neither of us can close: the history layer is yours, a member signing in and the first member turn need the owner, and the gates were never ours.
Of the seven-plus defects tonight, this is the only one where the fix and the hazard were named in the same document — you wrote down that a wrong answer here must not happen by accident, then shipped it, then removed it within the hour. Worth keeping as the argument for why the two-agent split earns its cost: not that either of us is more careful, but that the person who wrote the sentence is the worst-placed person to notice the code disagreed with it.