pastilhasandClaude Opus 5 84d6d7e7ce file browser: the eight defects from the audit
1. Kebab Cut/Copy silently did nothing, and sometimes cut the wrong rows.
   `EllipsisMenu` stops click propagation so opening it does not toggle
   selection — but Cut, Copy, Download, Delete and Compress all act on the
   SELECTION, which meant the kebab operated on whatever was selected elsewhere,
   or returned early with no toast at all. Right-click never had this because it
   selects first. Both now call one `ensureSelected`, on open.

2. Every menu vanished during a search. That branch had no ContextMenu and its
   rows are not FileItems, so right-click fell through to the browser. The folder
   menu is now declared once and mounted in both branches — it acts on
   `currentPath`, which a search does not change, so it stays meaningful.

   Search ROWS get their own three-item menu rather than the row menu: a hit
   carries an absolute path from anywhere in the tree, while every row-menu
   handler builds its path from the folder being browsed. Reusing it would have
   acted on a different file with the same name. `DirEntry.path` is optional —
   only search results carry one — so it is guarded, not asserted.

3. Download and Copy path now fan out over a multi-selection, the rule Delete and
   Compress already used. The menu downloaded one of six selected files while the
   toolbar zipped all six.

   Chat is deliberately NOT included: `chatContext` is a single path that the
   provider string-splits into a working directory, so a list would need Chat's
   contract changed. Left alone rather than half-done.

4. Read Aloud stopped offering TTS on binaries — same guard the editor got, since
   `text` is `getFileType`'s fallback and caught .exe and .sqlite.

5. `POST /file-browser/download` is filed as a read. It zips a selection and
   writes nothing; it is a POST only because a list of paths does not fit a query
   string. A read-level member could download a whole folder but not two files.
   Proved by hand that `readOnlyWrites: ['/download']` permits GET and POST
   /download, and still denies /download-video, /rm and /write — `isPrefixOf` is
   segment-aware, so the sibling route does not leak.

6. `disabled` had no use anywhere in the feature — the shared item type did not
   even expose it. It does now, and the first real case: `/file-browser/read`
   refuses over 5 MB, so Open in editor on a 40 MB log opened an editor that then
   failed. Hiding it would have suggested the file is not text; disabled says the
   true thing.

7. The grid kebab could fade out while its own dropdown was open — list view had
   `data-[state=open]:opacity-100` and grid did not.

8. Dead exports `getMatchingTasks` / `getMatchingAgents` removed. Both were the
   ungrouped input to the grouped form the menu actually renders; exporting them
   invited a second code path that never arrived.

9 is untouched on purpose — a plugin cannot register a menu item, and the music
plugin is where that should be designed.

tsgo clean, frontend builds, 808 pass / 7 fail unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-15 19:31:05 +00:00
2026-02-16 19:34:35 +00:00
2026-02-16 19:34:35 +00:00
2026-02-16 19:34:35 +00:00
2026-02-22 03:35:26 +00:00
2026-02-16 19:34:35 +00:00
2026-02-16 19:34:35 +00:00

The documentation, triaged

2026-08-13. A map of what is in here, what it is for, and what should happen to it. Made because there are 42 documents and 13,000 lines, and no way to tell from the filenames which describe the system as it is and which are a record of an afternoon in July.

How much I verified: the classifications below are from filenames, status lines, and greps for things that changed on 2026-08-13. Where I actually read the document or checked the code, it says so. The rest is a starting point for a conversation, not a verdict.


Living — these describe the system and must stay true

doc state
working-on-officer.md updated 2026-08-13. Operational guide.
secret-store.md updated 2026-08-13. Built; rotation still open.
install-variants.md new. The branch tree, for discussion.
http-secure-context-audit.md new. What breaks over plain http.
install-container-testing.md new. First container pass and its findings.
per-user-linux-accounts.md partly updated. OFFICER_OS_USERS is gone; check the rest.
navigation-audit.md authoritative on routing. Unverified against tonight's route removals.
workspace-panels.md + workspace-panel-todo.md the panel framework. 1,300 lines combined — likely the biggest cleanup here.
agent-coordination.md the north star for panel work.
deprovision-os-account.md implemented; the 'disabled' stage it may mention was deleted tonight.

Stale — describe things that changed on 2026-08-13

Each of these references something that no longer exists. Not yet corrected.

  • sidecar-topology.md — "ecosystem.config.cjs is the source of truth". It is generated now, and holds six processes.
  • sidecar-app-store.md — derives the catalogue from full light. Those files are gone, and catalogue.test.ts was rewritten.
  • sidecar-bootstrapping.md — "20 PM2 entries, 18 sidecar dirs". Six entries now.
  • mobile-api-keys.md — partly corrected; recheck the origin-checking claims.
  • wallet-key-custody.mdVAULT_STORE_KEY is now the per-purpose wallet key.
  • push-notifications.md — "agreed design, 2026-07-31". Notify is a plugin and unmounted.
  • chat-session-lifetime.md, chat-ui-walkthrough.md — reference officer-agent, renamed.

Historical — a record of a moment, and should stay one

Do not rewrite these to match today's code. They document how a decision was reached, and editing them destroys the reasoning. If they mislead, add a dated header pointing forward.

  • sidecar-audit-2026-07.md (1,377 lines)
  • claude-sidecar-isolation.md — records the officer-claudeofficer-agent rename that preceded tonight's officer-agentofficer-claude-code
  • open-threads-after-per-user-claude.md
  • two-agent-field-report-2026-08-12.md
  • api-method-changes-2026-08-06.md

The opencode cluster — nine documents for one migration

opencode-fork-decision · -parity · -api-2-assessment · -phase0-review · -phase1-report · -phase1-review · -serve-migration-plan · -serve-path · -testing-checklist

The migration landedopencode serve is in the sidecar, verified. So opencode-serve-migration-plan.md saying "Nothing here is implemented" is false.

This is the clearest consolidation candidate in the whole directory: one document recording what was decided and what shipped, replacing nine that describe stages of getting there. I did not do it because it needs reading all nine, and deleting documents unread is not a thing to do at 4am.

The mobile-dav thread — three documents, one conversation

mobile-dav-provisioning · -feedback · -reply. A correspondence. Almost certainly one document.

Unclassified — I have not looked

design-language-interface · file-sync · jobs-unification · mobile-photo-sync-api · nextcloud-replacement · agent-git-identity


The plugin split, which affects most of the above

A core install is six processes. Everything else is a plugin, switched off tonight but present on disk. Most documents here were written when the estate was twenty processes and every one of them was simply "there", so they describe availability that no longer holds.

The useful rewrite is usually one line, not a rewrite: say whether the thing described is core or a plugin, and if a plugin, that it is not mounted on a fresh install.

S
Description
No description provided
Readme
42 MiB
Languages
TypeScript 90.6%
Shell 4.9%
JavaScript 4.2%
CSS 0.2%
HTML 0.1%