Compare commits
4
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
ff647fba0a | ||
|
|
2f8a2b60d5 | ||
|
|
454a0f4244 | ||
|
|
a48a7ff696 |
@@ -0,0 +1,61 @@
|
||||
# 2026.08.23.04
|
||||
|
||||
The web UI can be read in Portuguese. The shell and the shared components are fully keyed — 581 keys across
|
||||
two locales, with the build failing on a missing one — plus an endpoint for spawning an agent, and spawned
|
||||
agents becoming visible in both directions.
|
||||
|
||||
**No schema change.** Nothing under `src/databases/**/schema.ts` moved across
|
||||
`deploy/2026.08.23.03..HEAD`. `bun db:push` is still a step because it is cheap and it verifies the
|
||||
database agrees with the code, but it should report no changes.
|
||||
|
||||
**No dependency change.** `bun.lock` is untouched. **Do not run `bun install`.**
|
||||
|
||||
## What is in it
|
||||
|
||||
- **Localization, phases 0 through 2.** `src/apps/officer-web` and `src/workspaces/components` have no
|
||||
hardcoded user-facing strings left: 555 and 47 occurrences respectively, both now zero. `en-GB` and
|
||||
`pt-PT` are complete and in step at 581 keys.
|
||||
- **Every locale ships a complete catalogue.** There is no fallback between regional variants, so a
|
||||
Portuguese reader is never served Brazilian wording. What enforces that is a **key-parity test that fails
|
||||
the build** on a gap — verified by removing one key and watching it go red.
|
||||
- **The language picker offers only locales that exist.** It listed about twenty codes, eighteen of which
|
||||
silently rendered English. Stored bare codes widen on read (`en` → `en-GB`), with no database migration.
|
||||
- **Dates, numbers and plurals follow the account's locale**, not the browser's, through `useFormat()` and
|
||||
`Intl.PluralRules`. Roughly 23 call sites moved.
|
||||
- **`POST /api/sub-agents/spawn`** — an endpoint for starting an agent from a prompt, for callers that are
|
||||
not a chat and so cannot reach the harness's own tool. Budget-checked before spawning, and it refuses with
|
||||
a 429 naming the window rather than burning the last of one.
|
||||
- **Spawned agents are visible in both directions.** A commander's pane lists its children as links; opening
|
||||
one shows which commander started it, linking back.
|
||||
- **A dropped sidecar command says so.** `sendFire` did nothing when no sidecar was registered — no log, no
|
||||
error — so answering a question during a restart window vanished and the card spun forever.
|
||||
|
||||
## Every host
|
||||
|
||||
1. `git fetch origin --tags` then `git merge --ff-only deploy/2026.08.23.04`
|
||||
2. `bun db:push` — expect **no changes**. If it wants to alter something, stop and report it: that means
|
||||
this tree and that host's database disagree about something this release did not touch.
|
||||
3. `bun run plugins:update`
|
||||
4. `pm2 restart officer`
|
||||
|
||||
`officer` only. Step 3 restarts each plugin's own sidecar; that is the script's behaviour and belongs in the
|
||||
report.
|
||||
|
||||
**`macbookpro`:** append `/opt/homebrew/bin` to PATH for the `bun` commands, run `pm2` separately.
|
||||
|
||||
## What to check, this release
|
||||
|
||||
The visible change is the language picker in profile settings. It should offer exactly **English (UK)** and
|
||||
**Português (Portugal)** and nothing else. A host still offering twenty languages did not pick up the
|
||||
frontend bundle.
|
||||
|
||||
No direct SQL is needed and none is authorised.
|
||||
|
||||
## Hosts
|
||||
|
||||
- **`edge-pertento-bridge`** — skipped, per `docs/servers.md`. Name it and spend nothing on it.
|
||||
- **`production-pertento-bridge`** — deployed cleanly last release after being two behind. Nothing expected.
|
||||
|
||||
## `officer-dev` — skip it
|
||||
|
||||
The rollout runs from here. It is already at this commit and `officer` has been restarted on it.
|
||||
+34
-25
@@ -25,35 +25,44 @@ the server does instead, which is the one decision that reaches outside this bou
|
||||
|
||||
## What exists today, and what it cannot do
|
||||
|
||||
There is already an i18n system. It is small, hand-rolled, has no npm dependency, and it works. It is
|
||||
also about **5% deployed**, and that gap is the whole job.
|
||||
**Updated 2026-08-23, after phases 0, 1 and 2.** This section described the pre-phase-0 world for long
|
||||
enough that the next reader would have started from a false picture — bare `en.json`, 46 keys, three
|
||||
components. All of that is now history and is kept below only as the "before" column, because the shape of
|
||||
the gap is the argument for the plan and deleting it would leave the phases looking arbitrary.
|
||||
|
||||
| | |
|
||||
| ----------------------------------------- | -------------------------------------------------------------------------- |
|
||||
| `src/workspaces/i18n/` | the package: `I18nProvider`, `useTranslation`, `resolveKey`, `interpolate` |
|
||||
| `src/apps/officer-web/lib/i18n.ts` | a typed wrapper binding keys to `en.json` |
|
||||
| `src/apps/officer-web/lib/I18nBridge.tsx` | reads `settings.languages.default`, feeds the provider |
|
||||
| `src/apps/officer-web/locales/` | `en.json` and `pt.json` — **46 keys each, in sync** |
|
||||
| components actually using it | **3** — `UserMenu`, `Languages`, `ChangePassword` |
|
||||
| | before phase 0 | now |
|
||||
| -------------------------- | ---------------------- | --------------------------------------------- |
|
||||
| catalogs | `en.json`, `pt.json` | `en-GB.json`, `pt-PT.json` per workspace |
|
||||
| keys | 46 | **581** — 538 `app.*`, 43 `ui.*` |
|
||||
| workspaces with a catalog | 1 (`officer-web`) | 3 (`officer-web`, `components`, `officerdev`) |
|
||||
| components using it | 3 | all of `officer-web` and `components` |
|
||||
| plural rules | none | `Intl.PluralRules`, per locale |
|
||||
| dates and numbers | browser locale | `useFormat()`, the account's locale |
|
||||
| a missing key | rendered its dot-path | falls back to English, warns in dev |
|
||||
| locales offered vs shipped | ~20 offered, 2 existed | only shipped locales are offered |
|
||||
| parity enforcement | none | **a gap fails the build** |
|
||||
|
||||
What it already does well, and which this plan keeps: dot-path lookup, `{{param}}` interpolation,
|
||||
fallback to `en`, and **type-safe keys** via `TranslationKeys<typeof en>` — a wrong key is a
|
||||
typecheck failure, which is worth more than it sounds when one agent is editing 400 files.
|
||||
Still standing from the original description, and still true: the package is hand-rolled, has no npm
|
||||
dependency, and gives type-safe keys — a wrong key is a typecheck failure, which is worth more than it
|
||||
sounds when one agent is editing hundreds of files.
|
||||
|
||||
**What it cannot do yet**, each of which is a task below:
|
||||
**What remains:** `src/workspaces/officerdev` — the panels — and then translation. `panel.*` is scaffolded,
|
||||
wired into the bridge, and empty.
|
||||
|
||||
1. **No plural rules.** `1 file` / `2 files` has no expression. `Intl.PluralRules` is built into the
|
||||
runtime and unused.
|
||||
2. **No locale-aware dates or numbers.** ~23 `toLocaleDateString/TimeString/String()` call sites use
|
||||
the _browser's_ locale, not the user's chosen one, so a Portuguese UI shows American dates.
|
||||
3. **No fallback chain.** `resolveKey` falls back to `en` and nothing else, so `pt-BR` cannot inherit
|
||||
from `pt`.
|
||||
4. **One catalog, one workspace.** `locales/` lives inside `officer-web`. The 213 panel files in
|
||||
`officerdev` and the 91 in `components` have no catalog of their own.
|
||||
5. **Silent, ugly misses.** A missing key renders its own dot-path (`settings.profile.foo`) to the
|
||||
user. No warning, no test.
|
||||
6. **Twenty languages offered, two that exist.** The picker in `Languages.tsx` lists ~20 codes
|
||||
including Hebrew and Greek. Choosing any of the eighteen silently yields English.
|
||||
Two things learned doing phases 1 and 2 that the plan did not anticipate:
|
||||
|
||||
- **`TranslationKeys` walked into a plural object**, so `t('key', { count })` — the entire point of D7 —
|
||||
did not compile while `t('key.one')` did. The documented feature was uncompilable and the workaround was
|
||||
not, which no test would ever have noticed because phase 1 contained no plurals. Fixed with type-level
|
||||
assertions.
|
||||
- **The typed wrappers rebuilt `t` on every render**, which is the trap `CLAUDE.md` already records against
|
||||
`useClient()` and the Jellyfin player. It matters the moment `t` lands in a `useMemo` dependency list,
|
||||
which phase 2 needed immediately. Memoised.
|
||||
|
||||
**A shape this format cannot express:** a sentence with an inline link. Splitting around the anchor gives a
|
||||
key whose Portuguese value is `"."`. The cheap fix is rephrasing so the link falls at a clause boundary;
|
||||
there is no node-level interpolation helper and adding one is a design decision, not a patch. Worth
|
||||
raising if a phase turns out to be full of them rather than absorbing it forty times.
|
||||
|
||||
### The size of the remaining work
|
||||
|
||||
|
||||
+1
-1
@@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "officer",
|
||||
"version": "2026.08.23.03",
|
||||
"version": "2026.08.23.04",
|
||||
"private": true,
|
||||
"type": "module",
|
||||
"workspaces": [
|
||||
|
||||
@@ -30,8 +30,12 @@ const AREAS = [
|
||||
* 'shared components' landed 2026-08-23 (localization phase 1). It holds three `new Error()` messages
|
||||
* that must NEVER be translated; they are reported but excluded from the check, which is why the
|
||||
* neverTranslate split below has to exist for this entry to be possible at all.
|
||||
*
|
||||
* 'officer-web (shell)' landed 2026-08-23 (phase 2). It holds no never-translate hits of its own; what it
|
||||
* does hold is ~30 `<Untranslated reason="foreign-ui-label">` labels quoted from Google's console, which
|
||||
* `stripUntranslated` skips for the same reason.
|
||||
*/
|
||||
const ZEROED: string[] = ['shared components'];
|
||||
const ZEROED: string[] = ['shared components', 'officer-web (shell)'];
|
||||
|
||||
const SKIP = /node_modules|\.gen\.|[/\\]locales[/\\]|[/\\]vendor[/\\]|\.test\.|\.d\.ts$/;
|
||||
|
||||
|
||||
@@ -278,12 +278,18 @@ export const CapabilityChat = ({
|
||||
description,
|
||||
onResponseEnd,
|
||||
}: CapabilityChatProps) => {
|
||||
const { t } = useTranslation();
|
||||
const seedFile = `${kind.toUpperCase()}.md`;
|
||||
const genericPrefix = `<frontmatter>\ninput file: ${filePath}\n${seedFile}: ${filePath}\ndir: ${resourceDir}\n\nBe aware of any extra files alongside the same dir as the ${kind} file we're handling, for possible extra context. You can also, if pertinent, create scripts or other files that will help you in the future.\n</frontmatter>`;
|
||||
const promptFrontmatter = isNew ? (buildCreationPrefix(kind, filePath, resourceDir) ?? genericPrefix) : genericPrefix;
|
||||
/*
|
||||
The composer's PRE-FILLED text, which the reader sees and edits — so it is translated. The hidden
|
||||
`promptFrontmatter` above is not: that one instructs the agent and carries file paths, and is
|
||||
machine-facing rather than something anybody reads.
|
||||
*/
|
||||
const defaultInput = isNew
|
||||
? (description ?? `Help me create the content for this new ${kind} file`)
|
||||
: `Help me understand and improve this ${kind} file`;
|
||||
? (description ?? t('capability.createPrompt', { kind: kind.toLowerCase() }))
|
||||
: t('capability.improvePrompt', { kind: kind.toLowerCase() });
|
||||
|
||||
const chat = useChat(undefined, undefined, { replaceUrl: false });
|
||||
|
||||
|
||||
@@ -697,6 +697,8 @@
|
||||
"searchPlaceholder": "Search {{kind}}…",
|
||||
"selectOne": "Select a {{kind}}",
|
||||
"selectToView": "Select a {{kind}} to view its contents",
|
||||
"delete": "Delete"
|
||||
"delete": "Delete",
|
||||
"createPrompt": "Help me create the content for this new {{kind}} file",
|
||||
"improvePrompt": "Help me understand and improve this {{kind}} file"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -697,6 +697,8 @@
|
||||
"searchPlaceholder": "Pesquisar {{kind}}…",
|
||||
"selectOne": "Selecione um {{kind}}",
|
||||
"selectToView": "Selecione um {{kind}} para ver o seu conteúdo",
|
||||
"delete": "Eliminar"
|
||||
"delete": "Eliminar",
|
||||
"createPrompt": "Ajuda-me a criar o conteúdo deste novo ficheiro de {{kind}}",
|
||||
"improvePrompt": "Ajuda-me a compreender e melhorar este ficheiro de {{kind}}"
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user