settings framework and section metadata keyed (487 -> 425)
SettingsSection now carries titleKey/descriptionKey instead of title/description, and the sidebar and content pane resolve them. The section arrays are module-level consts holding JSX content, so they cannot call a hook — the data holds keys and the renderers translate. Sidebar search matches the RESOLVED words, so it works in the language on screen. Capital K in titleKey is load-bearing: docs-check-settings.ts greps key:\s*'…' for route segments, and a lowercase title_key would have fed it twenty bogus paths. Verified 0 bogus, 26 declared, 20 offered, 0 missing. Section titles now share one key with the Spotlight rows that name the same section, per 'one key per meaning'. Two casings had to converge, so Settings shows Spotlight's: 'Change Password' now reads 'Change password'. Settings sidebar search placeholder was 'Search...'; it is now 'Search settings…', which is what the skeleton catalog already said and what distinguishes it from the global Spotlight.
This commit is contained in:
@@ -14,12 +14,18 @@ import { VoicePreference } from './VoicePreference';
|
||||
const BASE_PATH = '/settings/profile';
|
||||
|
||||
const sections: SettingsSection[] = [
|
||||
{ key: 'profile', icon: User, title: 'Profile', description: 'Avatar, name, and email', content: <UserData /> },
|
||||
{
|
||||
key: 'profile',
|
||||
icon: User,
|
||||
titleKey: 'settings.sections.profile.label',
|
||||
descriptionKey: 'settings.sections.profile.description',
|
||||
content: <UserData />,
|
||||
},
|
||||
{
|
||||
key: 'change-password',
|
||||
icon: Lock,
|
||||
title: 'Change Password',
|
||||
description: 'Update your password',
|
||||
titleKey: 'settings.sections.changePassword.label',
|
||||
descriptionKey: 'settings.sections.changePassword.description',
|
||||
content: <ChangePassword />,
|
||||
},
|
||||
// Beside the password rather than under Integrations, where it was until 2026-08-21. A key is not an
|
||||
@@ -29,29 +35,29 @@ const sections: SettingsSection[] = [
|
||||
{
|
||||
key: 'api-keys',
|
||||
icon: KeyRound,
|
||||
title: 'API keys',
|
||||
description: 'Keys that sign in as you, revocable one at a time',
|
||||
titleKey: 'settings.sections.apiKeys.label',
|
||||
descriptionKey: 'settings.sections.apiKeys.description',
|
||||
content: <ApiKeys />,
|
||||
},
|
||||
{
|
||||
key: 'languages',
|
||||
icon: Globe,
|
||||
title: 'Languages',
|
||||
description: 'Spoken, default, and translation',
|
||||
titleKey: 'settings.sections.languages.label',
|
||||
descriptionKey: 'settings.sections.languages.description',
|
||||
content: <Languages />,
|
||||
},
|
||||
{
|
||||
key: 'voice',
|
||||
icon: Volume2,
|
||||
title: 'Voice',
|
||||
description: 'Text-to-speech voice preference',
|
||||
titleKey: 'settings.sections.voice.label',
|
||||
descriptionKey: 'settings.sections.voice.description',
|
||||
content: <VoicePreference />,
|
||||
},
|
||||
{
|
||||
key: 'dock',
|
||||
icon: LayoutGrid,
|
||||
title: 'Dock',
|
||||
description: 'Choose and reorder dock items',
|
||||
titleKey: 'settings.sections.dock.label',
|
||||
descriptionKey: 'settings.sections.dock.description',
|
||||
content: <DockSettings />,
|
||||
},
|
||||
];
|
||||
@@ -59,7 +65,7 @@ const sections: SettingsSection[] = [
|
||||
const { Sidebar, Content } = createSettingsPanelComponents({
|
||||
basePath: BASE_PATH,
|
||||
sidebarIcon: User,
|
||||
sidebarLabel: 'Profile',
|
||||
sidebarLabelKey: 'settings.nav.profile',
|
||||
sections,
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user