?view= survives a page load — it never has
Opening or refreshing a URL with `?view=` gave you a bare file browser and a URL
that had quietly rewritten itself to drop the param. Reported as "has never
worked", and it never had.
`useFileViewerPanels` deleted EVERY ephemeral key in a mount effect, filed under
"clear stale ephemeral params". So the page came up, the effect stripped `view`,
and the pane never opened. It arrived incidentally in 9acef6cf (2026-02-23) with
the chat-about-a-file work rather than as a decision about deep links, which is
why nothing recorded the cost.
Checked what actually needs clearing before removing it, rather than assuming
nothing did:
chatContext fills the chat box through `defaultInput` and does NOT auto-send
(`autoSend` defaults false) — restoring it costs a pre-filled
input and no message
view a file that has since gone shows the viewer's error, which as of
today says what happened and offers a download
ephemeral(2) same
ephemeral2Auto STARTS AUDIO PLAYING. Reloading a page should not make sound
come out of the machine. This one is still cleared, and is now
the only reason the effect exists.
Also `replace`, so the cleanup is not a back-button step.
An old-style link carrying both `?path=` and `?view=` still works: the legacy
redirect rebuilds the pathname and keeps the rest of the query, so `view` rides
through and is then read relative to the folder it just landed in.
tsgo clean, frontend builds, 837 pass / 7 fail unchanged.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -25,17 +25,35 @@ export const useFileViewerPanels = (): EphemeralPanels | null => {
|
||||
const [searchParams, setSearchParams] = useSearchParams();
|
||||
const didClean = useRef(false);
|
||||
|
||||
// Clear stale ephemeral params on mount (page refresh)
|
||||
/**
|
||||
* On a fresh load, drop only what must not resume — which is autoplay, and nothing else.
|
||||
*
|
||||
* This used to delete EVERY ephemeral key on mount, under the heading "clear stale params". The effect
|
||||
* of that was that `?view=` could never be linked to or survive a refresh: the page came up, the effect
|
||||
* stripped the param, and you got a bare file browser with a URL that had quietly rewritten itself.
|
||||
* Reported as "has never worked", and it never had — it arrived incidentally in 9acef6cf (2026-02-23)
|
||||
* with the chat-about-a-file work, not as a decision about deep links.
|
||||
*
|
||||
* Nothing else needs clearing. `chatContext` fills the chat box via `defaultInput` and does NOT
|
||||
* auto-send (`autoSend` defaults false), so restoring it costs a pre-filled input and no message. A
|
||||
* `view` or `ephemeral` pointing at a file that has since gone shows the viewer's error, which now says
|
||||
* what actually happened and offers a download.
|
||||
*
|
||||
* `ephemeral2Auto` is the exception and the reason this effect still exists: it starts audio playing.
|
||||
* Reloading a page should not make sound come out of the machine.
|
||||
*/
|
||||
useEffect(() => {
|
||||
if (didClean.current) return;
|
||||
didClean.current = true;
|
||||
if (EPHEMERAL_KEYS.some((k) => searchParams.has(k))) {
|
||||
setSearchParams((prev) => {
|
||||
if (!searchParams.has('ephemeral2Auto')) return;
|
||||
setSearchParams(
|
||||
(prev) => {
|
||||
const next = new URLSearchParams(prev);
|
||||
EPHEMERAL_KEYS.forEach((k) => next.delete(k));
|
||||
next.delete('ephemeral2Auto');
|
||||
return next;
|
||||
});
|
||||
}
|
||||
},
|
||||
{ replace: true },
|
||||
);
|
||||
}, []);
|
||||
|
||||
const viewPath = searchParams.get('view');
|
||||
|
||||
Reference in New Issue
Block a user