real forms across the plugin, so enter submits instead of doing nothing

connection settings, add/move/rename/options dialogs and daemon settings all
put their fields in a div, so the button was the only way to submit and enter
silently did nothing — a keyboard trap wearing a layout. wrapped each in a
<form onSubmit>, made every non-submit button in those forms type="button"
(test port, update blocklist, discard, cancel, remove-file, known-dir
shortcuts), and dropped RenameDialog's manual onKeyDown enter check now that
the form handles it natively. the toolbar's filter box is left alone — it has
no submit action.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-19 10:52:36 +00:00
co-authored by Claude Opus 5
parent b26aefd085
commit 17edfa9403
6 changed files with 76 additions and 65 deletions
+14 -18
View File
@@ -1,4 +1,5 @@
import type { Torrent } from '../shared';
import type { FormEvent } from 'react';
import { useEffect, useState } from 'react';
import { Button } from '@/components/ui/button';
import {
@@ -38,7 +39,8 @@ export const RenameDialog = ({ open, onOpenChange, torrent, path }: RenameDialog
if (open) setName(current);
}, [open, current]);
const submit = async () => {
const submit = async (ev?: FormEvent) => {
ev?.preventDefault();
if (!torrent) return;
await rename.mutateAsync({ id: torrent.id, path, name: name.trim() });
onOpenChange(false);
@@ -52,28 +54,22 @@ export const RenameDialog = ({ open, onOpenChange, torrent, path }: RenameDialog
<DialogDescription className="break-all">{parent ? `${parent}/` : path}</DialogDescription>
</DialogHeader>
<div className="space-y-1.5">
<form onSubmit={submit} className="space-y-1.5">
<Label htmlFor="tr-rename">New name</Label>
<Input
id="tr-rename"
value={name}
onChange={(ev) => setName(ev.target.value)}
onKeyDown={(ev) => ev.key === 'Enter' && name.trim() && void submit()}
autoFocus
/>
<Input id="tr-rename" value={name} onChange={(ev) => setName(ev.target.value)} autoFocus />
<p className="text-xs text-muted-foreground">
This renames the file or folder on disk, not just the display name.
</p>
</div>
<DialogFooter>
<Button variant="ghost" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button onClick={submit} disabled={!name.trim() || name.trim() === current || rename.isPending}>
Rename
</Button>
</DialogFooter>
<DialogFooter>
<Button type="button" variant="ghost" onClick={() => onOpenChange(false)}>
Cancel
</Button>
<Button type="submit" disabled={!name.trim() || name.trim() === current || rename.isPending}>
Rename
</Button>
</DialogFooter>
</form>
</DialogContent>
</Dialog>
);