real forms across the plugin, so enter submits instead of doing nothing

connection settings, add/move/rename/options dialogs and daemon settings all
put their fields in a div, so the button was the only way to submit and enter
silently did nothing — a keyboard trap wearing a layout. wrapped each in a
<form onSubmit>, made every non-submit button in those forms type="button"
(test port, update blocklist, discard, cancel, remove-file, known-dir
shortcuts), and dropped RenameDialog's manual onKeyDown enter check now that
the form handles it natively. the toolbar's filter box is left alone — it has
no submit action.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-19 10:52:36 +00:00
co-authored by Claude Opus 5
parent b26aefd085
commit 17edfa9403
6 changed files with 76 additions and 65 deletions
+14 -13
View File
@@ -1,4 +1,4 @@
import type { ChangeEvent, DragEvent } from 'react';
import type { ChangeEvent, DragEvent, FormEvent } from 'react';
import { useState } from 'react';
import { FileUp, Loader2, X } from 'lucide-react';
import { toast } from 'sonner';
@@ -98,7 +98,8 @@ export const AddTorrentDialog = ({ open, onOpenChange }: AddTorrentDialogProps)
const canSubmit = (files.length > 0 || urlList.length > 0) && !busy;
const submit = async () => {
const submit = async (ev?: FormEvent) => {
ev?.preventDefault();
const common = {
downloadDir: downloadDir.trim() || undefined,
labels: labels
@@ -148,7 +149,7 @@ export const AddTorrentDialog = ({ open, onOpenChange }: AddTorrentDialogProps)
<DialogDescription>Paste magnet links or drop .torrent files.</DialogDescription>
</DialogHeader>
<div className="space-y-4">
<form onSubmit={submit} className="space-y-4">
<div className="space-y-1.5">
<Label htmlFor="tr-add-urls">Magnet links or URLs</Label>
<Textarea
@@ -245,17 +246,17 @@ export const AddTorrentDialog = ({ open, onOpenChange }: AddTorrentDialogProps)
Sequential download
</label>
</div>
</div>
<DialogFooter>
<Button variant="ghost" onClick={close} disabled={busy}>
Cancel
</Button>
<Button onClick={submit} disabled={!canSubmit}>
{busy && <Loader2 className="mr-2 h-4 w-4 animate-spin" />}
Add {files.length + urlList.length || ''}
</Button>
</DialogFooter>
<DialogFooter>
<Button type="button" variant="ghost" onClick={close} disabled={busy}>
Cancel
</Button>
<Button type="submit" disabled={!canSubmit}>
{busy && <Loader2 className="mr-2 h-4 w-4 animate-spin" />}
Add {files.length + urlList.length || ''}
</Button>
</DialogFooter>
</form>
</DialogContent>
</Dialog>
);