Files
proxy-manager/web/HostsPanel.tsx
T
pastilhasandClaude Opus 5 ee8edd3709 the settings form, and the branch that never ran
the plugin could not be configured. /_config had GET, PUT, DELETE and a test
that validates without storing, and nothing rendered any of it — the
connection had to be inserted by hand.

ConnectionPanel is both the wizard and the settings page, one component, the
same choice jellyfin's ConnectionSection makes and for the same reason: a
connection edited months later goes through exactly the path that stored the
first one. HostsPanel shows it when nothing is configured and on ?config=1,
which is in the URL so it survives a refresh. test comes before save and
stores nothing, so a wrong password cannot replace a working one. the secret
field starts empty even when one is stored, and empty means keep — that is
what lets a typo in the URL be fixed without going to find the password.

and while wiring the unconfigured case, it turned out that case never fired.

both panels read `(error as { body?: Failure }).body` to decide whether a
failure was unconfigured, unauthenticated or unreachable. useClient throws
ApiError(status, message) and has no `.body` at all, so that was always
undefined: every failure fell through to the generic message, and the careful
explanation of NPM's 404-means-credential quirk was written, shipped and
unreachable. asFailure now reads the STATUS, which the router already chooses
deliberately — 409 nothing stored, 503 no answer, 502 answered and refused.

owner-only is explained rather than reported. a member hitting 403 here reads
why: it is an admin login and NPM has no read-only role.

still not installed, still no db:push.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
2026-08-25 16:51:31 +00:00

241 lines
9.5 KiB
TypeScript

import { useCallback, useEffect, useRef, useState } from "react";
import { AlertTriangle, Globe, Lock, LockOpen, Power, RefreshCw, Settings, ShieldCheck, Users } from "lucide-react";
import { useClient } from "hooks/useClient";
import { useSearchParams } from "react-router";
import { ConnectionPanel } from "./ConnectionPanel";
/**
* The proxy hosts, which is the thing anybody opens this plugin to see.
*
* Selection lives in the URL (`?host=<id>`), not in a channel — `docs/navigation-audit.md` is the
* authority and this is the case it names: the detail panel reads the same parameter rather than being
* handed the id through a bus.
*/
type ProxyHost = {
id: number;
domain_names: string[];
forward_scheme: string;
forward_host: string;
forward_port: number;
enabled: number;
ssl_forced: number;
certificate_id: number;
access_list_id: number;
meta?: { nginx_online?: boolean; nginx_err?: string | null };
};
type Failure = { error: string; likelyAuth?: boolean; unreachable?: boolean; unconfigured?: boolean };
/**
* Turn a thrown `ApiError` into the shape this panel branches on.
*
* **This reads the STATUS, not the body, and that is not a shortcut.** `useClient` throws
* `ApiError(status, message)` — there is no `.body` on it, and there never was. This panel used to read
* `(error as { body?: Failure }).body`, which is always `undefined`, so `unconfigured` and `likelyAuth`
* were never once true and every failure fell through to the generic message. The careful explanation of
* NPM's 404 quirk was written, shipped, and unreachable.
*
* `api/router.ts` already encodes the distinction in the status it chooses, so it survives the trip:
* 409 is "no connection stored", 503 is "NPM did not answer", 502 is "NPM answered and refused". The
* message carries the detail, including the sentence about a 404 really meaning the credential.
*/
const asFailure = (error: unknown): Failure => {
const status = (error as { status?: number })?.status;
const message = error instanceof Error ? error.message : "Could not load hosts.";
return {
error: message,
unconfigured: status === 409,
unreachable: status === 503,
likelyAuth: status === 502,
};
};
export const HostsPanel = () => {
const client = useClient();
// useClient() rebuilds its verbs every render, so it must not sit in a dependency list.
const clientRef = useRef(client);
clientRef.current = client;
const [hosts, setHosts] = useState<ProxyHost[] | null>(null);
const [failure, setFailure] = useState<Failure | null>(null);
const [busy, setBusy] = useState<number | null>(null);
const [params, setParams] = useSearchParams();
const selected = params.get("host");
// `?config=1` is the settings page; an unconfigured plugin shows it whether or not it was asked for.
// In the URL rather than in state, so it survives a refresh and can be linked to — `docs/navigation-audit.md`.
const configuring = params.get("config") === "1";
const load = useCallback(async () => {
try {
setHosts(await clientRef.current.get<ProxyHost[]>("/proxy-manager/hosts"));
setFailure(null);
} catch (error) {
setFailure(asFailure(error));
setHosts(null);
}
}, []);
useEffect(() => {
void load();
}, [load]);
const toggle = async (host: ProxyHost) => {
setBusy(host.id);
try {
await clientRef.current.post(`/proxy-manager/hosts/${host.id}/${host.enabled ? "disable" : "enable"}`, {});
await load();
} catch {
setFailure({ error: `Could not ${host.enabled ? "disable" : "enable"} that host.` });
} finally {
setBusy(null);
}
};
// Order matters: an explicit `?config=1` wins over everything, then "there is nothing to connect to"
// wins over the generic failure screen. Otherwise the first thing a new install shows is an error.
if (configuring || failure?.unconfigured) return <ConnectionPanel />;
if (failure) return <Failed failure={failure} onRetry={() => void load()} />;
if (!hosts) return <Centred>Loading hosts…</Centred>;
return (
<div className="flex size-full flex-col">
<header className="flex items-center justify-between border-b px-3 py-2">
<span className="text-sm font-medium">
{hosts.length} host{hosts.length === 1 ? "" : "s"}
</span>
<span className="flex items-center gap-2">
<button type="button" onClick={() => void load()} className="text-muted-foreground hover:text-foreground">
<RefreshCw className="size-4" />
</button>
{/* Not a Link: this panel lives inside a workspace and the target is a parameter on the page it
is already on. A button that sets the parameter is the same navigation without a full route. */}
<button
type="button"
title="Connection settings"
onClick={() => setParams((p) => { p.set("config", "1"); return p; })}
className="text-muted-foreground hover:text-foreground"
>
<Settings className="size-4" />
</button>
</span>
</header>
{hosts.length === 0 ? (
<Centred>Nginx Proxy Manager has no proxy hosts.</Centred>
) : null}
<ul className="flex-1 overflow-auto">
{hosts.map((host) => {
const offline = host.meta?.nginx_online === false;
return (
<li key={host.id}>
<button
type="button"
onClick={() => setParams((p) => { p.set("host", String(host.id)); return p; }, { replace: true })}
className={`flex w-full items-center gap-2 border-b px-3 py-2 text-left hover:bg-muted/50 ${
selected === String(host.id) ? "bg-muted" : ""
} ${host.enabled ? "" : "opacity-50"}`}
>
<Globe className="size-4 shrink-0 text-muted-foreground" />
<span className="min-w-0 flex-1">
<span className="block truncate text-sm">{host.domain_names.join(", ")}</span>
<span className="block truncate text-xs text-muted-foreground">
→ {host.forward_scheme}://{host.forward_host}:{host.forward_port}
</span>
</span>
{/* Certificate state, not certificate identity — "is it https" is the question here. */}
{host.certificate_id ? (
<Lock className={`size-3.5 shrink-0 ${host.ssl_forced ? "text-emerald-500" : "text-muted-foreground"}`} />
) : (
<LockOpen className="size-3.5 shrink-0 text-amber-500" />
)}
{host.access_list_id ? <Users className="size-3.5 shrink-0 text-sky-500" /> : null}
{offline ? <AlertTriangle className="size-3.5 shrink-0 text-destructive" /> : null}
</button>
</li>
);
})}
</ul>
{selected ? (
<footer className="border-t p-2">
<ToggleButton
hosts={hosts}
selected={selected}
busy={busy}
onToggle={(host) => void toggle(host)}
/>
</footer>
) : null}
</div>
);
};
const ToggleButton = ({
hosts,
selected,
busy,
onToggle,
}: {
hosts: ProxyHost[];
selected: string;
busy: number | null;
onToggle: (host: ProxyHost) => void;
}) => {
const host = hosts.find((h) => String(h.id) === selected);
if (!host) return null;
return (
<button
type="button"
disabled={busy === host.id}
onClick={() => onToggle(host)}
className="flex w-full items-center justify-center gap-2 rounded-md border px-3 py-1.5 text-sm hover:bg-muted disabled:opacity-50"
>
<Power className="size-4" />
{busy === host.id ? "Working…" : host.enabled ? "Take out of service" : "Put back in service"}
</button>
);
};
/**
* NPM answers 404 when unauthenticated, so a naive client shows "not found" for a wrong password. The
* server marks that case `likelyAuth`; this turns it into a sentence that points somewhere useful.
*/
const Failed = ({ failure, onRetry }: { failure: Failure; onRetry: () => void }) => (
<div className="flex size-full flex-col items-center justify-center gap-3 p-6 text-center">
<ShieldCheck className="size-8 text-muted-foreground" />
{failure.unconfigured ? (
<>
<p className="text-sm text-muted-foreground">No Nginx Proxy Manager connection is set.</p>
<p className="max-w-xs text-xs text-muted-foreground">The owner sets it in this plugin's settings.</p>
</>
) : failure.likelyAuth ? (
<>
<p className="text-sm text-muted-foreground">Nginx Proxy Manager refused the credential.</p>
<p className="max-w-xs text-xs text-muted-foreground">
Its API answers 404 when unauthenticated, so this is almost always a wrong identity or secret rather than a
missing endpoint.
</p>
</>
) : failure.unreachable ? (
<>
<p className="text-sm text-muted-foreground">Nginx Proxy Manager is not answering.</p>
<p className="max-w-xs text-xs text-muted-foreground">{failure.error}</p>
</>
) : (
<p className="max-w-xs text-sm text-muted-foreground">{failure.error}</p>
)}
<button type="button" onClick={onRetry} className="flex items-center gap-1 text-xs hover:text-foreground">
<RefreshCw className="size-3" /> try again
</button>
</div>
);
const Centred = ({ children }: { children: React.ReactNode }) => (
<div className="flex size-full items-center justify-center p-6 text-sm text-muted-foreground">{children}</div>
);