give each member their own immich account and key

Photos had no user provisioning at all: one registry row, the owner's, and
every other account resolving to nothing. Same shape as the Jellyfin gap, but
this one was never built rather than built and dropped.

photos_accounts records who on Officer is who on Immich, and carries that
person's own API key. getConfig falls back to it when the caller has no
registry of their own, and there is no path from there to the owner's key —
an Immich key with permissions:['all'] can read and delete the whole library,
so a member resolving to it would be administering everyone's photographs
rather than reading their own.

Matching is on email, which Immich enforces uniqueness on and Officer already
holds. That is exact where the Jellyfin side has to go through an uppercased
username index and cope with two Officer names colliding into one.

Two deliberate differences from the Jellyfin flow:

The admin's own account is reported as itself, not as "no Officer account".
That bug shipped there and was fixed in 591c0da; there was no reason to write
it twice, so reconcile takes the key's identity from /api/users/me and the
test pins it.

And the temporary password is HANDED OVER rather than discarded. Jellyfin
discards because it has no must-change-password flag, so anything handed over
stays valid forever. Immich has one, and Immich's own app is where phone
backup runs — discarding would leave a photo account that can never back a
phone up again. So: set a password, spend it on a key, raise
shouldChangePassword, return it once. POST /_config/:id/handover re-issues on
demand, because "setting up my phone" happens long after provisioning and more
than once. Verified against the running 3.1.0 image that an API key survives a
password change, so re-issuing never costs Officer its access.

Applied on alpha: conceiba and fedra linked, guipinto and diogo created, all
four keyed and each resolving to their own Immich identity. jrg.conceicao left
alone. Members still need the photos grant on the Member role before the
permission gate lets them through.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-21 15:46:13 +00:00
co-authored by Claude Fable 5
parent 0b9e4f32db
commit a83da42a1f
11 changed files with 977 additions and 7 deletions
+10
View File
@@ -4,6 +4,7 @@ import { handleConfigRoute, noteProbe, probe } from './config';
import { handleLockedRoute } from './locked';
import { handleOfficerRoute } from './routes';
import { getConfig } from './upstream';
import { setProvisionableUsers } from './user-list';
import { API_URL } from '@@/officer-url.mjs';
// The officer-photos sidecar. Owns the whole Immich contract for Officer: the instance URL and the API key.
@@ -27,6 +28,9 @@ import { API_URL } from '@@/officer-url.mjs';
// key and is never stored. Validated against the instance, then stored encrypted
// PATCH /_config/:id same fields, all optional — no credential keeps the stored key
// POST /_config/:id/activate switch to that account
// POST /_config/:id/provision create/link an Immich account per Officer user and mint each their own
// key. Replies with a one-time password per person for THEIR Immich app —
// returned here and nowhere else, never logged, never stored
// DEL /_config/:id remove it; the newest survivor is promoted if it was the active one
// * /_officer/<path> forwarded to <active url>/api/<path>, first-segment allow-list (routes.ts)
//
@@ -146,6 +150,12 @@ function handleCommand(cmd: SidecarCommand, reply: ReplyFn) {
case 'ping':
reply({ type: 'pong', id: cmd.id });
break;
// The platform's account list, pushed because this plugin's manifest declares `userProvisioning`.
// Arrives on registration and again on every account create or delete. No reply — it is a statement,
// not a question.
case 'users:list':
setProvisionableUsers(cmd.users);
break;
default:
reply({
type: 'error',