pastilhasandClaude Opus 5
373d67e0a0
The extraction landed months ago and the platform side is clean. What was left was inside the plugin, and it was the half that shows. ── Names a user actually reads ── The three registered panels were still called "Headscale servers", "Headscale" and "Headscale" in the panel picker, and the server picker rendered "Headscale" as its own heading. Those name OUR panels, not the upstream server, so they were simply missed. Deliberately NOT a find-and-replace. Most of the ~175 "headscale" strings in here are correct — "no active Headscale server", "headscale timed out", "is this a Headscale server?" all refer to the thing this plugin drives, and renaming them would make the errors lie. What was fixed is the plugin's own identity, plus nine stale `/headscale` route paths that are wrong rather than merely old (the route is `/offscale`) and one reference to `queries/headscale.ts`, a file the extraction deleted. The console's pty session key moves from `headscale-console-<id>` to `offscale-console-<id>`. That one has a real cost: a console open at the moment of the change keeps running in the sidecar under the old key with nothing pointing at it, until that sidecar restarts. Paid once, deliberately, rather than carrying the pre-extraction name in persisted state forever. ── The manifest was missing a dependency it has always had ── `sidecar/ssh.ts` spawns `ssh`, and so does the reachability probe. The manifest said "Offscale needed nothing", so install checked for nothing and a host without an ssh client failed at RUNTIME with a spawn error — precisely the failure `osDependencies` exists to turn into a refusal at install time. PLUGIN.md listed ssh as a host dependency all along; the manifest was the file that was wrong. Missed because ssh is on effectively every Linux box, which is also why declaring it costs nothing there and is the whole difference where it is absent. ── Documentation that said the opposite of the code ── PLUGIN.md instructed the reader to carry `assist.ts` in "but do not wire it up", as a marker. It has been wired for some time: `policy.ts` routes `POST /_officer/policy/assist`, `PolicyView.tsx` renders `<PolicyAssistant />`, and the manifest declares the route in `readOnlyWrites`. Corrected rather than deleted, because that instruction is exactly the kind someone would follow — a person tidying "unused" code would have found it wired and assumed the document knew something they did not. Present-tense identifiers corrected to the shipped names; the "before" columns of the migration tables still say headscale, because that is what they record. A note at the top says which is which. tsgo clean, 21 plugin tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
76 lines
3.0 KiB
TypeScript
76 lines
3.0 KiB
TypeScript
import type { LucideIcon } from 'lucide-react';
|
|
import { NavLink } from 'react-router';
|
|
import { Server, Laptop, Users, KeyRound, Smartphone, ShieldCheck, Activity, TerminalSquare } from 'lucide-react';
|
|
import { OFFSCALE_SECTIONS, offscaleSectionPath, type OffscaleSectionId } from './shared';
|
|
import { useOffscaleServers } from './useOffscaleServers';
|
|
|
|
// Lower-left panel of the /offscale workspace: the section list. Which server it all acts on is the panel
|
|
// above (OffscaleServerPicker) — that one mutates, this one navigates, which is why they are separate.
|
|
//
|
|
// Sections are real links to /offscale/<section>, not channel writes — so they cmd-click into a new tab,
|
|
// survive a reload, and answer the back button. Active state comes from react-router's NavLink rather than
|
|
// being derived in JS, per the navigation audit's Phase 4.
|
|
|
|
const ICONS: Record<OffscaleSectionId, LucideIcon> = {
|
|
servers: Server,
|
|
nodes: Laptop,
|
|
users: Users,
|
|
keys: KeyRound,
|
|
invites: Smartphone,
|
|
policy: ShieldCheck,
|
|
diagnostics: Activity,
|
|
console: TerminalSquare,
|
|
};
|
|
|
|
const ROW = 'group relative flex items-center gap-3 rounded-lg px-3 py-2 text-left text-sm transition-colors';
|
|
|
|
type SectionBodyProps = { icon: LucideIcon; label: string; selected: boolean };
|
|
|
|
const SectionBody = ({ icon: Icon, label, selected }: SectionBodyProps) => (
|
|
<>
|
|
{selected && <span className="absolute left-0 top-1/2 h-5 w-1 -translate-y-1/2 rounded-r-full bg-primary" />}
|
|
<Icon
|
|
className={`h-4 w-4 shrink-0 ${selected ? 'text-primary' : 'text-muted-foreground group-hover:text-foreground'}`}
|
|
/>
|
|
{label}
|
|
</>
|
|
);
|
|
|
|
export const OffscaleNav = () => {
|
|
const { active } = useOffscaleServers();
|
|
|
|
return (
|
|
<div className="flex h-full flex-col overflow-y-auto bg-muted/30">
|
|
<nav className="flex flex-col gap-0.5 px-2 py-3">
|
|
{OFFSCALE_SECTIONS.map(({ id, label }) => {
|
|
// Without an active server the domain sections have nothing to act on, so they are rendered as
|
|
// plain text rather than as anchors — a disabled <a> is not a thing, and a link that goes nowhere
|
|
// useful is worse than no link.
|
|
if (id !== 'servers' && !active) {
|
|
return (
|
|
<span key={id} title="Select a server first" className={`${ROW} cursor-default opacity-40`}>
|
|
<SectionBody icon={ICONS[id]} label={label} selected={false} />
|
|
</span>
|
|
);
|
|
}
|
|
return (
|
|
<NavLink
|
|
key={id}
|
|
to={offscaleSectionPath(id)}
|
|
className={({ isActive }) =>
|
|
`${ROW} ${
|
|
isActive
|
|
? 'bg-primary/10 font-medium text-primary'
|
|
: 'text-muted-foreground hover:bg-muted hover:text-foreground'
|
|
}`
|
|
}
|
|
>
|
|
{({ isActive }) => <SectionBody icon={ICONS[id]} label={label} selected={isActive} />}
|
|
</NavLink>
|
|
);
|
|
})}
|
|
</nav>
|
|
</div>
|
|
);
|
|
};
|