pastilhasandClaude Opus 5
373d67e0a0
The extraction landed months ago and the platform side is clean. What was left was inside the plugin, and it was the half that shows. ── Names a user actually reads ── The three registered panels were still called "Headscale servers", "Headscale" and "Headscale" in the panel picker, and the server picker rendered "Headscale" as its own heading. Those name OUR panels, not the upstream server, so they were simply missed. Deliberately NOT a find-and-replace. Most of the ~175 "headscale" strings in here are correct — "no active Headscale server", "headscale timed out", "is this a Headscale server?" all refer to the thing this plugin drives, and renaming them would make the errors lie. What was fixed is the plugin's own identity, plus nine stale `/headscale` route paths that are wrong rather than merely old (the route is `/offscale`) and one reference to `queries/headscale.ts`, a file the extraction deleted. The console's pty session key moves from `headscale-console-<id>` to `offscale-console-<id>`. That one has a real cost: a console open at the moment of the change keeps running in the sidecar under the old key with nothing pointing at it, until that sidecar restarts. Paid once, deliberately, rather than carrying the pre-extraction name in persisted state forever. ── The manifest was missing a dependency it has always had ── `sidecar/ssh.ts` spawns `ssh`, and so does the reachability probe. The manifest said "Offscale needed nothing", so install checked for nothing and a host without an ssh client failed at RUNTIME with a spawn error — precisely the failure `osDependencies` exists to turn into a refusal at install time. PLUGIN.md listed ssh as a host dependency all along; the manifest was the file that was wrong. Missed because ssh is on effectively every Linux box, which is also why declaring it costs nothing there and is the whole difference where it is absent. ── Documentation that said the opposite of the code ── PLUGIN.md instructed the reader to carry `assist.ts` in "but do not wire it up", as a marker. It has been wired for some time: `policy.ts` routes `POST /_officer/policy/assist`, `PolicyView.tsx` renders `<PolicyAssistant />`, and the manifest declares the route in `readOnlyWrites`. Corrected rather than deleted, because that instruction is exactly the kind someone would follow — a person tidying "unused" code would have found it wired and assumed the document knew something they did not. Present-tense identifiers corrected to the shipped names; the "before" columns of the migration tables still say headscale, because that is what they record. A note at the top says which is which. tsgo clean, 21 plugin tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
61 lines
2.7 KiB
TypeScript
61 lines
2.7 KiB
TypeScript
import { Check, Network, Plus } from 'lucide-react';
|
|
import { Link } from 'react-router';
|
|
import { offscaleSectionPath } from './shared';
|
|
import { useOffscaleServers } from './useOffscaleServers';
|
|
|
|
// Top-left panel of the /offscale workspace: which server everything else acts on.
|
|
//
|
|
// It is its own panel rather than a block inside OffscaleNav because the two answer different questions —
|
|
// "which server" and "which section" — and only one of them is navigation. Activating a server is a mutation
|
|
// (a DB write that re-scopes every other query), so these stay buttons with no URL of their own, while the
|
|
// section list below is real links.
|
|
//
|
|
// Every registered server is listed, including when there is only one: the panel's whole job is to say what
|
|
// the rest of the screen is talking to, and a picker that hides itself at one server makes that invisible.
|
|
|
|
export const OffscaleServerPicker = () => {
|
|
const { servers, active, activate, isLoading } = useOffscaleServers();
|
|
|
|
return (
|
|
<div className="flex h-full flex-col overflow-y-auto bg-muted/30">
|
|
<div className="flex items-center gap-3 px-4 py-4">
|
|
<div className="flex h-9 w-9 items-center justify-center rounded-xl bg-indigo-500/15 text-indigo-400 ring-1 ring-black/5">
|
|
<Network className="h-5 w-5" />
|
|
</div>
|
|
<div className="min-w-0">
|
|
<div className="truncate text-sm font-semibold leading-tight">Offscale</div>
|
|
<div className="truncate text-xs text-muted-foreground">{active ? active.name : 'no server'}</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div className="flex flex-col gap-0.5 px-2 pb-3">
|
|
{servers.map((server) => (
|
|
<button
|
|
key={server.id}
|
|
type="button"
|
|
onClick={() => !server.isActive && activate.mutate(server.id)}
|
|
disabled={activate.isPending}
|
|
title={server.url}
|
|
className={`flex items-center gap-2 rounded-lg px-3 py-1.5 text-left text-xs transition-colors ${
|
|
server.isActive ? 'bg-muted font-medium text-foreground' : 'text-muted-foreground hover:bg-muted'
|
|
}`}
|
|
>
|
|
<Check className={`h-3.5 w-3.5 shrink-0 ${server.isActive ? 'text-primary' : 'opacity-0'}`} />
|
|
<span className="min-w-0 flex-1 truncate">{server.name}</span>
|
|
</button>
|
|
))}
|
|
|
|
{servers.length === 0 && !isLoading && (
|
|
<Link
|
|
to={offscaleSectionPath('servers')}
|
|
className="flex items-center gap-2 rounded-lg px-3 py-1.5 text-xs text-muted-foreground transition-colors hover:bg-muted hover:text-foreground"
|
|
>
|
|
<Plus className="h-3.5 w-3.5 shrink-0" />
|
|
Register a server
|
|
</Link>
|
|
)}
|
|
</div>
|
|
</div>
|
|
);
|
|
};
|