pastilhasandClaude Opus 5
25c8502c4b
three small things, one of which turned out to be a bug in what shipped an hour ago. CREATE. a POST to /_officer/event, and the SIDECAR builds the file — the browser sends title, when and where. a UID, a DTSTAMP and a UTC timestamp each have exactly one correct form, and that belongs next to the parser that reads them back, not in a react component. it writes the minimum a VEVENT can legally be: no recurrence, no alarms, no attendees. this app cannot show those, and a field the list cannot display is a field that silently disappears on the next edit. times go in as UTC. the alternative is DTSTART;TZID plus a VTIMEZONE block defining that zone's rules, and a subtly wrong VTIMEZONE moves an event by an hour twice a year. UTC needs no definition and every client renders it local. all-day is the other trap: RFC 5545 makes DTEND EXCLUSIVE, so a one-day event on the 29th ends on the 30th — write the 29th and some clients draw nothing at all. the form takes the last day a person means and the builder adds the day. NEWEST DAY ON TOP. a calendar accumulates years, so ascending opened on whatever was imported first and this week was a scroll away. within a day the order stays chronological, because that is what a day is. ?collection=ra-guide, NOT ?collection=%2Fdav%2F1%2Fra-guide%2F. the path is /dav/<userId>/<name>/, so the escaped form spent six characters on slashes to say `ra-guide` and put the owner's user id in a URL people paste at each other. the name is unique within a user, which is all a selector needs, and the full path is recovered from the collections list the screen already loaded. a full path in the param still resolves, because somebody's bookmark has one. AND THE BUG. setProperty replaced a property's first line and left its continuation lines behind. a value over 75 octets is FOLDED onto lines starting with a space — so editing a long summary left the old tail folded onto the new value, and each edit inherited the last one's ending. it only bites on long values, which is why the first round of testing missed it. the fix consumes the whole folded run and folds what it writes; both are now under test, including the accent-near-the-boundary case that a naive slice(0,75) cuts in half. verified live: both event shapes written and read back, escaping round-tripped, and a long summary edited twice with no accumulation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
80 lines
3.5 KiB
TypeScript
80 lines
3.5 KiB
TypeScript
import { describe, expect, test } from 'bun:test';
|
|
import { buildEvent, fold, parseEvents } from './ical';
|
|
|
|
// The two rules here are the ones that are invisible when broken: DTEND is exclusive for an all-day
|
|
// event, and a content line is folded at 75 OCTETS. Both produce a file that looks fine and renders
|
|
// wrong somewhere else.
|
|
|
|
describe('buildEvent', () => {
|
|
test('a timed event is written in UTC, with both ends', () => {
|
|
const ics = buildEvent('u1', {
|
|
summary: 'Lunch',
|
|
start: '2026-08-28T13:00:00.000Z',
|
|
end: '2026-08-28T14:00:00.000Z',
|
|
allDay: false,
|
|
});
|
|
expect(ics).toContain('DTSTART:20260828T130000Z');
|
|
expect(ics).toContain('DTEND:20260828T140000Z');
|
|
expect(ics.endsWith('END:VCALENDAR\r\n')).toBe(true);
|
|
});
|
|
|
|
test('no end means an hour', () => {
|
|
const ics = buildEvent('u1', { summary: 'Lunch', start: '2026-08-28T13:00:00.000Z', allDay: false });
|
|
expect(ics).toContain('DTEND:20260828T140000Z');
|
|
});
|
|
|
|
test('an all-day event ends the NEXT day, because DTEND is exclusive', () => {
|
|
const ics = buildEvent('u1', { summary: 'Holiday', start: '2026-08-29', allDay: true });
|
|
expect(ics).toContain('DTSTART;VALUE=DATE:20260829');
|
|
expect(ics).toContain('DTEND;VALUE=DATE:20260830');
|
|
});
|
|
|
|
test('a multi-day all-day event takes the last day inclusive', () => {
|
|
const ics = buildEvent('u1', { summary: 'Trip', start: '2026-08-29', end: '2026-08-31', allDay: true });
|
|
expect(ics).toContain('DTEND;VALUE=DATE:20260901');
|
|
});
|
|
|
|
test('a month boundary rolls the month, not just the day', () => {
|
|
const ics = buildEvent('u1', { summary: 'Last of the month', start: '2026-08-31', allDay: true });
|
|
expect(ics).toContain('DTEND;VALUE=DATE:20260901');
|
|
});
|
|
|
|
test('TEXT separators are escaped, and survive the parser', () => {
|
|
const summary = 'Comma, semicolon; and a backslash \\ walk in';
|
|
const ics = buildEvent('u1', { summary, start: '2026-08-28T13:00:00.000Z', allDay: false });
|
|
expect(ics).toContain(String.raw`SUMMARY:Comma\, semicolon\; and a backslash \\ walk in`);
|
|
expect(parseEvents(ics)[0]!.summary).toBe(summary);
|
|
});
|
|
|
|
test('a long summary folds, and the parser reads it back whole', () => {
|
|
const summary = 'x'.repeat(200);
|
|
const ics = buildEvent('u1', { summary, start: '2026-08-28T13:00:00.000Z', allDay: false });
|
|
expect(ics.split('\r\n').every((l) => Buffer.byteLength(l, 'utf8') <= 75)).toBe(true);
|
|
expect(parseEvents(ics)[0]!.summary).toBe(summary);
|
|
});
|
|
});
|
|
|
|
describe('fold', () => {
|
|
test('a short line is left alone', () => {
|
|
expect(fold('SUMMARY:short')).toBe('SUMMARY:short');
|
|
});
|
|
|
|
test('every produced line fits in 75 octets, continuations included', () => {
|
|
const folded = fold(`SUMMARY:${'a'.repeat(400)}`);
|
|
expect(folded.split('\r\n').every((l) => Buffer.byteLength(l, 'utf8') <= 75)).toBe(true);
|
|
});
|
|
|
|
test('continuation lines start with exactly one space', () => {
|
|
const [, ...rest] = fold(`SUMMARY:${'a'.repeat(200)}`).split('\r\n');
|
|
expect(rest.every((l) => l.startsWith(' ') && !l.startsWith(' a'))).toBe(true);
|
|
});
|
|
|
|
test('a multi-byte character is never cut in half', () => {
|
|
// 'é' is two octets, so a boundary lands mid-character unless the fold counts encoded length.
|
|
const folded = fold(`SUMMARY:${'é'.repeat(100)}`);
|
|
expect(folded).not.toContain('�');
|
|
expect(folded.split('\r\n').every((l) => Buffer.byteLength(l, 'utf8') <= 75)).toBe(true);
|
|
expect(folded.split('\r\n').map((l, i) => (i ? l.slice(1) : l.slice(8))).join('')).toBe('é'.repeat(100));
|
|
});
|
|
});
|