Files
caldav/web/dav/useDavData.ts
T
pastilhasandClaude Opus 5 25c8502c4b create an event, newest day first, and a URL you can read
three small things, one of which turned out to be a bug in what shipped an hour
ago.

CREATE. a POST to /_officer/event, and the SIDECAR builds the file — the browser
sends title, when and where. a UID, a DTSTAMP and a UTC timestamp each have
exactly one correct form, and that belongs next to the parser that reads them
back, not in a react component. it writes the minimum a VEVENT can legally be:
no recurrence, no alarms, no attendees. this app cannot show those, and a field
the list cannot display is a field that silently disappears on the next edit.

times go in as UTC. the alternative is DTSTART;TZID plus a VTIMEZONE block
defining that zone's rules, and a subtly wrong VTIMEZONE moves an event by an
hour twice a year. UTC needs no definition and every client renders it local.
all-day is the other trap: RFC 5545 makes DTEND EXCLUSIVE, so a one-day event on
the 29th ends on the 30th — write the 29th and some clients draw nothing at all.
the form takes the last day a person means and the builder adds the day.

NEWEST DAY ON TOP. a calendar accumulates years, so ascending opened on whatever
was imported first and this week was a scroll away. within a day the order stays
chronological, because that is what a day is.

?collection=ra-guide, NOT ?collection=%2Fdav%2F1%2Fra-guide%2F. the path is
/dav/<userId>/<name>/, so the escaped form spent six characters on slashes to
say `ra-guide` and put the owner's user id in a URL people paste at each other.
the name is unique within a user, which is all a selector needs, and the full
path is recovered from the collections list the screen already loaded. a full
path in the param still resolves, because somebody's bookmark has one.

AND THE BUG. setProperty replaced a property's first line and left its
continuation lines behind. a value over 75 octets is FOLDED onto lines starting
with a space — so editing a long summary left the old tail folded onto the new
value, and each edit inherited the last one's ending. it only bites on long
values, which is why the first round of testing missed it. the fix consumes the
whole folded run and folds what it writes; both are now under test, including
the accent-near-the-boundary case that a naive slice(0,75) cuts in half.

verified live: both event shapes written and read back, escaping round-tripped,
and a long summary edited twice with no accumulation.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
2026-08-27 10:40:10 +00:00

91 lines
3.5 KiB
TypeScript

import type { CalendarEvent, DavCollection, DavContact } from './shared';
import { useQuery } from '@tanstack/react-query';
import { useSearchParams } from 'react-router';
import { useClient } from 'hooks/useClient';
import { COLLECTION_PARAM } from './shared';
// Data layer for /calendar and /contacts. Everything goes through the /api/caldav auth proxy to the
// officer-caldav sidecar, which holds the Radicale process and every DAV credential; officer forwards the
// authenticated user's id and nothing else.
//
// There is no push channel — Radicale is a plain DAV server — so these are ordinary queries with a
// generous staleTime rather than a poll. A calendar changes when someone edits it, not on a timer.
const STALE_MS = 30_000;
const EMPTY_COLLECTIONS: DavCollection[] = [];
const EMPTY_EVENTS: CalendarEvent[] = [];
const EMPTY_CONTACTS: DavContact[] = [];
export function useDavCollections(kind?: DavCollection['kind']) {
const { get } = useClient();
const query = useQuery({
queryKey: ['caldav', 'collections'],
queryFn: () => get<{ collections: DavCollection[] }>('/caldav/_officer/collections'),
staleTime: STALE_MS,
});
const all = query.data?.collections ?? EMPTY_COLLECTIONS;
return {
collections: kind ? all.filter((c) => c.kind === kind) : all,
isLoading: query.isLoading,
error: query.error,
};
}
export function useCalendarEvents(collection: string | null) {
const { get } = useClient();
const query = useQuery({
queryKey: ['caldav', 'events', collection],
queryFn: () =>
get<{ events: CalendarEvent[] }>(`/caldav/_officer/events?collection=${encodeURIComponent(collection ?? '')}`),
enabled: Boolean(collection),
staleTime: STALE_MS,
});
return { events: query.data?.events ?? EMPTY_EVENTS, isLoading: query.isLoading, error: query.error };
}
export function useDavContacts(collection: string | null) {
const { get } = useClient();
const query = useQuery({
queryKey: ['caldav', 'contacts', collection],
queryFn: () =>
get<{ contacts: DavContact[] }>(`/caldav/_officer/contacts?collection=${encodeURIComponent(collection ?? '')}`),
enabled: Boolean(collection),
staleTime: STALE_MS,
});
return { contacts: query.data?.contacts ?? EMPTY_CONTACTS, isLoading: query.isLoading, error: query.error };
}
/**
* Resolve what the URL asked for against what this user has.
*
* The param is the collection NAME. It also accepts a full DAV path, because that is what the URL used
* to carry and somebody's bookmark still has one — a one-line fallback against a link that would
* otherwise silently land on the wrong calendar.
*
* No match falls back to the first collection rather than to nothing, so a stale or mistyped link shows
* a calendar instead of an empty screen.
*/
export function matchCollection(collections: DavCollection[], fromUrl: string | null): DavCollection | null {
if (!fromUrl) return collections[0] ?? null;
return collections.find((c) => c.name === fromUrl || c.path === fromUrl) ?? collections[0] ?? null;
}
/**
* The collection the URL selects, or the first one of that kind once the list arrives. Both panels of a
* screen call this and get the same answer, because the answer is derived from the URL and the query
* cache rather than passed between them.
*/
export function useSelectedCollection(kind: DavCollection['kind']) {
const [params] = useSearchParams();
const { collections, isLoading } = useDavCollections(kind);
const selected = matchCollection(collections, params.get(COLLECTION_PARAM));
return { selected, collections, isLoading };
}