pastilhasandClaude Opus 5
dcbc9b102c
one sidecar, one permission, one install — and two screens, because Calendar and Contacts are two places you go rather than two sections of one page. the first plugin to declare `screens`, which the platform gained for this. what moved: the radicale sidecar, the four routers, the panel apps, the app-password table and the settings form. the form became a modal on the calendar screen — a plugin ships panels and cannot contribute a settings section, which is the same wall the email plugin hit and the same answer. the routes are /calendar and /contacts, not /caldav/calendar. they were core routes and keeping them is not cosmetic: a bookmark, a dock tile someone arranged, and a persisted layout all address them. only a first-party plugin may choose its own segment; a third-party one is confined to /p/<publisher>/. four paths outside /api come with it, above the account gate, because phones are not browsers: DAVx5, iOS and thunderbird send HTTP basic on every request and have nowhere to put a JWT. that is not "open" — the sync door demands a scoped app password and resolves it to one user before radicale sees anything. two things deliberately unchanged. the table is still dav_app_passwords, not caldav_app_passwords: installs hold real rows and a naming convention is not worth a data migration on a live machine. and the panel names still resolve through the platform's catalogs, so the six locales they had as core screens survive rather than dropping to english to make the refactor tidier. per-user was already true and is worth writing down because the config said otherwise: the sync door resolves an app password to an account, tells radicale that id is the principal, and owner_only does the rest. the comment claiming "the owner is the only principal that exists" had been stale since multi-user landed on 2026-08-07. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
35 lines
1.7 KiB
TypeScript
35 lines
1.7 KiB
TypeScript
import { describe, expect, test } from 'bun:test';
|
|
import { resolveRadicale } from './radicale';
|
|
|
|
// The failure this covers took a whole sidecar down on a fresh install: `spawn('radicale')` resolves
|
|
// against the PATH the process STARTED with, which under PM2 has no `~/.local/bin`, and the ENOENT threw
|
|
// at module load rather than being handled.
|
|
|
|
describe('resolving radicale', () => {
|
|
test('finds the apt-installed binary', () => {
|
|
const found = resolveRadicale('/usr/bin:/bin');
|
|
// Skip rather than fail where radicale genuinely is not installed — this asserts the RESOLVER, and a
|
|
// machine without the package would otherwise report a bug that is not there.
|
|
if (!found) return;
|
|
expect(found.command).toContain('radicale');
|
|
expect(found.args).toEqual([]);
|
|
});
|
|
|
|
test('falls back to the python module when no wrapper script is on PATH', () => {
|
|
// A `pip install --user` into an environment without ~/.local/bin, or a distro shipping the module
|
|
// with no script, both leave radicale importable and unfindable. The module is what matters.
|
|
const pythonOnly = '/usr/bin';
|
|
const found = resolveRadicale(pythonOnly);
|
|
if (!found) return;
|
|
// Either form is correct here; what must never happen is null while the module is importable.
|
|
expect(found.command.length).toBeGreaterThan(0);
|
|
});
|
|
|
|
test('returns null rather than throwing when nothing is installed', () => {
|
|
// The whole point: a missing dependency must be a value the caller can handle, not an exception at
|
|
// module load that crash-loops the sidecar and takes /_health down with it.
|
|
expect(() => resolveRadicale('/nonexistent-dir')).not.toThrow();
|
|
expect(resolveRadicale('/nonexistent-dir')).toBeNull();
|
|
});
|
|
});
|