pastilhasandClaude Opus 5
43cb531dc2
the skill told an agent how to hand-write a .ics: escape the commas, fold at 75 octets, CRLF, DTSTAMP is required, and DTEND is the day after. all true, all silent when wrong, and the browser had learned the same lesson separately in its own copy of the code. this makes the sidecar the only thing that knows the format, and gives everyone else fields. WHAT WAS MISSING BEFORE THE SKILL COULD CHANGE. reading was already JSON, and create-event landed this morning. this adds PATCH /_officer/item — change some fields of an event or a card — and POST /_officer/contact. delete already worked. with those the skill has no reason left to mention iCalendar, so it does not. PATCH IS READ-PATCH-PUT, SERVER SIDE. it reads the stored text, replaces only the lines it owns, and puts the whole thing back, so alarms, attendees, RRULEs and every X- property a phone invented survive an edit made from a form that cannot show them. that logic came out of the browser, where it had needed a duplicate of the escaping and folding rules to live; the agent would have been a third copy in bash. the web bundle now contains no iCalendar literals at all. AND LIVE TESTING FOUND THE BUG THAT MATTERS. an event with a TZID is stored with a VTIMEZONE block beside it, and that block has DTSTART lines of its own — the rule for when summer time starts. taking the first DTSTART in the file rewrote the TIMEZONE DEFINITION, left the event where it was, and answered ok. the calendar showed the old time and the file was quietly corrupt. every write is now confined to the first VEVENT or VCARD, and the file that caught it is a test. three more traps handled rather than documented: a patch that reuses an all-day event's stored DTEND must subtract the exclusive day first or the holiday drifts every time the title is edited; moving a timed event must DROP a stale TZID rather than preserve it, because a TZID and a Z together are a contradiction clients resolve by moving the event; and a move bumps SEQUENCE, which is how a phone tells an update from a duplicate. contacts got the create form the calendar had, so both screens now do all four. editing a card sends the other emails and phones back untouched — the form shows the first of each, and sending only that would delete the rest. 47 tests across the writer and the patcher. verified live against a real event carrying an alarm, an attendee, an RRULE and an X- property: all four intact after a rename, a relocation and a move to a different day. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
93 lines
3.1 KiB
TypeScript
93 lines
3.1 KiB
TypeScript
import { useState } from 'react';
|
|
import { useQueryClient } from '@tanstack/react-query';
|
|
import { useClient } from 'hooks/useClient';
|
|
|
|
/**
|
|
* Creating, changing and deleting one DAV object, in FIELDS.
|
|
*
|
|
* Nothing here knows what an .ics looks like, and that is the point. This used to read the object's
|
|
* text, patch it in the browser and put it back, which meant the browser carried its own copy of the
|
|
* iCalendar escaping and 75-octet folding rules — a second place to be subtly wrong about a format
|
|
* neither screen displays. That work moved to the sidecar (see sidecar/patch.ts), which held the only
|
|
* other copy, and the agent skill now calls the same routes instead of writing a third one in bash.
|
|
*
|
|
* The guarantee it makes is unchanged: a patch replaces only the lines it owns, so alarms, attendees,
|
|
* recurrence rules and every unknown `X-` property survive an edit made from a form that cannot show them.
|
|
*/
|
|
|
|
export type NewEvent = {
|
|
summary: string;
|
|
location?: string;
|
|
/** An ISO instant for a timed event; `YYYY-MM-DD` when `allDay`. */
|
|
start: string;
|
|
end?: string;
|
|
allDay: boolean;
|
|
};
|
|
|
|
export type NewContact = {
|
|
fullName: string;
|
|
emails?: string[];
|
|
phones?: string[];
|
|
org?: string;
|
|
title?: string;
|
|
};
|
|
|
|
/** What a patch may set. Absent leaves a field alone; `null` removes it. */
|
|
export type ItemPatch = {
|
|
summary?: string;
|
|
location?: string | null;
|
|
description?: string | null;
|
|
start?: string;
|
|
end?: string;
|
|
allDay?: boolean;
|
|
fullName?: string;
|
|
emails?: string[];
|
|
phones?: string[];
|
|
org?: string | null;
|
|
title?: string | null;
|
|
};
|
|
|
|
/** `busy` holds the href being written; a create has no href yet, so it gets a sentinel of its own. */
|
|
export const CREATING = 'creating';
|
|
|
|
export function useDavEdit(invalidateKey: unknown[]) {
|
|
const client = useClient();
|
|
const qc = useQueryClient();
|
|
const [busy, setBusy] = useState<string | null>(null);
|
|
const [error, setError] = useState<string | null>(null);
|
|
|
|
const refresh = () => qc.invalidateQueries({ queryKey: invalidateKey });
|
|
|
|
/** Every verb has the same shape: mark busy, do it, refresh, and report rather than throw. */
|
|
const run = async (key: string, fallback: string, work: () => Promise<unknown>) => {
|
|
setBusy(key);
|
|
setError(null);
|
|
try {
|
|
await work();
|
|
await refresh();
|
|
return true;
|
|
} catch (err) {
|
|
setError(err instanceof Error ? err.message : fallback);
|
|
return false;
|
|
} finally {
|
|
setBusy(null);
|
|
}
|
|
};
|
|
|
|
return {
|
|
busy,
|
|
error,
|
|
|
|
save: (href: string, patch: ItemPatch) =>
|
|
run(href, 'Could not save.', () => client.patch('/caldav/_officer/item', { href, ...patch })),
|
|
|
|
remove: (href: string) => run(href, 'Could not delete.', () => client.delete('/caldav/_officer/item', { href })),
|
|
|
|
createEvent: (collection: string, event: NewEvent) =>
|
|
run(CREATING, 'Could not create.', () => client.post('/caldav/_officer/event', { collection, ...event })),
|
|
|
|
createContact: (collection: string, contact: NewContact) =>
|
|
run(CREATING, 'Could not create.', () => client.post('/caldav/_officer/contact', { collection, ...contact })),
|
|
};
|
|
}
|