pastilhasandClaude Opus 5
79ff366802
av-club keeps doing exactly what it did — sharp, ffmpeg and ffprobe behind one API, and the invariant that the caller never names a path. What changes is how it is reached and who decides who may reach it. `src/` is `sidecar/`, because that is the name the platform looks for: `sidecar/index.ts` present means "this plugin ships a process", and presence is the declaration for everything structural here. `manifest.ts` at the root is the other half of that rule. api/router.ts is a proxy and nothing else. the platform authenticates, checks the `av-club` permission, and forwards — so the sidecar now accepts a request carrying `X-Officer-User` and no longer demands its own bearer token from callers who came that way. it binds LOOPBACK to make that trustworthy, which is the same boundary caldav's DAV door already relies on. AV_CLUB_TOKEN stays, and still guards anything calling the port directly: fofos/platform is the stated first consumer and is not Officer. THREE THINGS HAD TO GO, and each one broke it in a way worth writing down. package.json and bun.lock: a package.json inside a plugin is a package boundary, so bun stops walking up for the platform's tsconfig and `@@/sidecar/connect` stops resolving. the sidecar died on its first import, fifteen times. npm dependencies go in the manifest instead, where npm-deps.ts intersects them across plugins into one plugins/node_modules — which is also how this surfaced a real conflict: sharp ^0.33.5 (atelier) and ^0.35.3 here do not overlap, since a 0.x caret pins the minor. atelier moved up; it calls one method. tsconfig.json: same failure one layer earlier, shadowing the platform's `@@/*` paths so api/router.ts would not mount. no other plugin has one. no screens, deliberately. this is an API and a body of documentation; its callers are a commander watching a folder, an agent, or curl. a dock tile would advertise a page with nothing on it. verified through /api/av-club with an agent key: a 3000x2000 jpeg uploaded, probed, and resized to a 1200x800 avif — 166 KB to 1 KB — without the caller ever holding av-club's own token. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
31 lines
1.3 KiB
TypeScript
31 lines
1.3 KiB
TypeScript
import { createSidecarProxy } from '@@/sidecar/create-proxy';
|
|
import { mountPrefix } from '@@/plugins/manifest';
|
|
import { manifest } from '../manifest';
|
|
|
|
/**
|
|
* `/api/av-club/*` — authenticate, then forward to the officer-av-club sidecar.
|
|
*
|
|
* No routes of its own and no media knowledge: the whole contract is `../sidecar/index.ts`, and the
|
|
* reasoning behind what it will and will not accept is `../docs/SECURITY.md`.
|
|
*
|
|
* ── The prefix is derived ──
|
|
*
|
|
* `mountPrefix` returns `/av-club` for this first-party publisher. Writing `/api/av-club` literally
|
|
* would be right by coincidence and wrong the moment anybody else publishes this plugin.
|
|
*
|
|
* ── Why the timeout is long ──
|
|
*
|
|
* A 4K transcode is minutes of work, and the sidecar already sets `idleTimeout: 255` because Bun's
|
|
* ten-second default was killing encodes mid-flight. A short timeout on THIS hop would reintroduce the
|
|
* same failure one layer up: the platform hanging up while ffmpeg is still working, which the caller
|
|
* sees as a dead request rather than as a limit. Same reasoning as transcribe, whose whisper runs are
|
|
* long for the same kind of reason.
|
|
*/
|
|
const proxy = createSidecarProxy({
|
|
name: 'av-club',
|
|
prefix: `/api${mountPrefix({ appName: 'av-club', manifest })}`,
|
|
timeoutSeconds: 1800,
|
|
});
|
|
|
|
export const router = proxy.router;
|