refactor(providers): a provider is a vendor and a key, and the table is gone
The dropdown was listing "connections" — a row per adapter + model + key — which made choosing a model an act of configuration, put a key icon and a bin inside a menu item, and showed five accounts nobody had created. A provider is now a vendor Officer curates. Every one is listed, set up or not, because a vendor you have no key for is exactly what you need to see in order to add one. The model is chosen per generation, from that provider's entry in the catalogue, beside it. With the model off the row, all that remained of a "provider" was the key for OpenAI — and Officer already stores keys: one active value per purpose, 0600 inside a 0700 directory, outside the backup tarball, created on first use so nothing needs provisioning. So `atelier_providers` is dropped, along with `generations.provider_id` that pointed into it. `provider` and `model` stay as text on each generation, which were always the historical fact rather than a pointer to configuration. `getSecret`, never `getKey`: this is a foreign credential, and getKey mints a random value for a purpose it cannot find — which for someone else's API key means authenticating with something invented. Resolution follows: a request names a model, and the catalogue says whose it is, rather than a database being asked which stored row served it. A model nobody in the catalogue claims is still accepted — the catalogue is advisory, and a model released today should work before we ship a file that mentions it. Two routes replace five: PUT and DELETE on /providers/:name/key. Deleting a key that came from the environment is refused rather than faked — it belongs to the install, not to this screen.
This commit is contained in:
@@ -55,18 +55,16 @@ export const generations = pgTable('atelier_generations',
|
||||
status: text('status').notNull().default('queued').$type<GenerationStatus>(),
|
||||
|
||||
/**
|
||||
* The adapter and model, as text, denormalised on purpose.
|
||||
* The provider and model, as text, and now the only record of either.
|
||||
*
|
||||
* `providerId` below points at the configured provider, but that row can be renamed, repointed at
|
||||
* another model, or deleted — and none of that may change what an existing image was made with.
|
||||
* The row is a pointer to configuration; these two are the historical fact.
|
||||
* There was a `provider_id` beside these, pointing at a configured provider row. Both the column
|
||||
* and the table it referenced are gone: a provider is a curated vendor plus a key in the secret
|
||||
* store, so there is no row to point at. These two were always the historical fact — what this
|
||||
* image was actually made with, immune to configuration changing afterwards — and they still are.
|
||||
*/
|
||||
provider: text('provider').notNull(),
|
||||
model: text('model').notNull(),
|
||||
|
||||
/** The provider row this came from, when there was one. Null for rows made before providers existed. */
|
||||
providerId: uuid('provider_id'),
|
||||
|
||||
prompt: text('prompt').notNull(),
|
||||
|
||||
/** Whatever else the caller asked for — size, quality, background. Provider-shaped, so opaque here. */
|
||||
|
||||
Reference in New Issue
Block a user