6.9 KiB
6.9 KiB
Jobs Unification — making every task a background job
Goal: every task run (script, pipeline, later agentic) becomes a persisted, background job — created over REST, streamed live over WebSocket, resumable/attachable, visible on desktop and phone, and ending in a push notification. Replaces today's ephemeral script-task WebSocket path.
Context: single user, forever. No multi-tenant concerns — "is anything running?" is a global check.
Favor power-user affordances over guardrails. See memory sole-user-assume-competence.
Current state (baseline)
- Pipeline tasks already are jobs:
pipeline_jobs(Postgres) +pipeline-job-manager(in-memory live registry, viewer attach/replay buffer, 3s progress flush, finalize, restart-reconciliation) +/jobslist (JobsScreen) +/jobs/:iddetail (JobDetail, live-attach or persisted). WS at/api/tasks/pipeline/ws. - Script tasks (convert-video, edit-audio, …) run via
task-executor.tsover/api/tasks/run/ws— ephemeral, zero persistence, dies with the tab. ModalTaskRunnerModal(ScriptRunner branch). - A separate file-backed queue engine exists at
src/servers/queue/(lane-serial, retries, crash-resume) wired only to email sync. NOT reused here — one Postgres jobs model instead.
Decisions (locked)
- Concurrency: idle → single
Run→/jobs/:id. Something running →Queue+ a redRun(force concurrent). Run → start now →/jobs/:id. Queue → appendpending→/jobslist. Backend (global): FIFOpendingqueue; on any finalize with 0 running, promote the oldest pending. Force-Run bypasses the queue. Queue backlog survives restart (promoteNext on startup). - Modal → page: replace
TaskRunnerModalwith a/jobs/newroute. Right-click task action navigates there instead of mounting the modal. One code path, phone-friendly. - Deep-link: query params, not hash —
/jobs/new?task=convert-video&root=home&path=<dir>&entry=<name>. - Phone: already has a file browser, so it can pick a target path and POST a job. No blocker.
inlinetasks stay in the modal. A top-levelinline: trueinTASK.mdmarks quick/interactive tasks that run in the modal (ephemeral) instead of as a job. Default = job. Currently flagged:remove-jelly-meta,analyze-video,clean-playlist-files. So the modal is not retired — it's the inline path; the shared input form serves both the modal and/jobs/new. The flag is plumbed through the parser + task list/detail endpoints (task.inline), so the FileBrowser menu can branch.
Plan
Phase 1 — Unified jobs backend
- 1a. Data model. Add
mode(pipeline|script|agentic, defaultpipeline) +exit_code(int) to the jobs table. Log atDATA_PATH/jobs/<id>.log(derived from id). Table/symbol renamepipeline_jobs→jobsis deferred as a cosmetic cleanup — add columns first, keep it working. - 1b. Execution. Generalize the job manager:
startJobtakesmodeand dispatches —pipeline→ existingexecutePipeline;script→ newexecuteScript(ports task-executor'smaterializeScript/buildInputEnv/bwrap sandbox/killTree/keepalive, but emits job events + appends stdout/stderr to the log file, finalizes withexit_code). Reuses the manager's viewer/broadcast/replay machinery. - 1c. Scheduler.
runningCount()+ FIFOpendingpromotion on finalize;promoteNext()on startup so a queued backlog resumes.
Phase 2 — REST job API (decouples creation from the socket; enables the phone)
POST /jobs {taskDirName, inputs, cwd, action}→{jobId}(create + start/queue, background).GET /jobs(+?live=1),GET /jobs/:id,GET /jobs/:id/log?offset=,POST /jobs/:id/stop.- Consolidate the two WebSockets into one
/api/tasks/jobs/wsdoing only attach/stop/list.
Phase 3 — Frontend
/jobs/new→NewJobScreen: reads query params, renders the input UI lifted fromTaskRunnerModal(TaskInputForm+ per-group config + folder probing). Run/Queue per the concurrency UX.JobDetailgains a script branch (terminal output: live attach, or from log when idle). RetireTaskRunnerModal/TaskRunnerDialog/useTaskRunner. Header running-jobs indicator.
Phase 4 — Notifications (later)
- One
notifyJobDone(job)hook at finalize → push to the phone app.
Progress
- 1a data model —
mode+exit_codecolumns (schema + applied to DB) - 1b executeScript + manager dispatch —
execute-script.ts(spawn/sandbox/killTree port, log file, abort poll, returns exitCode),process-tree.ts(shared killTree),pipeline-job-managernow dispatches bymodeand finalizes script jobs by exit code. Compiles; runtime-untested until a REST caller + restart exist. - 1c scheduler / queue —
enqueueJob(action)(start now / queue behind running),promoteNext()on finalize + startup,getOldestPendingJob,markInterruptedJobsnow running-only (pending queue survives restart).startJobkept as aenqueueJob(...,'start')wrapper. - 2 REST job API —
POST /jobs(create script|pipeline, action start/queue),GET /jobs(+?live=1, now returns mode/exitCode/isLive),GET /jobs/:id,GET /jobs/:id/log?offset=,POST /jobs/:id/stop. Router mounted at/jobsand/pipeline-jobs. Needs a restart to deploy; then curl/phone-testable. WS consolidation still pending (old/api/tasks/run/ws+/api/tasks/pipeline/wsstill live). - [~] 3 frontend
- 3a jobs UI — master-detail
JobsPage(like/chat):WorkspaceLayoutwith a list panel (left, pollsGET /jobs, highlights active) + a detail panel (right) that branches bymode—ScriptJobDetailterminal (polls log + status, Stop) orPipelineJobDetail. One page serves both/jobsand/jobs/:id; list click navigates. Replaced the old separate list/detail pages. inlineflag plumbed (parser + list/detail endpoints); 3 quick tasks flagged.- 3b/3c task→job via the modal (pragmatic reuse). The task modal is now the job creator: on Run,
an inline task runs ephemerally in-modal; a non-inline task
POST /jobs(start) → navigates to/jobs/:id. When a job is already running, a red "Run now" + a "Queue" button (queue →/jobs). Reuses the modal's per-group input UI in place — no separate/jobs/newpage or FileBrowser change needed. (A standalone deep-linkable/jobs/newis deferred; the phone creates jobs directly viaPOST /jobs.) - 3d header job indicators — two always-present badges next to the avatar + reload-tasks:
(1) running count (0/1) → links to the running job's
/jobs/:id; (2) queued count → links to the queue (/jobs). Backed by a lightweightGET /jobs/counts→{ running, runningJobId, queued }, polled while mounted (cheap, avoids fetching full lists). Badges hide/dim at 0.
- 3a jobs UI — master-detail
- 4 push notifications