pastilhasandClaude Opus 5
2634df7a04
closes the hole app-store/pm2.ts has carried since 2026-08-13 — "installing a
plugin has to append its entry here before starting it, that is the plugin
system's job and it is not built". this is that job, and it is why nothing in
the app-store catalogue installs end to end either.
verified against a running server with a sidecar in the tree:
install ecosystem added · sidecar started · recorded · mounted /example
route 200, pm2 online
disable sidecar stopped · unmounted
route 404, pm2 stopped
enable sidecar started · mounted
route 200, pm2 online
uninstall record removed · unmounted · sidecar stopped, deleted, entry gone
route 404, not in pm2, tables untouched
afterwards ecosystem.config.cjs is byte-identical to before, pm2 holds the same
five core apps, and plugin_installs is back to zero rows.
the ecosystem file is edited rather than regenerated: the core entries come from
officer-setup's shell array, so the platform does not know that list and a copy
here would be a second thing to drift. the header above module.exports is
preserved verbatim too — officer-setup's explains that bun auto-loads .env from
the working directory and that data-path derives the install root from its
PARENT, so a wrong cwd relocates the whole install rather than failing. losing
that to a plugin install would be a poor trade.
order is the design. bringing up goes outside-in, taking down goes inside-out,
so the worst intermediate state is "recorded but not running" — visible, and
fixed by a retry — never "running but forgotten", which nothing can see.
each verb returns what it actually did, in order, and the detail panel shows it.
an install that mounted routes but could not start a sidecar is a different
outcome from one that worked, and a spinner that stops cannot say which.
the schema push is still deliberately not wired, and the reason is now in the
code: db:push DROPS tables absent from the schema it is given, so an uninstall
that regenerated the barrel would delete a plugin's data as a side effect of
stopping it. offscale does not need it — headscale_servers already ships in the
platform schema.
720 pass, same 10 pre-existing failures.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
25 lines
1.1 KiB
TypeScript
25 lines
1.1 KiB
TypeScript
// The reference sidecar: a long-lived process PM2 supervises.
|
|
//
|
|
// A sidecar is a PEER of `officer`, never a child — that is why restarting the platform does not disturb
|
|
// it, and it is the property that makes install-without-restart possible on the platform side too.
|
|
//
|
|
// A real one binds a loopback port and registers over `/api/sidecar/register` so the platform can reach
|
|
// it by capability (see `servers/sidecar/connect.ts`). This one does neither, on purpose: it exists to
|
|
// prove that a plugin's process is written into the ecosystem file, started, stopped and deleted by the
|
|
// installer, and adding a socket here would test Bun rather than that.
|
|
|
|
const name = 'officer-example';
|
|
console.log(`[${name}] started (pid ${process.pid})`);
|
|
|
|
// Something to see in `pm2 logs officer-example`, and a reason for the process to still be alive.
|
|
const beat = setInterval(() => console.log(`[${name}] alive`), 60_000);
|
|
|
|
const shutdown = (signal: string) => {
|
|
console.log(`[${name}] ${signal} — exiting`);
|
|
clearInterval(beat);
|
|
process.exit(0);
|
|
};
|
|
|
|
process.on('SIGTERM', () => shutdown('SIGTERM'));
|
|
process.on('SIGINT', () => shutdown('SIGINT'));
|