pastilhas
5afa2d832e
Committed before restarting, deliberately: this changes the registration wire, and the restart that proves it also bounces officer-claude-code, which is what the session doing the work runs on. An uncommitted 25-file protocol change is worse to inherit than one marked unverified. `capabilities: ['music']` → `handles: ['music']` on the registration message, across 20 sidecars, both plugins, the connector, the registry and the protocol type. findSidecarByCapability → findSidecarHandling, waitForCapability → waitForHandler. The name: a sidecar already has `handleCommand`, so the list is literally what it handles. `provider` was rejected — 390 existing uses and it already means websocket door. `serves` was rejected — collides with HTTP serving, which sidecars also do. THIS IS A BREAKING WIRE CHANGE with no compatibility shim. A platform expecting `handles` reads `undefined` from a sidecar sending `capabilities`, registers it with an empty list, and every sendCommand finds nobody — chat, terminal and music all fail with "No sidecar handling X is connected". So the whole estate has to restart together; there is no rolling upgrade. If it goes wrong: `git revert HEAD` and `pm2 restart all` again. The registry is in-memory and nothing about this touches the database, so a revert is complete. Found a fifth meaning of the word on the way, correctly named and untouched: the pty sidecar's terminfo capability queries (XTGETTCAP escape sequences). That is now five — permissions, the item store, routing keys, Lightning wallet features, and terminfo. tsgo clean, 797 tests, 787 pass, same 7. Not exercised against a live sidecar.
73 lines
2.6 KiB
TypeScript
73 lines
2.6 KiB
TypeScript
import type { SidecarEvent } from '../protocol';
|
|
import { initEmailCron, stopEmailCron } from './email-cron';
|
|
import { initEmailIdle, stopEmailIdle } from './email-idle';
|
|
import { broadcastEmailNew } from './routes';
|
|
import { startEmailServer } from './http';
|
|
import { createSidecarConnector } from '../connect';
|
|
import { API_URL } from '../../officer-url.mjs';
|
|
|
|
// The sidecar used to reach BACK into the platform's queue over this socket to get a sync run —
|
|
// enqueueViaWs / listJobsViaWs and a pending-response map. Syncs run in this process now
|
|
// (sync-runner.ts), so the shim is gone and nothing but a port crosses the socket at startup.
|
|
|
|
// ── Command handlers ──
|
|
|
|
type ReplyFn = (msg: SidecarEvent) => void;
|
|
|
|
function handleCommand(cmd: Record<string, unknown>, reply: ReplyFn) {
|
|
switch (cmd.type) {
|
|
case 'ping':
|
|
reply({ type: 'pong', id: cmd.id as string });
|
|
break;
|
|
|
|
default:
|
|
reply({
|
|
type: 'error',
|
|
id: cmd.id as string,
|
|
error: `Unknown command type: ${cmd.type}`,
|
|
});
|
|
}
|
|
}
|
|
|
|
// ── HTTP server ──
|
|
//
|
|
// Started before the registration socket so the port is known by the time we announce it. `/api/email/*`
|
|
// on the platform is a proxy onto this.
|
|
const serverPort = startEmailServer();
|
|
|
|
// ── Connect to API server ──
|
|
|
|
const connection = createSidecarConnector({
|
|
apiUrl: `${API_URL}/api/sidecar/register`,
|
|
name: 'email',
|
|
handles: ['email'],
|
|
onCommand(cmd, reply) {
|
|
handleCommand(cmd as Record<string, unknown>, reply as ReplyFn);
|
|
},
|
|
onConnected() {
|
|
// The platform forgets the port when the socket drops, and this listener outlives an officer restart,
|
|
// so re-announce on every reconnect.
|
|
connection.send({ type: 'email:server', port: serverPort });
|
|
// Start email cron once connected (so queue commands can reach API server)
|
|
initEmailCron();
|
|
// Real-time push via IMAP IDLE; the cron above is the slow backstop. On new mail, tell the API
|
|
// server so it can push an SSE event to that user's open /email page.
|
|
// Straight to this process's own SSE clients — the /email/events stream lives here now, so the
|
|
// round trip out to officer and back (the `email:new` wire event) is gone.
|
|
initEmailIdle((userEmail) => broadcastEmailNew(userEmail));
|
|
},
|
|
});
|
|
|
|
// ── Graceful shutdown ──
|
|
|
|
function shutdown(signal: string) {
|
|
console.log(`[email] ${signal} received, shutting down...`);
|
|
stopEmailIdle();
|
|
stopEmailCron();
|
|
connection.destroy();
|
|
process.exit(0);
|
|
}
|
|
|
|
process.on('SIGTERM', () => shutdown('SIGTERM'));
|
|
process.on('SIGINT', () => shutdown('SIGINT'));
|