pastilhas
0a55964db5
officerdev/src/MusicPlayer/ → plugins/music/web/. Engine, state, bar, favourites, lyrics toggle and the library vocabulary — ten files. The barrel stops exporting a player it no longer has, and DashboardLayout stops rendering one. The reasoning that kept it was removed rather than refuted. It stayed because the dashboard widget imported useMusicPlayer from officerdev and the platform cannot import from a plugin, so the state had to stay whatever was decided about the UI. The owner moved the widget into the plugin in the previous commit, and the constraint went with it: the whole remaining dependency became one line, DashboardLayout.tsx:66. MusicPlayerHost is mounted inside the MusicDetail panel. That reads odd until you notice it already returned null on /music — the mini bar is the transport there, and the host existed purely to own the GaplessEngine. In the panel it does exactly that, and the bar code stays intact for whenever there is a slot. [phase 2] Leaving /music unmounts the host and playback stops. Deferred on the owner's call; the bar was "navigating away must not break the application", and that holds: seekPlayer is optional-chained so a call with no host registered is a no-op, registerPlayerSeek clears only its own registration, the host's cleanup destroys the engine and nulls its ref, and the queue is global state so returning to /music remounts and reloads. Solving it properly needs either a shell slot a plugin can contribute to — which reopens "there is no way to export a component" — or the engine hoisted to module scope, which keeps the rule and loses only the off-route controls. Also: the parked widget now imports the player as a sibling rather than through officerdev, and shared.ts stopped being a re-export shim now that the real file is in the plugin. Verified: tsgo clean, 797 tests / 787 pass / same 7. Server restarts, mounts /example /music /offscale, / and /music both 200, and the player is in the built bundle (music.volume, music:lyrics, now-playing?device=web all present — GaplessEngine is a class name and the production build is minified, so grepping for it proves nothing). Not verified by me: what it looks like in a browser. That needs your eyes.
26 lines
1.0 KiB
TypeScript
26 lines
1.0 KiB
TypeScript
import { usePanelChannel } from 'hooks/usePanelChannel';
|
|
|
|
export const MUSIC_LYRICS_CHANNEL = 'music:lyrics';
|
|
|
|
const STORAGE_KEY = 'music.lyrics';
|
|
// Read once, at import: the play dock re-renders every animation frame, and this is its initial value.
|
|
const initialOpen = localStorage.getItem(STORAGE_KEY) === '1';
|
|
|
|
/**
|
|
* Whether the lyrics panel is open. Shared by the two microphone buttons — the one in the play dock and
|
|
* the one on the album header — which are the same switch shown twice, so it lives in a channel rather
|
|
* than in either component. Seeded from localStorage so the choice survives a reload.
|
|
*/
|
|
export const useLyricsOpen = () => {
|
|
const [open, setOpen] = usePanelChannel<boolean>(MUSIC_LYRICS_CHANNEL, initialOpen);
|
|
|
|
// Deliberately not a functional update: useGlobal applies those to the render-time snapshot, and `open`
|
|
// is that snapshot anyway.
|
|
const toggleLyrics = () => {
|
|
localStorage.setItem(STORAGE_KEY, open ? '0' : '1');
|
|
setOpen(!open);
|
|
};
|
|
|
|
return [open, toggleLyrics] as const;
|
|
};
|