pastilhasandClaude Opus 5
19bbbab907
Three mechanisms where there should be one. The catalogue was filled by hand, and each host separately polled twenty-one repositories with git to work out whether a release existed — a second source of truth for a fact one place already knew. Shipping photos 2026.09.03.02 correctly and watching alpha not notice for ten minutes is what started this. The timer. scripts/marketplace-cron.sh, every minute, on the machine that publishes. Safe now only because the previous commit made the sync read tags instead of working trees; over the old one this would have published somebody's afternoon on a schedule. Nothing is written unless the release commit differs from the one already published, so a tick with nothing to do is one query, one fetch per repo and no writes — about 2.7s. One timestamped summary line per tick regardless, because a fresh timestamp is the only thing that separates "nothing to publish" from "the timer died"; a named line only for a plugin that moved. The badge. `updateable` now compares the tag at HEAD with the tag the catalogue says is newest — difference, not ordering, since parsing 2026.08.27.01 works right up until somebody tags v2 and then fails silently. refreshRemote() and its two-minute window are gone with the polling they existed to paper over. The git rule stays as the fallback for a plugin the store cannot speak for: an unregistered checkout, or an unreachable store. That case now reads whatever refs the last pull left, which is the accepted cost of not making every machine poll every repository forever. fetchCatalogue()'s cache went from five minutes to one. It only drew tiles before; now the wait for a release to appear would have been the sync's minute plus its five. Also: the Update button names its destination whenever a release is known, not only on `new-release`. An untagged checkout reports `untagged` and used to lose the tag with it, so the button said "Update" and the owner had to guess where it landed — the marketplace knows, even for a checkout that has never fetched it. Verified: forced a stale row, the timer republished it inside 60s and logged one line. Badge decisions checked against the live catalogue for seven plugins, including the two shapes that matter — at a tag the store agrees with, and untagged with a release known only to the store. 9 release tests pass, 100% of release.ts covered, four of them new and all against real repositories. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
47 lines
2.0 KiB
Bash
Executable File
47 lines
2.0 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Publish every plugin release to the marketplace catalogue. Meant for cron, on the ONE machine that
|
|
# publishes.
|
|
#
|
|
# ── Why a timer at all, when a webhook would be instant ──
|
|
#
|
|
# The sync reads bare mirrors at their newest tag, so running it on a schedule cannot publish anything
|
|
# that was not pushed — which is exactly what made a timer unsafe before, and is no longer true. A Gitea
|
|
# webhook would cut the delay from a minute to a second, and it would also mean a public write route, a
|
|
# shared secret, and a second path into the same code. A minute is not the problem anybody had: the
|
|
# complaint that started this was a release that never appeared at all.
|
|
#
|
|
# ── What it costs ──
|
|
#
|
|
# About 2.7s per tick with nothing to do — one query, one fetch per repository, no writes. Gitea is on
|
|
# this same machine, so none of that leaves the box.
|
|
#
|
|
# ── The log ──
|
|
#
|
|
# One timestamped summary line per tick, ALWAYS, including the ticks that do nothing. A fresh timestamp
|
|
# is the only thing that distinguishes "nothing to publish" from "the timer died". Plugin-level lines
|
|
# appear only for a plugin that actually moved, which is what `--quiet` buys.
|
|
|
|
set -uo pipefail
|
|
|
|
PLATFORM="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
|
|
LOG="${MARKETPLACE_SYNC_LOG:-$(dirname "$PLATFORM")/marketplace-sync.log}"
|
|
LOCK="/tmp/officer-marketplace-sync.lock"
|
|
|
|
# Cron's PATH is three entries and bun is in none of them.
|
|
export PATH="$HOME/.bun/bin:/usr/local/bin:/usr/bin:/bin"
|
|
|
|
cd "$PLATFORM" || exit 1
|
|
|
|
# Skip rather than queue. A tick that finds the previous one still running has nothing to add — the run
|
|
# in progress will publish whatever this one would have.
|
|
exec 9>"$LOCK"
|
|
flock -n 9 || exit 0
|
|
|
|
bun --env-file=.env scripts/marketplace-sync.ts --quiet >>"$LOG" 2>&1
|
|
|
|
# Bounded without logrotate, because this is one file on one machine and a config file for it would be
|
|
# more moving parts than the thing it manages.
|
|
if [ "$(wc -l <"$LOG")" -gt 20000 ]; then
|
|
tail -n 5000 "$LOG" >"$LOG.tmp" && mv "$LOG.tmp" "$LOG"
|
|
fi
|