pastilhasandClaude Opus 5
aac8af5e1f
The first watcher had an unbounded retry in it. A release whose deploy failed left no .done file, so the next poll two minutes later spawned a fresh headless agent, and the one after that, all night, each one costing money. The loop was careful and its logging was honest; the defect was structural. It is structural because the loop is written FRESH by an agent every time one arms. A rule that lives only in the prompt gets re-implemented from scratch each time, and the wrong implementation is the one that looks right: test the .done file. That file only exists on success, so testing it is exactly the retry storm. So scripts/deploy-claim.sh owns it. `claim <version>` exits 0 once and 1 for ever after, whatever became of the attempt that held it — a failed release is not retried, it is looked at. Handing the claim back is `rm -rf` by a person, on purpose; a loop cannot undo its own claim, which is what makes the storm impossible rather than unlikely. Three choices in it worth keeping: - `mkdir` is the claim. One atomic syscall that both tests and takes, with no window between checking and acting — two pollers a second apart is not hypothetical when a watcher gets restarted. - Bash, not bun. The thing that stops a retry storm must not need a healthy checkout; a deploy that dies on `bun install` is precisely when it has to work. - A version is digits and dots or it is refused. It arrives off a git tag and is concatenated into a path. A pre-existing .done with no claim beside it still counts as deployed, so deploy/2026.08.21.01 — rolled out by hand before any of this existed — is not re-attempted. docs/servers.md corrected from the commander's own report, which was right and specific: on macbookpro APPEND /opt/homebrew/bin for bun rather than replacing the PATH (this file said "do not help the PATH", which is right for pm2 and is what made plugins:update fail there), `ls` is aliased to an eza that is not installed, plugins:update bounces every sidecar before the plan's own restart step, and fofos cannot publish affordances for what is probably the same ownership problem as its capabilities sync. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
61 lines
2.6 KiB
TypeScript
61 lines
2.6 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it } from 'bun:test';
|
|
import { existsSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
|
|
const SCRIPT = join(import.meta.dir, 'deploy-claim.sh');
|
|
let dir: string;
|
|
|
|
const run = (...args: string[]) => {
|
|
const p = Bun.spawnSync([SCRIPT, ...args], { env: { ...process.env, DEPLOYS_DIR: dir } });
|
|
return { code: p.exitCode, out: p.stdout.toString(), err: p.stderr.toString() };
|
|
};
|
|
|
|
beforeEach(() => {
|
|
dir = mkdtempSync(join(tmpdir(), 'deploy-claim-'));
|
|
});
|
|
afterEach(() => rmSync(dir, { recursive: true, force: true }));
|
|
|
|
// The whole point of this script is that the SECOND caller is refused. Everything else is scaffolding.
|
|
describe('deploy-claim', () => {
|
|
it('grants once and refuses after, whatever the outcome was', () => {
|
|
expect(run('claim', '2026.09.01.01').code).toBe(0);
|
|
expect(run('claim', '2026.09.01.01').code).toBe(1);
|
|
// Still refused after a failure — no .done was ever written. This is the retry storm not happening.
|
|
expect(run('claim', '2026.09.01.01').code).toBe(1);
|
|
expect(run('state', '2026.09.01.01').out.trim()).toBe('claimed');
|
|
});
|
|
|
|
it('refuses a release already deployed, even with no claim beside it', () => {
|
|
// A release deployed by hand before this script existed. `deploy/2026.08.21.01` is exactly this case.
|
|
writeFileSync(join(dir, '2026.08.21.01.done'), 'deployed by hand\n');
|
|
expect(run('claim', '2026.08.21.01').code).toBe(1);
|
|
expect(run('claim', '2026.08.21.01').err).toContain('already deployed');
|
|
});
|
|
|
|
it('lets a human hand the claim back, and only a human', () => {
|
|
expect(run('claim', '2026.09.01.02').code).toBe(0);
|
|
rmSync(join(dir, '2026.09.01.02.claim'), { recursive: true });
|
|
expect(run('claim', '2026.09.01.02').code).toBe(0);
|
|
});
|
|
|
|
it('records success separately from the claim', () => {
|
|
run('claim', '2026.09.01.03');
|
|
run('done', '2026.09.01.03');
|
|
expect(run('state', '2026.09.01.03').out.trim()).toBe('done');
|
|
expect(existsSync(join(dir, '2026.09.01.03.done'))).toBe(true);
|
|
});
|
|
|
|
// The version comes off a git tag, and it is concatenated into a path.
|
|
it('refuses anything that is not digits and dots', () => {
|
|
for (const bad of ['../../etc/passwd', 'x; rm -rf /', '2026.08.21.01/..', '', 'v1']) {
|
|
expect(run('claim', bad).code).toBe(2);
|
|
}
|
|
expect(existsSync(join(dir, '..', 'etc'))).toBe(false);
|
|
});
|
|
|
|
it('says so plainly when nothing has been attempted', () => {
|
|
expect(run('list').out).toContain('no releases attempted');
|
|
});
|
|
});
|