rename officer-agent to officer-claude-code

The old name said nothing about what the process runs, and it sits directly
beside officer-anthropic-proxy — a different process doing a different job — so
"the agent" was ambiguous exactly where it mattered. CLAUDE.md already had to
spend a paragraph insisting the two are not the same thing. It spawns `claude`;
the name says so now.

Only two references were functional: the generator's CORE_PROCESSES and the CORE
list in catalogue.test.ts. Everything else was prose or comments.

Left alone deliberately: `x-officer-agent-token`. It looks like the same string
and is not — it is the agent-handoff HTTP header, naming a per-panel bearer
token, unrelated to any pm2 process. Renaming it would have changed a wire
protocol to tidy a label.

Historical docs keep the old name. claude-sidecar-isolation.md and
open-threads-after-per-user-claude.md are dated investigations that record the
PREVIOUS rename, from officer-claude to officer-agent, and rewriting them would
make that history unreadable. CLAUDE.md notes the change instead, where somebody
reading those will be looking.

Also worth recording, from the owner: merging this with officer-anthropic-proxy
into one sidecar was investigated tonight and rejected. They stay separate.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

scripts/setup/officer-setup/lib/services.sh

@@ -33,10 +33,15 @@ ecosystem_file() { echo "$(platform_dir)/ecosystem.config.cjs"; }
 #
 # `officer-pty` is node rather than bun, and that is not an oversight: it loads
 # node-pty, a native module built against Node's ABI. Everything else is bun.
+#
+# `officer-claude-code` was `officer-agent` until 2026-08-13. The old name said
+# nothing about what it runs, and it sits beside officer-anthropic-proxy — which
+# is a different process doing a different job — so "the agent" was ambiguous
+# exactly where it mattered. It spawns `claude`; the name says so now.
 CORE_PROCESSES=(
   "officer|bun|start"
   "officer-anthropic-proxy|bun|run src/servers/sidecar/claude/index.ts"
-  "officer-agent|bun|run src/servers/sidecar/claude/user-instance.ts"
+  "officer-claude-code|bun|run src/servers/sidecar/claude/user-instance.ts"
   "officer-opencode|bun|run src/servers/sidecar/opencode/index.ts"
   "officer-pty|node|src/servers/sidecar/pty/index.mjs"
   "officer-headscale|bun|run src/servers/sidecar/headscale/index.ts"