a manifest cannot ask for a particular port

A preference sounds helpful and fails silently. When the wished-for number is taken the plugin is handed a different one, the install succeeds, and whatever was configured against the old number goes on pointing at nothing - with nobody told. This afternoon that nearly happened: 3011 was only free because fofos-dev had been stopped twenty minutes earlier, and had it still been running the site would have been given a random port behind an nginx host still aimed at 3011. So the number is always drawn fresh and always kept. Always drawn means it is never something you can assume; always kept means the proxy host is configured against it exactly once. The failure mode that remains - having to go and read the number - is one that announces itself, which the other one did not. isFree went with it; it existed only to test a wish.
2026-09-06 10:58:41 +01:00
parent 518d329c29
commit d9110c373d
3 changed files with 10 additions and 38 deletions
@@ -463,7 +463,7 @@ export async function installPlugin(
      */
      const ports: Record<string, number> = {};
      for (const declared of plugin.manifest.extraPorts ?? []) {
-        ports[declared.name] = await allocatePluginPort(appName, declared.name, declared.preferred);
+        ports[declared.name] = await allocatePluginPort(appName, declared.name);
      }
      if (Object.keys(ports).length) {
        await step(