prefix the env with OFFICERDEV_, and keep reading the bare names
PORT, PUBLIC_URL and POSTGRES_URL are names half the software in the world uses. Bun auto-loads .env into EVERY process started in the platform directory, so a bare PORT reaches the sidecars, the tools they spawn and anything an agent runs from here — and a bare POSTGRES_URL reaches things with no business holding a database credential. Four parts. officer-setup now writes OFFICERDEV_-prefixed names, with the reasoning in the generated file so whoever opens it later knows why. Every consumer reads `OFFICERDEV_X ?? X` — eleven sites across the databases, the DAV router, officer-url.mjs, os-user-postgres and two scripts. The bare name is the FALLBACK, never the source, which is what makes this safe to ship before every machine has been converted. `bun run fix:env` converts a file in place. Idempotent, preserves comments and `export`, leaves the value untouched including an `=` inside it, and refuses to touch names belonging to other software — prefixing PATH or NODE_ENV does not rename a variable, it deletes it. And it runs on every restart from the server settings screen. There rather than at boot because a restart is the one moment the file can be rewritten and take effect in the same breath: the process about to start is the one that reads it. Non-fatal, since the fallback means the worst case is that nothing changed. gen-index reads either spelling out of the file directly, because it is run by hand as often as by the setup and a bare shell has no .env loaded. Verified by converting this machine's own .env: PORT, PUBLIC_URL and the database all still resolve, gen:index still finds its URL, 1152 pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -60,13 +60,22 @@ write_env() {
|
||||
#
|
||||
# Everything Officer reads at runtime. Kept at 0600 and owned by ${USERNAME}: it
|
||||
# holds the token-signing secret and the database credential.
|
||||
#
|
||||
# EVERY NAME IS PREFIXED \`OFFICERDEV_\`. Bun auto-loads this file into every
|
||||
# process started in the platform directory, so a bare PORT or POSTGRES_URL
|
||||
# reaches the sidecars, the tools they spawn and anything an agent runs from
|
||||
# here — names half the software in the world already uses. Prefixed, they
|
||||
# cannot be picked up by accident.
|
||||
#
|
||||
# Every consumer reads \`OFFICERDEV_X ?? X\`, so an older unprefixed file still
|
||||
# works. \`bun run fix:env\` converts one in place.
|
||||
|
||||
PORT="${ENV_PORT}"
|
||||
OFFICERDEV_PORT="${ENV_PORT}"
|
||||
|
||||
# Where Officer is reached from a browser. Not derivable — see the section.
|
||||
PUBLIC_URL="${ENV_PUBLIC_URL}"
|
||||
OFFICERDEV_PUBLIC_URL="${ENV_PUBLIC_URL}"
|
||||
|
||||
POSTGRES_URL="${POSTGRES_URL}"
|
||||
OFFICERDEV_POSTGRES_URL="${POSTGRES_URL}"
|
||||
|
||||
ENVF
|
||||
|
||||
|
||||
Reference in New Issue
Block a user