prefix the env with OFFICERDEV_, and keep reading the bare names

PORT, PUBLIC_URL and POSTGRES_URL are names half the software in the world
uses. Bun auto-loads .env into EVERY process started in the platform directory,
so a bare PORT reaches the sidecars, the tools they spawn and anything an agent
runs from here — and a bare POSTGRES_URL reaches things with no business
holding a database credential.

Four parts.

officer-setup now writes OFFICERDEV_-prefixed names, with the reasoning in the
generated file so whoever opens it later knows why.

Every consumer reads `OFFICERDEV_X ?? X` — eleven sites across the databases,
the DAV router, officer-url.mjs, os-user-postgres and two scripts. The bare
name is the FALLBACK, never the source, which is what makes this safe to ship
before every machine has been converted.

`bun run fix:env` converts a file in place. Idempotent, preserves comments and
`export`, leaves the value untouched including an `=` inside it, and refuses to
touch names belonging to other software — prefixing PATH or NODE_ENV does not
rename a variable, it deletes it.

And it runs on every restart from the server settings screen. There rather than
at boot because a restart is the one moment the file can be rewritten and take
effect in the same breath: the process about to start is the one that reads it.
Non-fatal, since the fallback means the worst case is that nothing changed.

gen-index reads either spelling out of the file directly, because it is run by
hand as often as by the setup and a bare shell has no .env loaded.

Verified by converting this machine's own .env: PORT, PUBLIC_URL and the
database all still resolve, gen:index still finds its URL, 1152 pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-19 11:46:00 +00:00
co-authored by Claude Opus 5
parent b27410a6fc
commit b9524ee4d5
15 changed files with 203 additions and 19 deletions
+14
View File
@@ -0,0 +1,14 @@
// `bun run fix:env` — give every variable in `.env` the `OFFICERDEV_` prefix.
//
// A thin front for `servers/env-prefix.ts`, which is where the rules live. Deliberately that way round:
// the same conversion runs on every restart from the server settings screen, and a router reaching into
// `scripts/` to do it would make a maintenance script part of the request path.
import { join } from 'node:path';
import { fixEnvFile } from '../src/servers/env-prefix';
const path = process.argv[2] ?? join(process.cwd(), '.env');
const { changed, alreadyPrefixed } = fixEnvFile(path);
if (changed.length) console.log(`[fix:env] prefixed ${changed.length}: ${changed.join(', ')}`);
else console.log(`[fix:env] nothing to do (${alreadyPrefixed} already prefixed)`);