hold bun at the 1.3 series until 1.4 has been watched
bun 1.4.0 was published 2026-08-20 and https://bun.sh/install serves whatever is newest, so machine-setup provisioning a box today would put a two-day-old release under the platform and every pm2 app except officer-pty. The owner asked for a temporary hold on 1.3. The SERIES is pinned, not a patch — BUN_SERIES=1.3, resolved to the newest 1.3.x at install time so bug fixes inside the series still land, and no 1.3.14 to rot into "the version we happened to pick" the way setup_22.x did for Node. The version reaches the installer as its documented first positional argument (a release tag), and install_bun refuses to run with an empty one: taking whatever bun.sh serves is the single outcome the pin exists to prevent, so no bun at all is the better failure. Loud, and officer-setup's pre-flight already stops on a missing bun. Resolved from the npm registry rather than GitHub's releases API, which is the obvious source and the wrong one — 60 unauthenticated requests an hour per IP, and it returned 504 twice while this was written. An empty answer installs nothing, so where it comes from is load-bearing. The section now reads four states instead of two. "Installed" was one answer covering a machine inside the pin, one behind it, and one past it; past it is the case worth catching, since that is what bun upgrade leaves and nothing else reports it. Above and below get different prose and both offer to move; nothing is corrected silently. What a setup script cannot cover: bun upgrade takes no version argument — latest stable or --canary, verified against its own --help — so it always jumps past the pin without saying so. Hence the doctor check, which reads engines.bun rather than repeating the number, because a second hardcoded copy is a second thing to drift. bun ignores engines (verified: an install declaring 1.9.x ran clean under 1.3.14), so the field is the declaration and doctor is the enforcement. Confirmed bun install --dry-run still resolves frozen with the field present and bun.lock unchanged. This host is already on 1.3.14 and inside the pin, so nothing moved here. Also fixes three more stale process counts in the same block. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1981,14 +1981,18 @@ step "JavaScript runtimes"
|
||||
if ! skip; then
|
||||
NODE_LTS="$(node_lts_major)"
|
||||
NODE_NOW="$(node_installed_major)"
|
||||
# Resolved before the banner so it can state the pin rather than only the version
|
||||
# that happens to be here. One network call, same as node_lts_label above it.
|
||||
BUN_WANT="$(bun_series_latest)"
|
||||
BUN_NOW="$(bun_version)"
|
||||
|
||||
echo ""
|
||||
info "JavaScript runtimes — required, so these are installed rather than offered"
|
||||
echo " node ${NODE_NOW:+v$NODE_NOW }${NODE_NOW:+-> }LTS $(node_lts_label)"
|
||||
echo " pm2 is a Node application, and officer-pty compiles node-pty"
|
||||
echo " against whatever Node is installed — there is no Linux prebuild."
|
||||
echo " bun $(bun_installed && bun_version || echo 'not installed')"
|
||||
echo " the platform itself, and nineteen of the twenty pm2 apps."
|
||||
echo " bun ${BUN_NOW:-not installed} — pinned to the ${BUN_SERIES} series${BUN_WANT:+, newest is ${BUN_WANT}}"
|
||||
echo " the platform itself, and every pm2 app except officer-pty."
|
||||
echo " pm2 $(pm2_installed && echo installed || echo 'not installed')"
|
||||
echo " supervises all of them, and the ecosystem files are written for it."
|
||||
echo ""
|
||||
@@ -2014,18 +2018,93 @@ if ! skip; then
|
||||
fi
|
||||
fi
|
||||
|
||||
# ── bun ──
|
||||
if bun_installed; then
|
||||
ok "bun $(bun_version) already installed"
|
||||
else
|
||||
info " installing bun..."
|
||||
if install_bun && bun_installed; then
|
||||
# ── bun, held at the pinned series ──
|
||||
#
|
||||
# Four states, because "installed" is not one answer. A machine can be inside the
|
||||
# pin, behind it, or past it — and past it is the case worth catching, since that
|
||||
# is what a `bun upgrade` leaves behind and nothing else reports it.
|
||||
if [[ -z "$BUN_WANT" ]]; then
|
||||
# No pin resolved means no install: taking whatever bun.sh serves is the one
|
||||
# thing the pin exists to stop.
|
||||
warn "could not reach the npm registry to find the newest bun ${BUN_SERIES}.x"
|
||||
if bun_installed; then
|
||||
echo " leaving bun ${BUN_NOW} where it is"
|
||||
ERRORS+=("Bun: could not resolve ${BUN_SERIES}.x; left ${BUN_NOW} alone")
|
||||
else
|
||||
echo " nothing installed — this will not install an unpinned bun, and"
|
||||
echo " officer-setup stops on a missing bun rather than building on 1.4."
|
||||
ERRORS+=("Bun: could not resolve ${BUN_SERIES}.x; nothing installed")
|
||||
fi
|
||||
|
||||
elif ! bun_installed; then
|
||||
info " installing bun ${BUN_WANT}, pinned to the ${BUN_SERIES} series..."
|
||||
if install_bun "bun-v${BUN_WANT}" && bun_installed; then
|
||||
ok "bun $(bun_version)"
|
||||
SUMMARY+=("Bun: $(bun_version)")
|
||||
SUMMARY+=("Bun: $(bun_version) (pinned to ${BUN_SERIES}.x)")
|
||||
else
|
||||
warn "the bun install did not complete"
|
||||
ERRORS+=("Bun: install failed")
|
||||
fi
|
||||
|
||||
else
|
||||
case "$(bun_series_position "$BUN_NOW")" in
|
||||
in)
|
||||
if [[ "$BUN_NOW" == "$BUN_WANT" ]]; then
|
||||
ok "bun ${BUN_NOW} — the newest in the pinned ${BUN_SERIES} series"
|
||||
else
|
||||
info "bun ${BUN_NOW} is inside the pin, and ${BUN_WANT} is out"
|
||||
echo " A patch inside the series is what the pin is meant to let"
|
||||
echo " through. Note that 'bun upgrade' would not stop there — it"
|
||||
echo " takes the newest release, which is past the pin."
|
||||
if confirm "Move to ${BUN_WANT}?"; then
|
||||
if install_bun "bun-v${BUN_WANT}"; then
|
||||
ok "bun $(bun_version)"
|
||||
SUMMARY+=("Bun: ${BUN_NOW} -> $(bun_version)")
|
||||
else
|
||||
warn "the install did not complete — bun ${BUN_NOW} is untouched"
|
||||
ERRORS+=("Bun: could not move to ${BUN_WANT}")
|
||||
fi
|
||||
else
|
||||
echo " left at ${BUN_NOW}"
|
||||
fi
|
||||
fi
|
||||
;;
|
||||
above)
|
||||
# The `bun upgrade` case. Reported rather than corrected silently: moving
|
||||
# somebody's runtime backwards is a decision, and this is the only place
|
||||
# that knows it happened.
|
||||
warn "bun ${BUN_NOW} is PAST the pinned ${BUN_SERIES} series"
|
||||
echo " Most likely a 'bun upgrade', which takes no version argument and"
|
||||
echo " always jumps to the newest release. The platform and every pm2"
|
||||
echo " app except officer-pty run on this."
|
||||
if confirm "Pin it back to ${BUN_WANT}?"; then
|
||||
if install_bun "bun-v${BUN_WANT}"; then
|
||||
ok "bun $(bun_version) — back inside the pin"
|
||||
SUMMARY+=("Bun: pinned back, ${BUN_NOW} -> $(bun_version)")
|
||||
else
|
||||
warn "the install did not complete — bun ${BUN_NOW} is untouched"
|
||||
ERRORS+=("Bun: could not pin ${BUN_NOW} back to ${BUN_WANT}")
|
||||
fi
|
||||
else
|
||||
warn "left at ${BUN_NOW}, outside the pin"
|
||||
SUMMARY+=("Bun: ${BUN_NOW}, PAST the ${BUN_SERIES} pin by choice")
|
||||
fi
|
||||
;;
|
||||
*)
|
||||
info "bun ${BUN_NOW} is older than the pinned ${BUN_SERIES} series"
|
||||
if confirm "Move to ${BUN_WANT}?"; then
|
||||
if install_bun "bun-v${BUN_WANT}"; then
|
||||
ok "bun $(bun_version)"
|
||||
SUMMARY+=("Bun: ${BUN_NOW} -> $(bun_version)")
|
||||
else
|
||||
warn "the install did not complete — bun ${BUN_NOW} is untouched"
|
||||
ERRORS+=("Bun: could not move to ${BUN_WANT}")
|
||||
fi
|
||||
else
|
||||
echo " left at ${BUN_NOW}"
|
||||
fi
|
||||
;;
|
||||
esac
|
||||
fi
|
||||
|
||||
# Ensured every run, not only after an install. A machine that already had bun
|
||||
|
||||
Reference in New Issue
Block a user