delete the claude-done hook and its unauthenticated endpoint
The chain was: a Stop hook in Claude's settings curls POST /api/hooks/claude-done, the platform POSTs /_officer/panel-refresh to the pty sidecar, the sidecar sends a `panel-refresh` frame to every attached terminal, and the Claude Code panel bumps `preview:refresh` and `files:refresh-signal`. It has never fired. generateClaudeSettings writes settings.json into the MANAGED home under DATA_PATH, but HOME_DIR points terminals at the owner's real login home — which is where Claude reads its settings from. Verified on this machine: no claude-done hook exists in ~/.claude/settings.json, and DATA_PATH/*/home/.claude does not exist at all. Deleting rather than repairing it, because the Chat panel already does exactly this job from onTurnComplete — in-process, conditioned on the turn having made tool calls, with no hook, no HTTP round trip, and no endpoint. The chat UI is where agent work happens; the terminal TUI is not the destination. Also removes /api/hooks/claude-done, which was mounted above protectedRouter and so was the one unauthenticated write-ish endpoint on the API surface. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,8 +1,8 @@
|
||||
import { createSidecarProxy } from '../../sidecar/create-proxy';
|
||||
|
||||
// `/api/terminal/*` is a plain auth-and-forward proxy onto the pty sidecar's own listener, like every
|
||||
// other HTTP sidecar. The sidecar owns `/_officer/sessions` (list), `DELETE /_officer/sessions/:id` (kill)
|
||||
// and `POST /_officer/panel-refresh`; the platform knows none of those contracts, only where to send them.
|
||||
// other HTTP sidecar. The sidecar owns `/_officer/sessions` (list) and `DELETE /_officer/sessions/:id`
|
||||
// (kill); the platform knows neither contract, only where to send them.
|
||||
//
|
||||
// `/api/terminal/ws` does NOT come through here — Bun's route table takes it first and hands it to the
|
||||
// byte relay in `websocket.ts`.
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import type { ServerWebSocket } from 'bun';
|
||||
import { getTerminalWsUrl, getTerminalHttpUrl } from './sidecar-server';
|
||||
import { getTerminalWsUrl } from './sidecar-server';
|
||||
|
||||
// Byte relay between the browser and the pty sidecar's own socket.
|
||||
//
|
||||
@@ -93,12 +93,3 @@ export const terminalWebsocket = {
|
||||
|
||||
drain() {},
|
||||
};
|
||||
|
||||
// The claude-done hook asks attached terminals to refresh their panel. The sidecar holds those sockets
|
||||
// now, so this is a POST to it rather than a loop over sockets officer used to own. Fire-and-forget: a
|
||||
// missed refresh is a stale panel, not a failure worth surfacing.
|
||||
export const broadcastPanelRefresh = (_email: string): void => {
|
||||
const base = getTerminalHttpUrl();
|
||||
if (!base) return;
|
||||
fetch(`${base}/_officer/panel-refresh`, { method: 'POST' }).catch(() => {});
|
||||
};
|
||||
|
||||
@@ -2,11 +2,8 @@ import { existsSync, mkdirSync, readdirSync, readFileSync, writeFileSync } from
|
||||
import { join } from 'node:path';
|
||||
import { itemsDir, getHomeDir, DATA_PATH } from '@@/data-path';
|
||||
|
||||
type HookEntry = { type: string; command: string };
|
||||
type HookRule = { matcher?: Record<string, unknown>; hooks: HookEntry[] };
|
||||
type ClaudeSettings = Record<string, unknown> & {
|
||||
hooks?: Record<string, HookRule[]>;
|
||||
};
|
||||
// Whatever the host's settings.json holds is preserved verbatim; we only add the two permission keys below.
|
||||
type ClaudeSettings = Record<string, unknown>;
|
||||
|
||||
type FrontmatterEntry = { name: string; description: string };
|
||||
|
||||
@@ -141,17 +138,11 @@ export function generateClaudeSettings(email: string, username?: string): string
|
||||
// no host settings
|
||||
}
|
||||
|
||||
const hookCommand = `curl -s -X POST http://localhost:5000/api/hooks/claude-done -H 'Content-Type: application/json' -d '{"email":"${email}"}'`;
|
||||
const hooks = settings.hooks ?? {};
|
||||
const stopRules = hooks.Stop ?? [];
|
||||
const hasOurHook = stopRules.some((rule) => rule.hooks?.some((h) => h.command?.includes('/api/hooks/claude-done')));
|
||||
|
||||
if (!hasOurHook) {
|
||||
stopRules.push({ hooks: [{ type: 'command', command: hookCommand }] });
|
||||
}
|
||||
|
||||
hooks.Stop = stopRules;
|
||||
settings.hooks = hooks;
|
||||
// A Stop hook used to be injected here, curling /api/hooks/claude-done so the file browser would refresh
|
||||
// when the terminal's Claude finished. It never fired: this writes to the MANAGED home under DATA_PATH,
|
||||
// while HOME_DIR points terminals at the owner's real login home, where Claude actually reads its
|
||||
// settings. The chat UI — the destination for agent work — refreshes those panels itself from
|
||||
// onTurnComplete, with no hook, no HTTP round trip and no unauthenticated endpoint.
|
||||
settings.defaultMode = 'bypassPermissions';
|
||||
settings.skipDangerousModePermissionPrompt = true;
|
||||
|
||||
|
||||
@@ -45,7 +45,6 @@ import { desktopRouter } from './api/desktop/rest';
|
||||
import { bugReportRouter } from './api/bug-report/bug-report';
|
||||
import { chatRouter } from './api/chat/chat';
|
||||
import { pipelineJobsRouter } from './api/tasks/pipeline-jobs-routes';
|
||||
import { broadcastPanelRefresh } from './api/terminal/websocket';
|
||||
import { CustomError } from './custom-errors';
|
||||
import { userMiddleware, bodyParser, isOriginAllowed, originScopeMiddleware } from './_middlewares';
|
||||
import { isMusicOriginExempt } from './_middlewares/origin-validation';
|
||||
@@ -84,14 +83,6 @@ honoServer.route('/api/waitlist', waitlistRouter);
|
||||
// notifications WebSocket is upgraded at the serve level (server.tsx).
|
||||
honoServer.route('/api/vault', vaultRouter);
|
||||
honoServer.get('/api/integrations/google/callback', googleCallbackHandler);
|
||||
honoServer.post('/api/hooks/claude-done', async (ctx) => {
|
||||
const body = await ctx.req.json().catch(() => null);
|
||||
const email = (body as Record<string, unknown> | null)?.email;
|
||||
if (typeof email === 'string' && email.includes('@')) {
|
||||
broadcastPanelRefresh(email);
|
||||
}
|
||||
return ctx.json({ ok: true });
|
||||
});
|
||||
|
||||
const protectedRouter = createRouter();
|
||||
protectedRouter.use(bodyParser());
|
||||
|
||||
@@ -7,7 +7,7 @@ import * as store from './sessions.mjs';
|
||||
// browser and relays bytes here without reading them.
|
||||
//
|
||||
// The socket protocol is the one the browser already speaks, unchanged: {input,resize} in,
|
||||
// {output,replay,exit,panel-refresh} out. That is deliberate — the frontend did not have to move for the
|
||||
// {output,replay,exit} out. That is deliberate — the frontend did not have to move for the
|
||||
// transport to.
|
||||
|
||||
const wsSend = (socket) => ({
|
||||
@@ -37,12 +37,6 @@ export function startServer() {
|
||||
return json(res, killed ? 200 : 404, { ok: killed });
|
||||
}
|
||||
|
||||
// The claude-done hook: tell attached terminals to refresh their panel.
|
||||
if (url.pathname === '/_officer/panel-refresh' && req.method === 'POST') {
|
||||
store.broadcastPanelRefresh();
|
||||
return json(res, 200, { ok: true });
|
||||
}
|
||||
|
||||
json(res, 404, { error: 'not found' });
|
||||
});
|
||||
|
||||
|
||||
@@ -170,11 +170,6 @@ export function list() {
|
||||
}));
|
||||
}
|
||||
|
||||
/** Tell every attached client to refresh its panel — fired by the platform's claude-done hook. */
|
||||
export function broadcastPanelRefresh() {
|
||||
for (const session of sessions.values()) broadcast(session, { type: 'panel-refresh' });
|
||||
}
|
||||
|
||||
export function killAll() {
|
||||
for (const session of sessions.values()) {
|
||||
try {
|
||||
|
||||
Reference in New Issue
Block a user