a session remembers which model it is using

resume a conversation and the model picker showed the first entry in the catalogue instead of the model the
session was actually on. that was invisible for as long as the first entry was `opus`, and became obvious
the day `fable` went above it — so this is a pre-existing bug my model-list change exposed, not one it
introduced.

two defects, stacked.

the value did not survive a refresh: `initialModel` came from `props.model ?? locationState?.model`, and
both are volatile — a panel channel and react-router location state. on a hard load neither exists, the
settings default is skipped (it only runs for NEW chats), and ModelSelector's fallback effect fired
`onModelChange(providerModels[0].id)`.

and even when it did arrive it could not match. a transcript records the API model; the picker offers CLI
aliases. `claude-opus-5` is in a different id space from `claude-code/opus[1m]`, and the mapping is one-way:
opus and opus[1m] both serve claude-opus-5, opusplan serves whichever model answered. read out of a real
59MB transcript, the distinct values were claude-opus-5, <synthetic>, claude-sonnet-5,
claude-haiku-4-5-20251001, claude-fable-5 — note the synthetic marker and the inconsistent date suffix.

so the transcript cannot answer "what should the picker show", and a new table does:

  chat_session_models (session_id pk, model, updated_at)

officer's own id space, so opus[1m] and opusplan round-trip. keyed on the TRANSCRIPT uuid rather than
officer's session id, because that is what the session list joins on — which is why the write waits for the
harness to announce the id rather than firing at turn start. records the EFFECTIVE model, so a refused
switch stores what answered.

not derived from chat_session_events, which does now hold model:switched: right data, wrong index. that
table holds every assistant message and is unbounded, and "latest model for these 200 sessions" would scan
far more than the question deserves. not a chat_sessions table either — a session IS its transcript, and a
row holding title and cwd would be a second source of truth for two fields that already have one.

BACKFILL RUNS FROM postdb:push, so every server picks it up on its next schema push. bun does fire pre/post
hooks for colon-named scripts — verified on 1.3.14 before building on it, because a post hook that silently
never runs is the worst outcome here. insert-only, exits 0 on every failure path (the push has already
applied; a cosmetic backfill must not make it look failed). seeded 11 of 12 transcripts on this machine.

it reads the FIRST model, which sounds wrong for a table storing the current one — but switching only
became possible today, so no older transcript can hold two, and first costs a bounded head read instead of
reading 59MB.

also: the family map returns null for mythos rather than a neighbouring family (Project Glasswing only — a
picker entry that 401s is worse than none), and ModelSelector no longer picks a default once a conversation
has started. an unset picker is the honest state when the server cannot say.

tests: the alias map against the five real transcript values, and the selector's default gated on
hasStarted. re-broke the guard to confirm it bites.

still to do: `model` on the session LIST rows, which the sessions-list revamp wants. the storage and the
batched read (getChatSessionModels) are in place for it.
This commit is contained in:
2026-08-17 17:03:19 +00:00
parent 57bbcca9ae
commit 813bc200bf
16 changed files with 489 additions and 5 deletions
+44
View File
@@ -12,6 +12,7 @@ import {
type AsUser,
} from '../../read-as-user';
import { runAsArgv } from '../../os-user';
import { isRealModel } from './model-aliases';
// ── Claude session store (source of truth) ──
// The `claude` CLI persists every session as a JSONL transcript at
@@ -858,6 +859,49 @@ function firstCwd(osUser: AsUser, filePath: string): string {
export type ClaudePwd = { cwd: string; sessionCount: number; updatedAt: string; isDefault: boolean };
/** All working directories that have Claude sessions, plus the caller's home. Newest first. */
/**
* Every transcript this identity owns, with the first real model it recorded.
*
* For the `chat_session_models` backfill (`scripts/backfill-session-models.ts`) — the one caller that wants
* a model per session across the WHOLE tree rather than for one directory.
*
* ── Why the FIRST model is the right one to read ──
*
* Sounds wrong: the table stores the model a session is *currently* using, so the last should win. But
* changing model mid-conversation only became possible on 2026-08-17, so no transcript written before that
* can contain more than one. First and last are the same value for every session this backfill will ever
* see, and reading the first costs a bounded head read instead of a full one — which matters, because the
* transcripts on this machine run to 59MB.
*
* Any session that takes a real turn afterwards overwrites the guess with the exact alias, `[1m]` and all.
* A future re-run of the backfill cannot regress that: `seedMissingChatSessionModels` only inserts.
*
* `<synthetic>` is skipped — it is Claude Code's marker for its own generated entries, not a model.
*/
export function listTranscriptModels(who: ChatIdentity): { sessionId: string; apiModel: string }[] {
const projectsDir = claudeProjectsDir(who.home);
const out: { sessionId: string; apiModel: string }[] = [];
for (const file of listTranscriptsAs(who.osUser, projectsDir)) {
const path = join(projectsDir, file.slug, `${file.id}.jsonl`);
let head: string;
try {
// 64KB rather than the 32KB `firstCwd` uses: `cwd` is on the very first entry, while the first
// ASSISTANT entry (the only kind that carries a model) sits after the user's opening message, which
// can be long. A miss here costs one absent row, not a wrong one.
head = readHeadAs(who.osUser, path, 65536);
} catch {
continue; // Unreadable transcript. One missing row, and the next turn fills it in.
}
// Scan for the first `"model":"…"` that is not the synthetic marker. Regex rather than JSON.parse per
// line because the head read almost certainly ends mid-line.
const apiModel = [...head.matchAll(/"model":"([^"]+)"/g)].map((m) => m[1]!).find(isRealModel);
if (apiModel) out.push({ sessionId: file.id, apiModel });
}
return out;
}
export function listClaudePwds(who: ChatIdentity): ClaudePwd[] {
const projectsDir = claudeProjectsDir(who.home);
const defaultCwd = who.home;