From 71dfd394c38c3b22f1d54cb817de07ab166ba085 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Padez?= Date: Thu, 23 Jul 2026 13:35:45 +0000 Subject: [PATCH] subtitles default to all-unchecked; connect the keep-checkbox label Co-Authored-By: Claude Opus 4.8 --- .../components/TaskRunnerModal.tsx | 34 +++++++++++-------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/src/workspaces/officerdev/src/apps/FileBrowser/FileBrowserApp/components/TaskRunnerModal.tsx b/src/workspaces/officerdev/src/apps/FileBrowser/FileBrowserApp/components/TaskRunnerModal.tsx index 62aeda4c..4691de1b 100644 --- a/src/workspaces/officerdev/src/apps/FileBrowser/FileBrowserApp/components/TaskRunnerModal.tsx +++ b/src/workspaces/officerdev/src/apps/FileBrowser/FileBrowserApp/components/TaskRunnerModal.tsx @@ -318,15 +318,17 @@ const TaskInputForm = ({ inputDefs, values, onChange, autoFilledKeys, audioTrack const e = entryFor(t); return (
- update(t.id, { keep: !e.keep })} - className="accent-duck-teal cursor-pointer shrink-0" - /> - - {t.lang || 'und'} - + | null): PickerKinds => }); const defaultGroupSel = (g: FolderTrackGroup): GroupSel => ({ - audio: g.audioTracks.map((t) => t.id).join(','), // keep all - subs: g.subtitleTracks.map((t) => t.id).join(','), // keep all - subEdit: g.subtitleTracks.map((t) => ({ id: t.id, keep: true, label: trackLabel(t) })), + audio: g.audioTracks.map((t) => t.id).join(','), // audio: keep all + subs: 'none', // subtitles: keep none by default — you usually want only a few of many + subEdit: g.subtitleTracks.map((t) => ({ id: t.id, keep: false, label: trackLabel(t) })), }); // Does a group's selection change anything vs keep-all + original labels? @@ -693,8 +695,10 @@ const PerGroupTrackConfig = ({ groups, has, sel, onChange, probing }: PerGroupTr const e = entryFor(t); return (
- updateEdit(t.id, { keep: !e.keep })} className="accent-duck-teal cursor-pointer shrink-0" /> - {t.lang || 'und'} + t.id).join(',') || 'none'; if (def.type === 'subtitle_tracks') next[key] = 'none'; if (def.type === 'subtitle_edit') - next[key] = JSON.stringify(sub.map((t) => ({ id: t.id, keep: true, label: trackLabel(t) }))); + next[key] = JSON.stringify(sub.map((t) => ({ id: t.id, keep: false, label: trackLabel(t) }))); } return next; });