make machine-setup.sh and officer-setup.sh actually run on macOS

Both scripts had real macOS branches already — MACOS_SKIP, Xcode CLT, Docker Desktop
detection — but neither had ever run past its own library load on a real Mac, and
verifying that live is what this commit is. This machine is the Mac.

The root cause was the interpreter, not missing OS coverage: macOS's stock /bin/bash is
3.2.57 (Apple stopped shipping newer once bash went GPLv3) and this machine has no newer
one installed. Both scripts used bash 4+/4.3+ syntax with zero version guard, so a real
run died in seconds — declare -A (base.sh, associative array), local -n (packages.sh,
nameref), mapfile (5 sites), ${var,,} (both scripts' own step() — confirmed --only killed
the ENTIRE run), and machine-setup.sh's own pre-flight hard-refused brew outright ("this
script does not implement yet") even once the bash-4 crash was fixed. Each got rewritten
to its bash-3.2-safe equivalent rather than requiring a newer bash and re-executing under
it — nine call sites, a bounded fix, and one less thing that can go wrong before the
script can report what's wrong.

Past that gate, a live probe run (real account/path prompts, killed before Database/
Services could touch this machine's actual state) reproduced a second bug in the first
few seconds: resolve_user_home used getent (Linux/glibc, absent on macOS) with a
hardcoded /home/<user> fallback, so Layout tried `install -d /home/pastilhas` and failed
with "Operation not supported". Fixed with the portable `eval echo ~user` tilde-expansion
idiom, re-ran the same probe, and it correctly created /Users/pastilhas/officerdev/ and
started a real git clone.

Everything else follows the same shape — an unguarded Linux-only tool with a portable or
brew-based macOS equivalent:

  - grep -oP (4 sites: both --list flags, env.sh's tailnet lookup, build.sh's schema
    table count) — BSD grep has no -P at all. Portable ERE+sed where regex was enough;
    jq where the input was already JSON (tailnet lookup) — jq is already an unconditional
    dependency elsewhere in this script, so that's a correctness fix, not just a port.
  - ss (postgres.sh, proxy.sh — is anything listening on this port, and is it bound wide
    enough for NPM's container to reach) — both silently mis-reported on macOS, since the
    "command not found" was swallowed by 2>/dev/null and read as "nothing's listening".
    New shared `listening_addrs()` in officer-setup's base.sh, branching to lsof.
  - getent hosts (proxy.sh's DNS-wait loop) — same silent-failure shape, would have spun
    its full 30-minute timeout regardless of whether the record actually resolved. macOS
    branch uses dscacheutil.
  - stat -c (layout.sh's ownership check) — BSD stat has no -c, confirmed live ("illegal
    option -- c"), and the failure was VISIBLE and made every layout directory report as
    wrong-owner. Portable file_owner() tries -c then falls back to -f %Su.
  - apt-only Postgres client, NodeSource's Debian-only setup script, lazydocker/lazygit's
    installers (one literally named install_update_linux.sh, the other hardcoding
    "_Linux_" into the release asset URL) — each gets a brew branch, formula names
    verified against the live Homebrew catalog rather than assumed.
  - sudo -u "$USERNAME" to become the SAME account the process already is — real on
    Linux, where this whole script runs as root and dropping to the owner needs no
    password; on macOS the process never escalates in the first place, so re-invoking
    sudo for yourself asks for a real password on every call, or fails outright without
    sudo rights. machine-setup's dev.sh had ~10 inline call sites (git, bun, deno, claude,
    opencode, editor detection) rerouted through a new shared run_as_owner(); officer-
    setup's own as_owner() (already the shared entry point there) got the same branch,
    and six direct sudo call sites in build.sh/secrets.sh/services.sh that bypassed it
    were rerouted through it too.

Three things stay Linux-only rather than getting an unverified macOS implementation,
each skipped with a stated reason at the point it would otherwise run: pm2's boot-
persistence hook (needs a launchd plist generated and loaded, not a systemd unit
printed and eval'd — real, separate work), the Tailscale exit-node NIC/sysctl tuning
(no macOS equivalent concept, and advertising a laptop as an exit node is already the
edge case MACOS_SKIP treats it as), and ufw's bridge-to-host firewall rule (pf is a
different rule language entirely, and Docker Desktop's own VM-based networking may not
even have the problem this rule exists to solve — guessing at a firewall rule felt like
the wrong place to be wrong).

Verified: both --list flags print step names instead of a grep usage error. A bounded
officer-setup.sh run (killed before Database) resolved the real macOS home directory,
created the layout with correct ownership, and began a real git clone — cleaned up
after (rm -rf the test directory, the gitignored .setup-progress file, the stray
install-report). machine-setup.sh's pre-flight now reports "Packages: brew" and reaches
the account/path prompts instead of refusing the OS outright. bash -n clean on all 16
files under bash 3.2, the actual interpreter these scripts run under on a Mac.

Not run further live: Database, Secrets, Services and Proxy would mutate this machine's
real state (a live Postgres, a live set of pm2 processes this session runs through) and
were left for a deliberate, supervised run rather than folded into validation.
This commit is contained in:
2026-08-26 21:10:08 +01:00
parent 7e6cfc85af
commit 681df1c8bc
16 changed files with 337 additions and 70 deletions
+40 -2
View File
@@ -47,10 +47,16 @@ fail() {
ONLY_STEP="${ONLY_STEP:-}"
# `${var,,}` (case-insensitive --only compare below) is bash 4+. macOS's stock /bin/bash is
# 3.2 — confirmed live: "bad substitution" — and under this script's `set -e` that means
# `--only <step>` killed the ENTIRE run on macOS, not just the comparison. This is the
# portable pre-4 substitute.
lower() { tr '[:upper:]' '[:lower:]' <<<"$1"; }
step() {
CURRENT_STEP="$1"
if [[ -n "$ONLY_STEP" ]]; then
if [[ "${1,,}" == "${ONLY_STEP,,}" ]]; then
if [[ "$(lower "$1")" == "$(lower "$ONLY_STEP")" ]]; then
SKIP_STEP=false
echo ""
echo -e "${BOLD}── $1 ──${NC}"
@@ -134,7 +140,39 @@ ask_required() {
user_group() { id -gn "${1:-$USERNAME}" 2>/dev/null || echo "${1:-$USERNAME}"; }
# The bound address(es) of whatever is LISTENing on a TCP port — one per line, formatted
# like `127.0.0.1:5432` or `*:5432`. Used both to ask "is anything on this port at all" and
# "is it bound wide enough for a container to reach" (Postgres and the Proxy section ask
# opposite versions of that question).
#
# `ss` (iproute2) is Linux-only — no equivalent ships with it on macOS. `lsof` is the
# portable answer: present on every macOS install by default, and common enough on Linux
# (already a REQUIRED_TOOL nowhere here, so this still prefers `ss` there since that is the
# surface this was written and tested against) that branching by OS rather than picking one
# tool for both keeps each path exactly as capable as it always was.
listening_addrs() {
local port="$1"
if [[ "$(uname -s)" == "Darwin" ]]; then
lsof -nP -iTCP -sTCP:LISTEN 2>/dev/null | awk -v p=":${port}\$" '$9 ~ p {print $9}'
else
ss -ltn 2>/dev/null | awk -v p=":${port}\$" '$4 ~ p {print $4}'
fi
}
# Run something as the account that owns the install. Officer's files, its
# node_modules and its pm2 process list all belong to that account, not to root —
# a repository cloned as root is one the owner cannot pull.
as_owner() { (cd "${2:-/}" && sudo -H -u "$USERNAME" bash -c "$1"); }
#
# On Linux this script runs as root (that's the whole point of sudo -H -u here: dropping
# from root down to the owning account). On macOS it never escalates — officer-setup.sh
# refuses to even start under sudo there, "the account running this IS the owner" — so the
# process already IS $USERNAME, and re-invoking sudo for the SAME account asks for a real
# password on every single call (Dependencies, Schema, Build, Secrets, Services, Repository
# all go through this) or fails outright without sudo rights at all.
as_owner() {
if [[ "$(uname -s)" == "Darwin" ]]; then
(cd "${2:-/}" && bash -c "$1")
else
(cd "${2:-/}" && sudo -H -u "$USERNAME" bash -c "$1")
fi
}
+8 -3
View File
@@ -24,15 +24,20 @@ OFFICER_SETUP_BUILD_LOADED=1
# attached. drizzle-kit then fails instead of waiting, which is the outcome you
# want at 3am.
push_schema() {
sudo -u "$USERNAME" bash -c "cd '$(platform_dir)' && bun db:push </dev/null" 2>&1
as_owner "cd '$(platform_dir)' && bun db:push </dev/null" 2>&1
}
# What tables the schema will create, read from the aggregator rather than
# guessed. This is what makes the section able to say what it is about to do.
#
# Portable ERE + sed rather than GNU grep's -P/lookbehind: BSD grep on macOS has no -P at
# all (confirmed live — errors immediately), and its 2>/dev/null here would have hidden that
# and reported "0 tables" on every macOS run instead, cosmetic but silently wrong.
schema_table_count() {
local dir
dir="$(platform_dir)/src/databases/officer_db/src"
grep -oP "^export \* from '\./\K[\w-]+(?=/schema')" "$dir/schema.ts" 2>/dev/null | while read -r f; do
grep -E "^export \* from '\./" "$dir/schema.ts" 2>/dev/null |
sed -E "s/^export \* from '\.\/([A-Za-z0-9_-]+)\/schema'.*/\1/" | while read -r f; do
grep -c "pgTable(" "$dir/$f/schema.ts" 2>/dev/null || true
done | awk '{s+=$1} END {print s+0}'
}
@@ -43,7 +48,7 @@ schema_table_count() {
# Not optional and not cosmetic: without it the server has no page to serve. It
# is gitignored, so a fresh clone never has one.
gen_index() {
sudo -u "$USERNAME" bash -c "cd '$(platform_dir)' && bun gen:index '$ENV_PUBLIC_URL'" 2>&1
as_owner "cd '$(platform_dir)' && bun gen:index '$ENV_PUBLIC_URL'" 2>&1
}
gen_index_output() { echo "$(platform_dir)/src/apps/officer-web/index.gen.html"; }
+6 -1
View File
@@ -111,7 +111,12 @@ ENVF
# is any better a guess.
tailnet_hostname() {
local dns ip
dns="$(tailscale status --json 2>/dev/null | grep -oP '"DNSName":\s*"\K[^"]+' | head -1)"
# jq over grep -oP: this output is real JSON, and GNU grep's -P/\K doesn't exist on BSD
# grep at all (confirmed live — errors visibly), which used to leak straight to the
# terminal since only the `tailscale` call's stderr was suppressed, not the grep's. jq is
# already an unconditional dependency elsewhere in this script (proxy.sh), so this is
# strictly a correctness improvement even setting the portability problem aside.
dns="$(tailscale status --json 2>/dev/null | jq -r '.Self.DNSName // empty')"
dns="${dns%.}" # MagicDNS reports it fully qualified, with a trailing dot
dns="${dns%%.*}" # and we want the short name
if [[ -n "$dns" ]]; then
+8 -1
View File
@@ -39,6 +39,13 @@ layout_dirs() {
echo "$(layout_items_dir)"
}
# A file's owning username, portably: GNU stat (Linux) takes `-c %U`, BSD stat (macOS) has
# no `-c` at all and wants `-f %Su` instead — confirmed live, GNU form exits
# "illegal option -- c" under macOS's stat. Try GNU first since that is the common case,
# fall back to BSD rather than branching on an OS variable this file does not otherwise
# track.
file_owner() { stat -c %U "$1" 2>/dev/null || stat -f %Su "$1"; }
# Created owned by the account, because everything that writes into them runs as
# the account: the platform under pm2, the app store's compose files, the item
# store the agent authors into.
@@ -58,7 +65,7 @@ layout_wrong_owner() {
local dir
while read -r dir; do
[[ -d "$dir" ]] || continue
[[ "$(stat -c %U "$dir")" == "$USERNAME" ]] || echo "$dir"
[[ "$(file_owner "$dir")" == "$USERNAME" ]] || echo "$dir"
done < <(layout_dirs)
}
+50 -2
View File
@@ -62,7 +62,7 @@ pg_client_installed() {
# entry, no add-apt-repository. Non-fatal — an install without psql is a working platform,
# just a more annoying one to operate.
install_pg_client() {
local major codename
local major
major="$(pg_client_major)"
[[ -n "$major" ]] || {
warn "could not read a major version out of PG_IMAGE=${PG_IMAGE} — skipping the client"
@@ -74,6 +74,49 @@ install_pg_client() {
return 0
fi
if [[ "$(uname -s)" == "Darwin" ]]; then
install_pg_client_macos "$major"
return $?
fi
install_pg_client_linux "$major"
}
# Homebrew's `postgresql@<major>` matches the apt path's own logic: the version has to agree
# with the server's, not just be "a psql". It is keg-only — Homebrew never links more than one
# Postgres onto PATH by default, because a dev machine plausibly has several majors installed
# for different projects — so `brew install` alone does not make `psql` resolve. Symlinking
# only the four client binaries this platform actually uses, rather than `brew link --force`ing
# the whole keg, is the same caveat Homebrew's own postgresql formula prints; force-linking
# would silently steal `psql` from whatever other major was linked before this ran.
install_pg_client_macos() {
local major="$1" prefix
command -v brew &>/dev/null || {
warn "Homebrew is not installed — cannot install postgresql@${major}. Run machine-setup.sh first."
return 1
}
prefix="$(brew --prefix)"
brew install "postgresql@${major}" &>/dev/null || {
warn "brew install postgresql@${major} failed"
return 1
}
local bin
for bin in psql pg_dump pg_dumpall pg_restore; do
[[ -x "${prefix}/opt/postgresql@${major}/bin/${bin}" ]] || continue
ln -sf "${prefix}/opt/postgresql@${major}/bin/${bin}" "${prefix}/bin/${bin}"
done
pg_client_installed || {
warn "psql is not version ${major} after installing — check: brew list postgresql@${major}"
return 1
}
ok "psql $(psql --version | grep -oE '[0-9]+\.[0-9]+' | head -1) installed via Homebrew"
}
install_pg_client_linux() {
local major="$1" codename
codename="$(. /etc/os-release && echo "${VERSION_CODENAME:-}")"
[[ -n "$codename" ]] || {
warn "could not work out this release's codename — cannot add the PostgreSQL repository"
@@ -121,7 +164,12 @@ pg_container_running() { docker ps --filter "name=^${PG_CONTAINER}$" --format '{
# Is something already answering on the port? A Postgres the user runs their own
# way is a perfectly good answer, and finding out by failing to bind is not.
pg_port_in_use() { ss -ltn 2>/dev/null | grep -qE "127\.0\.0\.1:${PG_PORT}\b|\*:${PG_PORT}\b|0\.0\.0\.0:${PG_PORT}\b"; }
#
# `ss` is Linux-only; `listening_addrs` (lib/base.sh) is the portable version, branching to
# `lsof` on macOS. Confirmed empirically to fail silently the old way: `ss` doesn't exist on
# macOS, its "command not found" was swallowed by `2>/dev/null`, and an empty grep result
# reported the port as free even when something WAS listening.
pg_port_in_use() { [[ -n "$(listening_addrs "$PG_PORT")" ]]; }
# Bound to loopback, deliberately, and the reason is worth keeping next to the
# line it explains.
+13 -1
View File
@@ -69,7 +69,19 @@ tool_why() {
# The account has to exist before anything is written to its home.
owner_exists() { id "$USERNAME" &>/dev/null; }
# `getent` is Linux/glibc — not present on stock macOS at all (confirmed: "command not
# found" on a real machine; it only appeared to work in earlier testing because this dev
# session's shell profile shims it, which a fresh install does not have). Reproduced live:
# this returned the WRONG, hardcoded `/home/<user>` fallback on a real macOS run just now,
# and `install -d` then failed on it outright ("Operation not supported") since /home isn't
# a real, writable path on macOS.
#
# `eval echo ~"$USERNAME"` is the portable replacement — tilde expansion resolves through
# whatever the OS's own user database is (NSS on Linux, Directory Services on macOS)
# without naming either. A nonexistent user leaves the tilde word unexpanded (`~name`
# rather than a path), which is how the fallback below still triggers for that case.
resolve_user_home() {
USER_HOME="$(getent passwd "$USERNAME" 2>/dev/null | cut -d: -f6)"
USER_HOME="$(eval echo ~"$USERNAME" 2>/dev/null)"
[[ "$USER_HOME" == "~"* ]] && USER_HOME=""
[[ -n "$USER_HOME" ]] || USER_HOME="/home/${USERNAME}"
}
+34 -2
View File
@@ -58,7 +58,9 @@ proxy_ask() {
# reads like a firewall fault. So the bind ADDRESS is what gets checked.
proxy_require_listening() {
local port="$1" listen
listen="$(ss -ltnH "sport = :$port" 2>/dev/null | awk '{print $4}')"
# `ss` is Linux-only; `listening_addrs` (lib/base.sh) branches to `lsof` on macOS. Same
# silent-empty-result failure mode as postgres.sh's pg_port_in_use if this were left as-is.
listen="$(listening_addrs "$port" | head -1)"
[[ -n "$listen" ]] || {
warn "nothing is listening on port ${port} — start Officer first"
return 1
@@ -170,7 +172,15 @@ proxy_wait_for_dns() {
info "(Tailnet: the certificate can issue without this, but the name will not resolve until it exists.)"
while ((elapsed < timeout)); do
got="$(getent hosts "$domain" 2>/dev/null | awk '{print $1}' | head -1)"
# `getent` is glibc/Linux-only — absent on macOS (confirmed: "command not found" on a
# real machine), silently swallowed by 2>/dev/null, which would have spun this through
# its full 30-minute timeout regardless of whether the record actually resolved.
# `dscacheutil` is macOS's own equivalent, consulting the same system resolver.
if [[ "$(uname -s)" == "Darwin" ]]; then
got="$(dscacheutil -q host -a name "$domain" 2>/dev/null | awk '/^ip_address:/ {print $2; exit}')"
else
got="$(getent hosts "$domain" 2>/dev/null | awk '{print $1}' | head -1)"
fi
if [[ "$got" == "$want" ]]; then
ok "${domain} resolves to ${want}"
return 0
@@ -194,8 +204,18 @@ proxy_ensure_network() {
# NPM binds its admin UI to the tailnet IP. If docker starts before tailscaled that
# address does not exist yet and the WHOLE container fails to start, not just that port.
#
# Docker Desktop on macOS has no systemd unit to order — it is a GUI app the OS launches, not
# a service tailscaled could be declared a dependency of — and this account does not run as
# root there either, so `mkdir -p /etc/systemd/...` would fail on permissions rather than do
# something merely unnecessary. Same shape as machine-setup's MACOS_SKIP: skip with a reason
# rather than let a Linux-only action fail confusingly.
proxy_order_docker_after_tailscaled() {
[[ "$CHALLENGE" == "dns" ]] || return 0
if [[ "$(uname -s)" == "Darwin" ]]; then
ok "Docker Desktop has no systemd unit to order — skipping"
return 0
fi
local f=/etc/systemd/system/docker.service.d/10-after-tailscaled.conf
[[ -f "$f" ]] && return 0
mkdir -p "$(dirname "$f")"
@@ -378,8 +398,20 @@ proxy_get_token() {
# bypass ufw entirely. The symptom is a 504 that looks like a network fault. A container
# upstream would need none of this, which is why container upstreams are preferable when
# there is a choice.
# `ufw` is Debian/Ubuntu — no macOS equivalent through this interface (pf/pfctl is a
# different rule syntax entirely, and the Application Firewall machine-setup's own
# MACOS_SKIP already documents for "Firewall" is per-APP, not per-subnet/per-port). Skipped
# rather than guessed at: Docker Desktop for Mac also runs containers inside its own VM, so
# bridge-to-host traffic does not cross the real host firewall the same way it does when
# Docker runs directly on a Linux kernel — an unverified pf rule here could be solving a
# problem macOS's Docker networking model does not actually have.
proxy_allow_bridge_to_host() {
local port="$1" subnet
if [[ "$(uname -s)" == "Darwin" ]]; then
ok "no ufw on macOS — Docker Desktop's own networking model handles bridge-to-host, skipping"
BRIDGE_GATEWAY="$(docker network inspect "$PROXY_NET" -f '{{(index .IPAM.Config 0).Gateway}}')"
return 0
fi
subnet="$(docker network inspect "$PROXY_NET" -f '{{(index .IPAM.Config 0).Subnet}}')"
if ufw status 2>/dev/null | grep -q "${port}.*${subnet%%/*}"; then
ok "ufw already allows the bridge to reach port ${port}"
+1 -1
View File
@@ -35,7 +35,7 @@ bootstrap_secret_store() {
# From the repo, because the module derives the install root as the parent of
# the working directory — the same rule as src/servers/data-path.ts.
sudo -u "$USERNAME" bash -c "cd '$(platform_dir)' && bun --eval \"
as_owner "cd '$(platform_dir)' && bun --eval \"
const { getKey } = await import('officerdb/secret-store');
getKey('jwt');
\"" >/dev/null 2>&1 || return 1
+16 -4
View File
@@ -101,24 +101,36 @@ FOOTER
}
pm2_start() {
sudo -u "$USERNAME" bash -c "cd '$(platform_dir)' && pm2 startOrRestart '$(ecosystem_file)' --update-env" 2>&1
as_owner "cd '$(platform_dir)' && pm2 startOrRestart '$(ecosystem_file)' --update-env" 2>&1
}
pm2_save() { sudo -u "$USERNAME" pm2 save 2>&1; }
pm2_save() { as_owner "pm2 save" 2>&1; }
# Survive a reboot. `pm2 startup` PRINTS a command for root to run rather than
# doing it — so this runs what it prints, which is the whole point of already
# being root here.
#
# `systemd` is hardcoded because that IS the only path today — pm2's own "platform" argument
# has to be `launchd` on macOS instead, generating a LaunchAgent plist rather than a systemd
# unit, and running it is a separate mechanism (`launchctl load`, not "eval a printed sudo
# command"). That is real, separate work rather than a one-line swap, so this skips with a
# stated reason on macOS instead of pretending the systemd path could ever produce anything
# usable there — matches the same call this codebase already made for the Tailscale exit-node
# NIC tuning and the proxy's systemd docker-ordering fix.
pm2_enable_startup() {
if [[ "$(uname -s)" == "Darwin" ]]; then
warn "pm2 boot-persistence needs a launchd plist on macOS, not a systemd unit — not implemented yet"
return 1
fi
local cmd
cmd="$(sudo -u "$USERNAME" bash -c "cd '$(platform_dir)' && pm2 startup systemd -u '$USERNAME' --hp '$USER_HOME'" 2>/dev/null | grep -E '^sudo ' | tail -1)"
cmd="$(as_owner "cd '$(platform_dir)' && pm2 startup systemd -u '$USERNAME' --hp '$USER_HOME'" 2>/dev/null | grep -E '^sudo ' | tail -1)"
[[ -z "$cmd" ]] && return 1
eval "${cmd#sudo }"
}
# One line per process: name, status, restarts.
pm2_status_lines() {
sudo -u "$USERNAME" pm2 jlist 2>/dev/null |
as_owner "pm2 jlist" 2>/dev/null |
node -e '
let s = ""; process.stdin.on("data", (d) => (s += d)).on("end", () => {
let apps = []; try { apps = JSON.parse(s); } catch { }