From 577ebde902c7b226a036662d9ac278733e96f19b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Padez?= Date: Sat, 22 Aug 2026 18:30:37 +0000 Subject: [PATCH] the services section counts its processes instead of saying six MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CORE_PROCESSES grew to seven when caldav and notify became core on 2026-08-19, and five hardcoded "six"/"6 processes" claims around it did not move. Derived from the array now, so the next core process cannot re-create the drift. Same class of rot in preflight's tool_why, which still said bun runs "nineteen of the twenty processes" — a count from the pre-plugin era, replaced with a count-free sentence. Co-Authored-By: Claude Fable 5 --- scripts/setup/officer-setup.sh | 12 ++++++------ scripts/setup/officer-setup/lib/preflight.sh | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/setup/officer-setup.sh b/scripts/setup/officer-setup.sh index 5f299a8b..ae0f853e 100755 --- a/scripts/setup/officer-setup.sh +++ b/scripts/setup/officer-setup.sh @@ -760,7 +760,7 @@ if ! skip; then echo " The ecosystem file is GENERATED, not checked in. It describes this" echo " install and nothing else, so nothing in git can drift from it." echo "" - echo " six processes:" + echo " ${#CORE_PROCESSES[@]} processes:" for entry in "${CORE_PROCESSES[@]}"; do IFS='|' read -r _name _script _args <<<"$entry" printf " %-24s %s %s\n" "$_name" "$_script" "$_args" @@ -772,7 +772,7 @@ if ! skip; then if confirm "Write it and start them?"; then write_ecosystem ok "written — $(ecosystem_file)" - report_changed "wrote $(ecosystem_file) — six pm2 apps: $(printf '%s ' "${CORE_PROCESSES[@]%%|*}")" + report_changed "wrote $(ecosystem_file) — ${#CORE_PROCESSES[@]} pm2 apps: $(printf '%s ' "${CORE_PROCESSES[@]%%|*}")" # Starting against a database that is not answering is not fatal — the server # waits and the agent retries forever — but it makes the Verify section below @@ -792,13 +792,13 @@ if ! skip; then if pm2_enable_startup; then ok "pm2 will resurrect them at boot" report_ran "pm2 startup systemd — installed a systemd unit so pm2 resurrects these at boot" - SUMMARY+=("Services: 6 processes started, enabled at boot") + SUMMARY+=("Services: ${#CORE_PROCESSES[@]} processes started, enabled at boot") else warn "could not enable the boot hook — run 'pm2 startup' yourself and follow it" - SUMMARY+=("Services: 6 processes started; boot hook NOT enabled") + SUMMARY+=("Services: ${#CORE_PROCESSES[@]} processes started; boot hook NOT enabled") fi else - SUMMARY+=("Services: 6 processes started; not enabled at boot") + SUMMARY+=("Services: ${#CORE_PROCESSES[@]} processes started; not enabled at boot") fi else warn "pm2 did not start cleanly" @@ -945,7 +945,7 @@ fi # # Root, and that surprises people — reasonably, because everything this script just # installed belongs to somebody else. The platform runs as ${USERNAME}: the checkout, -# node_modules, .env, the secret store and all six pm2 processes are theirs. Root was +# node_modules, .env, the secret store and every pm2 process are theirs. Root was # the installer's privilege, never the platform's. # # Saying so matters for two things that are invisible until they bite: diff --git a/scripts/setup/officer-setup/lib/preflight.sh b/scripts/setup/officer-setup/lib/preflight.sh index 4f359ac6..d41b240a 100644 --- a/scripts/setup/officer-setup/lib/preflight.sh +++ b/scripts/setup/officer-setup/lib/preflight.sh @@ -59,7 +59,7 @@ tool_why() { case "$1" in git) echo "to clone and update the platform" ;; node) echo "pm2 runs on it, and the terminal sidecar builds node-pty against it" ;; - bun) echo "the platform itself and nineteen of the twenty processes" ;; + bun) echo "the platform itself and every process except the pty sidecar" ;; pm2) echo "supervises every process; the ecosystem files are written for it" ;; docker) echo "Postgres, and anything the app store provisions" ;; *) echo "" ;;