spotlight on ctrl+space, theme browser on ctrl+shift+up/down, no backdrop behind the theme list

2026-08-25 16:53:29 +00:00
parent 4a6e4a773c
commit 4efca226f6
9 changed files with 39 additions and 30 deletions
@@ -24,10 +24,10 @@ const {
 *
 * ── The overlay ──
 *
- * `ctrl+shift+space` opens a list in the middle of the screen; `j`/`k` move through it and `l` applies the
- * focused theme to the app BEHIND it. That is the whole idea, and it is why this is a portal over a
- * translucent backdrop rather than a modal dialog: you are meant to watch the application change while
- * you browse, so as little of it as possible should be covered.
+ * `ctrl+shift+↑/↓` opens a list in the middle of the screen; `j`/`k` move through it and `l` applies the
+ * focused theme to the app BEHIND it. That is the whole idea, and it is why this is a portal with no
+ * backdrop rather than a modal dialog: you are meant to watch the application change while you browse,
+ * so nothing of it should be covered.
 *
 * Ported from the owner's `vimazing`, keys and all.
 */
@@ -156,9 +156,9 @@ export const ThemeSwitcher = () => {
      {open &&
        createPortal(
          <div
+            // No backdrop at all — the whole point of the browse is watching the app change behind the
+            // list, so nothing may sit between them. The full-screen div stays for click-outside-to-close.
            className="fixed inset-0 z-[900] flex items-center justify-center"
-            // Deliberately light: the point is to see the app change behind it.
-            style={{ backgroundColor: 'color-mix(in srgb, var(--background) 55%, transparent)' }}
            onClick={() => setOpen(false)}
          >
            <div
@@ -218,18 +218,23 @@ export const Spotlight = () => {
  // anywhere — including inside a panel that has its own key handling.
  useEffect(() => {
    const onKey = (ev: KeyboardEvent) => {
-      // `code`, not `key`: shift+space reports `key: ' '` on most layouts and something else on a few, while
+      // `code`, not `key`: ctrl+space reports `key: ' '` on most layouts and something else on a few, while
      // the physical key is `Space` everywhere.
      //
-      // Every other modifier must be ABSENT. `ctrl+shift+space` is the theme browser, and one chord opening
-      // both is the bug that took a capture-phase listener to fix on the theme side.
+      // Every other modifier must be ABSENT. `ctrl+shift+space` and `ctrl+alt+space` are the theme
+      // browser, and one chord opening both is the bug that took a capture-phase listener to fix on the
+      // theme side.
+      //
+      // Was shift+space until 2026-08-25: typing fires shift+space constantly (any capitalized word
+      // followed by a space), so the launcher kept popping open mid-sentence. Ctrl+space doesn't happen in
+      // normal typing.
      //
      // No focus check. There was one, inherited from shift-space where it was mandatory, and keeping it
      // "as belt-and-braces" was wrong in the plainest way: focus is usually IN the chat composer, so the
      // guard meant the launcher did not open from the place it is most often wanted. `preventDefault`
      // below covers the only thing the guard was protecting against — a layout that would otherwise type
      // a character.
-      if (ev.shiftKey && !ev.ctrlKey && !ev.altKey && !ev.metaKey && ev.code === 'Space') {
+      if (ev.ctrlKey && !ev.shiftKey && !ev.altKey && !ev.metaKey && ev.code === 'Space') {
        ev.preventDefault();
        // Take focus off whatever had it, explicitly, before the overlay mounts. The effect below focuses
        // this panel's own input, and on paper that is enough — but "on paper" is what produced arrow keys