the constraint goes on the grid child, not inside it
The previous fix put `min-w-0` on the scroll container, which was one level too low to stop anything. DialogContent is a grid; the element that expands is its DIRECT child, and between the two sat a `flex flex-col gap-3` wrapper with no constraint at all. It grew to fit the title and took the card out of the dialog with it, exactly as before. Found by mapping the element chain from DialogContent down rather than reasoning about which element "should" be the one — the wrapper does not appear in any of the code you read while thinking about the card, which is why two attempts missed it. Also confirmed the previous fix was genuinely live before blaming it: the served chunk on fofos carried the new class and not the old one. The code was right and the diagnosis was wrong. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
+5
-1
@@ -213,7 +213,11 @@ export const VideoDownloadDialog = ({ fileBrowserManager }: VideoDownloadDialogP
|
|||||||
</div>
|
</div>
|
||||||
</form>
|
</form>
|
||||||
) : (
|
) : (
|
||||||
<div className="flex flex-col gap-3">
|
// `min-w-0` on the DIRECT grid child. DialogContent is a grid, and a grid item defaults to
|
||||||
|
// `min-width: auto` — so this is the element that grows to fit a long title and takes the
|
||||||
|
// card out of the dialog with it. The constraint has to be here; on the scroll container
|
||||||
|
// inside it was one level too low to stop anything.
|
||||||
|
<div className="flex min-w-0 flex-col gap-3">
|
||||||
<div className="flex items-center justify-between gap-2">
|
<div className="flex items-center justify-between gap-2">
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
|
|||||||
Reference in New Issue
Block a user