close the request-body todo: the proxy claims only what it forwards
This commit is contained in:
@@ -2,7 +2,7 @@
|
|||||||
id: plugin-infrastructure/a-plugin-s-own-routes-lose-their-request-body
|
id: plugin-infrastructure/a-plugin-s-own-routes-lose-their-request-body
|
||||||
title: "A plugin that has a sidecar proxy loses the request body on its OWN routes"
|
title: "A plugin that has a sidecar proxy loses the request body on its OWN routes"
|
||||||
theme: plugin-infrastructure
|
theme: plugin-infrastructure
|
||||||
status: open
|
status: done
|
||||||
created: 2026-08-27
|
created: 2026-08-27
|
||||||
date_source: stated
|
date_source: stated
|
||||||
order: 9
|
order: 9
|
||||||
@@ -36,3 +36,11 @@ diagnosed while a phone was waiting. **The caldav plugin works around it locally
|
|||||||
which is most of them. They have not hit it because their own routes are GETs, or because their writes go
|
which is most of them. They have not hit it because their own routes are GETs, or because their writes go
|
||||||
to the sidecar. A plugin adding its first non-proxied POST will hit it, and the symptom — a required
|
to the sidecar. A plugin adding its first non-proxied POST will hit it, and the symptom — a required
|
||||||
field reported missing on a request that plainly has it — points at the caller rather than at this.
|
field reported missing on a request that plainly has it — points at the caller rather than at this.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
**Done 2026-08-27** (`f00abe81` in the platform, and caldav's own repo). `createSidecarProxy` takes
|
||||||
|
`proxiedSubPath`, so a proxy claims only what it forwards — caldav claims `/api/caldav/_officer` and its
|
||||||
|
own routes are parsed normally. Omitted still means the whole prefix, so no other plugin changed.
|
||||||
|
Caldav's local `jsonBody()` workaround is gone. Verified: a POST to the plugin's own route read its body,
|
||||||
|
and the proxied namespace still reaches the sidecar.
|
||||||
|
|||||||
Reference in New Issue
Block a user