officerdev/platform
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

a deleted commander stays deleted, and the header shows its name

Browse Source 
two things that should have been settled already.

commanders/46 came back as an empty directory after a clean delete. not a
surviving loop — nothing from 46 was running. resolveChatCwd did
`mkdirSync(dir, {recursive:true})` on every commander turn, so one
in-flight turn from the conversation that outlived the row recreated it.
an empty directory is worse than none: a commander with no CLAUDE.md that
knows nothing about itself, showing up in the file browser as something
that still exists.

the directory is created by POST /command-hq/commanders before any turn
spawns, so a missing one means deleted. no mkdir here — fall back to the
home and say so, the same degradation the missing-row branch already
reports.

and the detail header showed the harness's own summary title, which it
makes from the first prompt: "You have been named "Voice Memos". Look in
`/home/…`", on a commander whose name was correct everywhere else. the list
route already prefers row.name. this now does too.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Officer-Session: 656f5c85-e49a-4f1f-b9f3-042a04b4d043
This commit is contained in:
pastilhas
2026-08-25 07:21:11 +00:00
co-authored by Claude Opus 5
parent f16aa87d8b
commit 22a9d58d5c
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/api/chat/websocket.ts
+20 -3
View File
@@ -39,7 +39,7 @@ import {
import { resolveHomeDir } from '@@/user-home';
import { renameClaudeSession, type ChatIdentity } from './claude-sessions';
import { claudeLoginState } from '@@/os-user-claude';
import { mkdirSync } from 'node:fs';
import { mkdirSync, existsSync } from 'node:fs';
import { logger } from './logger';
import { isSuperAdmin } from '@@/super-admin';
import { snapshotClaudeUsage } from './usage-store';
@@ -201,8 +201,25 @@ async function resolveChatCwd(
`[command-hq] no commander row for ${msg.commanderId !== undefined ? `id ${msg.commanderId}` : `session ${msg.resumeSessionId ?? '(none given)'}`} — falling back to the account home`,
);
}
const dir = row ? getCommanderDir(email, row.dirName) : home;
mkdirSync(dir, { recursive: true });
if (!row) return home;
/*
The directory must already exist. `POST /command-hq/commanders` creates it with its `CLAUDE.md`
before any turn spawns, so a missing one means the commander was DELETED — and a late turn from the
conversation that outlived it would otherwise recreate it here.
That happened: an empty `commanders/46` reappeared after a clean delete, from one in-flight turn
calling this. An empty directory is worse than none, because it is a commander with no CLAUDE.md
that knows nothing about itself, and it shows up in the file browser as something that still exists.
So: no mkdir. Fall back to the home, and say so — the same degradation the missing-row branch above
reports, for the same reason.
*/
const dir = getCommanderDir(email, row.dirName);
if (!existsSync(dir)) {
console.warn(`[command-hq] ${row.dirName}: directory is gone — deleted mid-turn? Falling back to the home.`);
return home;
}
return dir;
}
if (msg.context === 'email') return resolveEmailCwd(email, msg.contextId);