themes are installable, like plugins

`platform/themes/<id>/` — untracked, same rule as `plugins/`, only the instructions
tracked. Drop a directory in and the theme appears in the picker on the next page load.

  themes/my-theme/theme.css     required — `[data-theme='my-theme'] { … }`
  themes/my-theme/theme.json    required — { name, family, dark }
  themes/my-theme/assets/       optional — wallpaper, logo

── Why this is cheaper than installing a plugin ──

A plugin is code: it needs a manifest module, mounting, and a frontend rebuild to reach
the bundler. A theme is a block of CSS custom properties, so it needs none of that. The
server reads the directory at request time and the client adds a `<link>`. No install
step, no rebuild, no restart — which is the whole reason this is eighty lines of
discovery rather than four hundred.

The id is the DIRECTORY NAME, not a manifest field, for the same reason a plugin's
`appName` is not one: an id that can disagree with where its files sit eventually will.
Discovery checks that the CSS actually targets its own directory name, because the
failure is otherwise silent — the theme appears, is selected, and nothing changes.

── Problems are reported, not swallowed ──

A malformed theme returns a reason rather than vanishing:

  broken-probe: theme.css does not target [data-theme='broken-probe']

The client logs those, so an author has somewhere to look instead of wondering why
their theme never appeared.

── Boundaries kept ──

The `theme` package still performs no IO. It gained an `extraThemes` prop; Officer
fetches and injects, exactly as it supplies the panel registry to `workspaces`. A
failure to fetch is not an error — no server, no session, no directory all mean "you get
the built-in themes", which is a complete product.

`/api/themes` is a `core` capability: read-only, and not deniable, because an account
that cannot read the theme list renders unstyled. Installing remains a directory on
disk; an upload endpoint would be a way to write arbitrary CSS into the page from a
request.

Verified in-process: listing, the problem report, CSS served as text/css, and a
traversal attempt answered 404.

── Needs a restart ──

Server-side change. Until then the client's fetch 404s and silently keeps the built-ins,
so nothing breaks in the meantime.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-17 01:52:21 +00:00
co-authored by Claude Opus 5
parent 54f63b70df
commit 0d29e242a3
9 changed files with 425 additions and 16 deletions
+3 -3
View File
@@ -5,7 +5,7 @@ import { App } from './App';
import { seedAppRegistry, seedWidgetRegistry } from 'officerdev';
import { plugins } from './Plugins.gen';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { ColorModeProvider } from '@/components/ui/ThemeProvider';
import { InstalledThemes } from '@/state/InstalledThemes';
import { I18nBridge } from '@/lib/I18nBridge';
import { Toaster as Sonner } from 'sonner';
import { TooltipProvider } from '@/components/ui/tooltip';
@@ -32,14 +32,14 @@ const elem = document.getElementById('root')!;
const app = (
<StrictMode>
<QueryClientProvider client={queryClient}>
<ColorModeProvider>
<InstalledThemes>
<I18nBridge>
<TooltipProvider>
<Sonner position="top-center" toastOptions={{ style: { padding: '16px 20px', fontSize: '16px' } }} />
<App />
</TooltipProvider>
</I18nBridge>
</ColorModeProvider>
</InstalledThemes>
</QueryClientProvider>
</StrictMode>
);
@@ -0,0 +1,80 @@
import type { ReactNode } from 'react';
import { useEffect, useState } from 'react';
import { ThemeProvider, type Theme } from '@/components/ui/ThemeProvider';
/**
* Themes installed on this machine, folded in beside the ones this build ships.
*
* `platform/themes/<id>/` — untracked, like `plugins/` — holds a `theme.css` and a `theme.json`. This asks
* the server what is there, injects each stylesheet, and hands the list to the provider so they appear in
* the picker and under the keyboard shortcuts.
*
* ── Why no rebuild is needed ──
*
* A plugin is code and has to reach the bundler. A theme is a block of CSS custom properties, so it can be
* a `<link>` added at runtime — drop a directory in, reload, it is there. That difference is the whole
* reason installing a theme is cheaper than installing a plugin.
*
* ── Why the fetch lives here and not in the package ──
*
* The `theme` package performs no IO, for the same reason `workspaces` does not: it has to work for a host
* that has no server. Officer knows it has one, so Officer asks.
*
* A failure is not an error. No server, no session, no themes directory — all of them mean "you get the
* built-in themes", which is a complete product.
*/
type InstalledTheme = { id: string; name: string; family: string; dark: boolean };
const STYLESHEET_ID = (id: string) => `officer-theme-${id}`;
export const InstalledThemes = ({ children }: { children: ReactNode }) => {
const [installed, setInstalled] = useState<Theme[]>([]);
useEffect(() => {
let alive = true;
const load = async () => {
let payload: { themes?: InstalledTheme[]; problems?: { id: string; problem: string }[] };
try {
// The same token `useClient` uses. Read directly because this runs above the app's providers.
const token =
localStorage.getItem('PERTENTO_EDITOR_AUTH_TOKEN') ||
localStorage.getItem('BEARER_TOKEN') ||
sessionStorage.getItem('BEARER_TOKEN');
const headers: Record<string, string> = token ? { authorization: `Bearer ${token}` } : {};
const res = await fetch('/api/themes', { headers });
if (!res.ok) return;
payload = await res.json();
} catch {
return; // Offline, signed out, or no server. The built-ins are enough.
}
if (!alive || !payload.themes?.length) return;
// Loud about a theme that nearly works: a typo in theme.json otherwise just means it never appears,
// and the author has nowhere to look.
for (const p of payload.problems ?? []) {
console.warn(`[themes] ${p.id}: ${p.problem}`);
}
for (const theme of payload.themes) {
if (document.getElementById(STYLESHEET_ID(theme.id))) continue;
const link = document.createElement('link');
link.id = STYLESHEET_ID(theme.id);
link.rel = 'stylesheet';
link.href = `/api/themes/${theme.id}/theme.css`;
document.head.appendChild(link);
}
setInstalled(payload.themes.map((t) => ({ id: t.id, name: t.name, family: t.family, applyDarkClass: t.dark })));
};
void load();
return () => {
alive = false;
};
}, []);
return <ThemeProvider extraThemes={installed}>{children}</ThemeProvider>;
};