drop fastfetch from machine-setup

It stopped a real install. The guard covered the wrong half: a PPA that fails to ADD is caught and skipped, but one that adds cleanly while carrying no package for the running codename gets past that and dies on `pkg_install_now fastfetch`. It was also the only tool in the set with no source but a third-party PPA on Ubuntu 24.04 and older. A neofetch clone is not worth a branch in a script whose whole job is to survive machines nobody has seen. Removed from tools_default, the tool_command mapping and its installer. No shell config invoked it, so nothing is left calling a missing binary. software-properties-common stays in the core apt list for now, with a note: it provides add-apt-repository, the fastfetch PPA was its only caller, and Docker writes its own sources.list.d entry by hand — so it is now dead weight. Left as a separate decision rather than folded into this one. Verified: bash -n on all four scripts, and no live reference remains. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-14 05:46:59 +00:00
parent fb0286e1a9
commit 081920c61f
3 changed files with 22 additions and 26 deletions
@@ -183,9 +183,9 @@ fi
 save_answers

 # Always, and outside any step: everything below reads this index — core utils,
-# the fastfetch PPA, the Docker repo — and `step` skips a step whose name is
-# already in the progress file. With the refresh inside one of those, a resumed
-# run installed against whatever the index happened to say hours or days ago.
+# the Docker repo — and `step` skips a step whose name is already in the progress
+# file. With the refresh inside one of those, a resumed run installed against
+# whatever the index happened to say hours or days ago.
 echo ""
 info "Refreshing the package index..."
 pkg_refresh >/dev/null