per-user linux accounts are not optional any more

OFFICER_OS_USERS is gone. The platform behaves as it always would have with the
flag on, and there is nothing to enable.

Six conditionals, five of which were dead weight — provisionOsAccount,
deprovisionOsAccount and the create/delete paths each opened with an early
"not enabled on this server" return, and the API told the frontend whether to
render the Linux controls at all. Those go, along with the 'disabled'
DeprovisionResult stage, which nothing can produce now.

The sixth is the one with teeth. assertSecretsClosed opened with
`if (!OS_USERS_ENABLED) return`, described in its own comment as "a no-op when
the feature is off, so an existing install is unaffected until the owner opts
in". It is now unconditional: the server refuses to boot while any .env in the
project root is group- or world-readable. A member's shell reading .env and
printing JWT_SECRET was confirmed exploitable when this check was written, and a
prerequisite that only holds when somebody remembers to set a variable is not a
prerequisite.

Nothing to remove on the environment side — the flag was never in .env.example
or in the setup script.

Not typechecked: node_modules is empty in this tree and installs are frozen, so
tsgo could not run. All six files parse under `bun build --no-bundle`, and the
changes are deletions of dead branches plus one removed early return. Formatted
with prettier 3.9.6 via bunx rather than the pinned resolution, for the same
reason; its one unrelated reformat was reverted by hand.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

src/servers/api/users/create-user.ts

@@ -3,7 +3,6 @@ import { createUser, getUserByEmail, getUserByUsername, USER_ROLES } from 'offic
 import type { UserRole } from 'officerdb';
 import argon2 from 'argon2';
 import * as errors from '@@/custom-errors';
-import { OS_USERS_ENABLED } from '@@/os-user';
 import { validatePublicKey } from '@@/os-user-ssh';
 import { provisionOsAccount } from './provision-os';
 import { validatePassword } from '../auth/validate-password';
@@ -97,9 +96,7 @@ export const createUserHandler: Handler = async function (ctx) {
   //
   // Retryable in place afterwards via POST /users/:id/provision-linux, so a host that was not ready when the
   // account was made does not cost anybody their password and dashboards.
-  const os = OS_USERS_ENABLED
-    ? await provisionOsAccount({ userId: user.id, email, username, inboundKey })
-    : { osUser: null, sshPublicKey: null, error: null };
+  const os = await provisionOsAccount({ userId: user.id, email, username, inboundKey });
 
   if (os.error) console.warn(`[users] created ${email} but its Linux side did not finish: ${os.error}`);
 

src/servers/api/users/manage-users.ts

@@ -2,7 +2,6 @@ import type { Handler } from 'hono';
 import { getUsers, getUserById, updateUser, deleteUser, USER_ROLES, OWNER_USER_ID } from 'officerdb';
 import type { UserRole } from 'officerdb';
 import * as errors from '@@/custom-errors';
-import { OS_USERS_ENABLED } from '@@/os-user';
 import { deprovisionOsAccount } from '@@/os-user-deprovision';
 import { DATA_PATH } from '@@/data-path';
 
@@ -56,9 +55,6 @@ export const listUsersHandler: Handler = async function (ctx) {
     roles: USER_ROLES,
     assignableRoles: USER_ROLES.filter((r) => r !== 'Super Admin'),
     ownerId: OWNER_USER_ID,
-    // So the UI offers the Linux-account controls only where they can work. On a host without the feature
-    // they would be a button that always reports the same refusal.
-    osUsersEnabled: OS_USERS_ENABLED,
   });
 };
 
@@ -119,7 +115,7 @@ export const deleteUserHandler: Handler = async function (ctx) {
   // first and a failed deprovision is unrecoverable through the UI: no row, no osUser, nothing to retry
   // against. Keeping the account on failure is also the safer half of the trade — an account that still
   // exists is inert, whereas a freed uid whose files still carry it is the hazard itself.
-  if (OS_USERS_ENABLED && existing.osUser) {
+  if (existing.osUser) {
     const deprovisioned = await deprovisionOsAccount({ email: existing.email, osUser: existing.osUser });
     if (!deprovisioned.ok) {
       // Loud on purpose. A missing Docker install warns into a log; this one names the account, the stage

src/servers/api/users/provision-os.ts

@@ -1,5 +1,5 @@
 import { updateUser } from 'officerdb';
-import { OS_USERS_ENABLED, ensureOsUser, osUserHome } from '@@/os-user';
+import { ensureOsUser, osUserHome } from '@@/os-user';
 import { provisionSshAccess } from '@@/os-user-ssh';
 import { seedShellConfig } from '@@/os-user-shell';
 import { provisionClaudeCli } from '@@/os-user-claude';
@@ -12,7 +12,7 @@ import { provisionUserDirs } from '@@/data-path';
 // it has to happen at — the same reasoning as app-store/members.ts. The list of reasons a retry is needed is
 // not exotic:
 //
-//   - the host was not set up for it when the account was made (`OFFICER_OS_USERS` off, no sudoers entry)
+//   - the host was not set up for it when the account was made (no sudoers entry for the service user)
 //   - an ancestor directory was not traversable, which is the one everybody hits once
 //   - the owner wants to replace the inbound SSH key
 //
@@ -42,10 +42,6 @@ export async function provisionOsAccount(params: {
   /** Inbound SSH key for `authorized_keys`. Already validated by the caller. */
   inboundKey?: string | null;
 }): Promise<OsProvisionOutcome> {
-  if (!OS_USERS_ENABLED) {
-    return { osUser: null, sshPublicKey: null, error: 'per-user Linux accounts are not enabled on this server' };
-  }
-
   // First, because a missing skeleton is the reason `useradd --home-dir … -M` would have nothing to point at.
   try {
     provisionUserDirs(params.email);