step 4/4: the docs say permissions too, and capability means one thing again
44 files of prose — CLAUDE.md, AGENTS.md, TODO.md, 20 docs, both plugin design
documents, and the comment surface the earlier steps could not reach.
Applied against an explicit keep-list, not swept, because the word turned out to
have SIX meanings in this repository rather than the three the offscale doc
recorded:
permissions renamed (steps 1–2)
$OFFICER_ROOT/capabilities/ KEPT — the item store, and now the only thing
the word means that is ours
sidecar routing keys renamed to `handles` (step 3)
Lightning wallet KEPT — a domain term, and on the wire to the mobile apps
terminfo queries KEPT — XTGETTCAP, in the pty sidecar
InvoiceShelf KEPT — per-resource { write, bulkDelete } flags
The sweep still falsified two things, both caught by checking rather than by
review, and both in prose that discusses more than one meaning at once:
CLAUDE.md began claiming the item store lives at `$OFFICER_ROOT/permissions`.
It does not; that directory is on disk and full of skills and tools.
And the offscale doc's own note about the collision became
"Named `permissions`, NOT `permissions`" — a sentence that had eaten the thing
it existed to warn about.
Both restored, and the note rewritten to say what is now true: capability means
one thing of ours, and three that belong to somebody else's vocabulary.
Verified live after restart: self and admin permission endpoints 200, gated
route 200, agent-status 200, 9 grants intact with 6 permissions offered.
tsgo clean, 797 tests, 787 pass, same 7.
The rename is done. Four steps, no data lost, no client break that survived
the step it was introduced in.
This commit is contained in:
@@ -109,7 +109,7 @@ permissionAdminRouter.get('/permissions', ownerGate, async (ctx) => {
|
||||
// database refuses a row for that role.
|
||||
roles: USER_ROLES.filter((r) => r !== 'Super Admin'),
|
||||
// The column is `permission` now too, so this is a straight pass-through again. It was briefly a
|
||||
// mapping — the wire said `permission` while the column still said `capability` — which is what let
|
||||
// mapping — the wire said `permission` while the column still said `permission` — which is what let
|
||||
// the table be renamed without any client noticing.
|
||||
grants: await getAllRoleGrants(),
|
||||
});
|
||||
|
||||
@@ -16,10 +16,14 @@
|
||||
/**
|
||||
* A permission the plugin adds to the platform's permission system.
|
||||
*
|
||||
* Called `permissions`, and that word is used throughout the plugin system deliberately. The other one
|
||||
* already means three different things here — the permission registry, the file-based item store under
|
||||
* `$OFFICER_ROOT/permissions`, and the routing keys a sidecar registers with — and a fourth meaning
|
||||
* would be one too many. Nothing in this system uses it.
|
||||
* Called `permissions`, and the plugin system used that word first — before the platform did. On
|
||||
* 2026-08-15 the rest of the codebase followed: the registry moved to `permissions/`, its table to
|
||||
* `role_permissions`, and the sidecar's routing keys became `handles`.
|
||||
*
|
||||
* `capability` now means exactly one thing, the file-based item store under `$OFFICER_ROOT/capabilities`
|
||||
* — skills, tools, tasks. Three other uses survive because they are somebody else's vocabulary rather
|
||||
* than ours: the wallet's Lightning backend features, the pty sidecar's terminfo queries, and
|
||||
* InvoiceShelf's per-resource flags.
|
||||
*/
|
||||
export type PluginPermission = {
|
||||
/** Stable identifier, stored as the grant's subject. Renaming one is a data change. */
|
||||
|
||||
@@ -28,7 +28,7 @@ afterEach(() => {
|
||||
while (registered.length) unregisterSidecar(registered.pop()!);
|
||||
});
|
||||
|
||||
/** Wait until a request has actually reached the socket — spawnClaude awaits waitForCapability first. */
|
||||
/** Wait until a request has actually reached the socket — spawnClaude awaits waitForPermission first. */
|
||||
async function awaitSend(socket: { sent: string[] }): Promise<void> {
|
||||
for (let i = 0; i < 50 && socket.sent.length === 0; i++) await Bun.sleep(1);
|
||||
expect(socket.sent).not.toHaveLength(0);
|
||||
|
||||
@@ -25,7 +25,7 @@ import { API_URL, OFFICER_API_URL, ANTHROPIC_PROXY_URL } from '../../officer-url
|
||||
// this process can work. CLAUDE_USER_EMAIL still wins when set, for manual runs.
|
||||
//
|
||||
// "The owner" is not a simplification that multi-user will later invalidate. `chat` is an `execution`
|
||||
// capability (capabilities/registry.ts) and is never grantable at any level, so no account other than
|
||||
// permission (permissions/registry.ts) and is never grantable at any level, so no account other than
|
||||
// the owner can ever reach this sidecar, however many accounts exist.
|
||||
//
|
||||
// ── Why this retries rather than throws ──
|
||||
@@ -79,7 +79,7 @@ const OFFICER_AUTH_TOKEN = await sign({ id: dbUser.id, email, username: dbUser.u
|
||||
// The owner runs Claude with no isolation — real HOME, real ~/.claude — so platform sessions have
|
||||
// perfect parity with terminal sessions (same config, credentials and transcript store,
|
||||
// interchangeable via `claude --resume`). That absence of isolation is precisely why `chat` is an
|
||||
// `execution` capability and can never be granted: this is a shell, not a feature flag.
|
||||
// `execution` permission and can never be granted: this is a shell, not a feature flag.
|
||||
// Evaluated here, ABOVE the `process.env.HOME = homeDir` below: homedir() reads $HOME, so a
|
||||
// read placed after that assignment would return whatever was last spawned into.
|
||||
const homeDir = homedir();
|
||||
|
||||
@@ -11,7 +11,7 @@ describe('resolveNotifyUser', () => {
|
||||
});
|
||||
|
||||
// The regression this module exists for: `body.userId ?? header` let any account holding the
|
||||
// `notify` capability push to any other account's devices by naming them in a JSON body.
|
||||
// `notify` permission push to any other account's devices by naming them in a JSON body.
|
||||
test('the header beats a conflicting body userId', () => {
|
||||
expect(resolveNotifyUser({ header: '13', bodyUserId: 1 })).toBe(13);
|
||||
expect(resolveNotifyUser({ header: '1', bodyUserId: 13 })).toBe(1);
|
||||
|
||||
@@ -10,7 +10,7 @@
|
||||
//
|
||||
// So the header wins wherever it is present. This lives in its own module, away from the Bun.serve
|
||||
// entrypoint, purely so it can be tested — it is an access-control decision, and the version that read
|
||||
// `body.userId ?? header` let any account holding the `notify` capability push to any other account's
|
||||
// `body.userId ?? header` let any account holding the `notify` permission push to any other account's
|
||||
// devices by naming them in a JSON body.
|
||||
|
||||
type ResolveUserParams = {
|
||||
|
||||
Reference in New Issue
Block a user