step 4/4: the docs say permissions too, and capability means one thing again
44 files of prose — CLAUDE.md, AGENTS.md, TODO.md, 20 docs, both plugin design
documents, and the comment surface the earlier steps could not reach.
Applied against an explicit keep-list, not swept, because the word turned out to
have SIX meanings in this repository rather than the three the offscale doc
recorded:
permissions renamed (steps 1–2)
$OFFICER_ROOT/capabilities/ KEPT — the item store, and now the only thing
the word means that is ours
sidecar routing keys renamed to `handles` (step 3)
Lightning wallet KEPT — a domain term, and on the wire to the mobile apps
terminfo queries KEPT — XTGETTCAP, in the pty sidecar
InvoiceShelf KEPT — per-resource { write, bulkDelete } flags
The sweep still falsified two things, both caught by checking rather than by
review, and both in prose that discusses more than one meaning at once:
CLAUDE.md began claiming the item store lives at `$OFFICER_ROOT/permissions`.
It does not; that directory is on disk and full of skills and tools.
And the offscale doc's own note about the collision became
"Named `permissions`, NOT `permissions`" — a sentence that had eaten the thing
it existed to warn about.
Both restored, and the note rewritten to say what is now true: capability means
one thing of ours, and three that belong to somebody else's vocabulary.
Verified live after restart: self and admin permission endpoints 200, gated
route 200, agent-status 200, 9 grants intact with 6 permissions offered.
tsgo clean, 797 tests, 787 pass, same 7.
The rename is done. Four steps, no data lost, no client break that survived
the step it was introduced in.
This commit is contained in:
@@ -17,7 +17,7 @@ it_ — earned its place three separate times, detailed below.
|
||||
| `22bcd7d` | B1 + B3 — session listing, and a resumed session's directory |
|
||||
| `492509a` | B2 — route a resumed OpenCode session to OpenCode |
|
||||
| `013e629` | B4 (first attempt), B5, B6, thinking selector |
|
||||
| `7774a25` | B4 properly — gate the composer on the capability |
|
||||
| `7774a25` | B4 properly — gate the composer on the permission |
|
||||
| `cfbf58c` | Delete the `AGENTS.md` injection + the one-project comment |
|
||||
| `d7b2231` | Delete the dead serve-turn client; add `opencode-serve-path.md` |
|
||||
| `8b409e8` | Phase 1 finish — stale comments, version pin, first tests |
|
||||
@@ -91,8 +91,8 @@ conclusion independently, which was reassuring to read afterwards.)
|
||||
|
||||
**B4 — closed the way your review asked, not the way the parity doc did.** The doc offered the flag flip
|
||||
as "the honest one-liner"; you correctly pointed out that flipping it changed nothing observable because
|
||||
no code read the capability. The composer now gates on it — drop zone, paste path, attach menu — so the
|
||||
flag is load-bearing. Unknown model still allows images: a missing capability should not remove a
|
||||
no code read the permission. The composer now gates on it — drop zone, paste path, attach menu — so the
|
||||
flag is load-bearing. Unknown model still allows images: a missing permission should not remove a
|
||||
working control.
|
||||
|
||||
**Thinking selector — removed, not hidden.** The doc said hide; hiding a control that does nothing still
|
||||
@@ -135,7 +135,7 @@ Testing was explicitly de-prioritised for this pass, so these are recorded rathe
|
||||
|
||||
## Suggested next, if you are writing the following spec
|
||||
|
||||
1. **Exercise `opencode:list`** — it is the only new capability whose happy path is unproven.
|
||||
1. **Exercise `opencode:list`** — it is the only new permission whose happy path is unproven.
|
||||
2. **Decide the fork.** The blocker is gone; `opencode-serve-path.md` frames it. If the answer is "not
|
||||
yet", say so in the parity doc so it stops reading as pending work.
|
||||
3. **The remaining Phase 1 residue**: `sweepStaleServes` is `/proc`-based and a no-op on macOS (B8), and
|
||||
|
||||
Reference in New Issue
Block a user