fofos/fofos-admin
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sort the walk, because readdir does not

Browse Source 
`readdir` returns entries in the filesystem's own order — inode order on ext4 —
which is arbitrary and stable only until somebody moves a file.

Harmless for the sync, which does the same work whatever the order. Not harmless
for "Create Gallery": that list becomes the gallery's initial order, and nine
photographs arriving as 05, 08, 01, 07 reads as a bug even though nothing is
wrong.

`numeric` collation, so galeria2 sorts before galeria10 — which is what anybody
naming files that way means.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
pastilhas
2026-08-29 21:32:32 +01:00
co-authored by Claude Opus 5
parent 9c62777f5b
commit 300edfb023
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/derive.ts
+13 -1
View File
@@ -401,7 +401,19 @@ async function buildVideo(
/** Every file under `originals/`, relative to it, depth first. Directories are structure, not work. */ /** Every file under `originals/`, relative to it, depth first. Directories are structure, not work. */
export async function listOriginals(root: string, prefix = ''): Promise<string[]> { export async function listOriginals(root: string, prefix = ''): Promise<string[]> {
const entries = await readdir(join(root, prefix), { withFileTypes: true }).catch(() => []); /*
Sorted, because `readdir` is not.
It returns entries in the filesystem's own order — inode order on ext4 — which is arbitrary and
stable only until somebody moves a file. That is harmless for the sync, which does the same work in
any order, and it is not harmless for "Create Gallery": this list becomes the gallery's initial
order, and nine photographs arriving as 05, 08, 01, 07 reads as a bug even though nothing is wrong.
`numeric` so `galeria2` sorts before `galeria10`, which is what anybody naming files that way means.
*/
const entries = (await readdir(join(root, prefix), { withFileTypes: true }).catch(() => [])).sort((a, b) =>
a.name.localeCompare(b.name, undefined, { numeric: true, sensitivity: 'base' }),
);
const found: string[] = []; const found: string[] = [];
for (const entry of entries) { for (const entry of entries) {